Apply gofumpt and gci formatting. Explicitly enable errcheck in config

file

Signed-off-by: Dom Del Nano <ddelnano@gmail.com>

Author: ddelnano

.golangci.yaml

@@ -13,6 +13,7 @@ linters:
   - predeclared
   - revive
   - whitespace
+  - errcheck
   settings:
     errcheck:
       exclude-functions:
@@ -52,8 +53,15 @@ issues:
   max-same-issues: 0
 formatters:
   enable:
-  - gofmt
+  - gci
+  - gofumpt
   settings:
+    gci:
+      sections:
+      - standard
+      - default
+      - prefix(px.dev)
+      custom-order: true
     goimports:
       local-prefixes:
       - px.dev

src/api/go/pxapi/examples/basic_example/example.go

@@ -28,15 +28,13 @@ import (
 	"px.dev/pixie/src/api/go/pxapi/types"
 )
 
-var (
-	pxl = `
+var pxl = `
 import px
 df = px.DataFrame('http_events')
 df = df[['upid', 'req_path', 'remote_addr', 'req_method']]
 df = df.head(10)
 px.display(df, 'http')
 `
-)
 
 type tablePrinter struct{}
 
@@ -56,8 +54,7 @@ func (t *tablePrinter) HandleDone(ctx context.Context) error {
 	return nil
 }
 
-type tableMux struct {
-}
+type tableMux struct{}
 
 func (s *tableMux) AcceptTable(ctx context.Context, metadata types.TableMetadata) (pxapi.TableRecordHandler, error) {
 	return &tablePrinter{}, nil

src/api/go/pxapi/examples/encryption_example/example.go

@@ -28,15 +28,13 @@ import (
 	"px.dev/pixie/src/api/go/pxapi/types"
 )
 
-var (
-	pxl = `
+var pxl = `
 import px
 df = px.DataFrame('http_events')
 df = df[['upid', 'req_path', 'remote_addr', 'req_method']]
 df = df.head(10)
 px.display(df, 'http')
 `
-)
 
 type tablePrinter struct{}
 
@@ -56,8 +54,7 @@ func (t *tablePrinter) HandleDone(ctx context.Context) error {
 	return nil
 }
 
-type tableMux struct {
-}
+type tableMux struct{}
 
 func (s *tableMux) AcceptTable(ctx context.Context, metadata types.TableMetadata) (pxapi.TableRecordHandler, error) {
 	return &tablePrinter{}, nil

src/api/go/pxapi/examples/example_mux/example.go

@@ -30,16 +30,14 @@ import (
 	"px.dev/pixie/src/api/go/pxapi/types"
 )
 
-var (
-	pxl = `
+var pxl = `
 import px
 df = px.DataFrame('http_events')
 df = df[['upid', 'req_path', 'remote_addr', 'req_method']]
 df = df.head(10)
 px.display(df, 'http_as_json')
 px.display(df, 'http_as_table')
 `
-)
 
 func main() {
 	apiKey, ok := os.LookupEnv("PX_API_KEY")

src/api/go/pxapi/examples/standalone_pem_example/example.go

@@ -90,6 +90,7 @@ type tablePrinter struct{}
 func (t *tablePrinter) HandleInit(ctx context.Context, metadata types.TableMetadata) error {
 	return nil
 }
+
 func (t *tablePrinter) HandleRecord(ctx context.Context, r *types.Record) error {
 	for _, d := range r.Data {
 		fmt.Printf("%s ", d.String())
@@ -103,8 +104,7 @@ func (t *tablePrinter) HandleDone(ctx context.Context) error {
 }
 
 // Satisfies the TableMuxer interface.
-type tableMux struct {
-}
+type tableMux struct{}
 
 func (s *tableMux) AcceptTable(ctx context.Context, metadata types.TableMetadata) (pxapi.TableRecordHandler, error) {
 	return &tablePrinter{}, nil

src/api/go/pxapi/examples/streaming_example/example.go

@@ -28,13 +28,11 @@ import (
 	"px.dev/pixie/src/api/go/pxapi/types"
 )
 
-var (
-	pxl = `
+var pxl = `
 import px
 df = px.DataFrame('http_events', start_time='-5m')[['resp_status','req_path']]
 px.display(df.stream(), 'http_table')
 `
-)
 
 type tablePrinter struct{}
 
@@ -54,8 +52,7 @@ func (t *tablePrinter) HandleDone(ctx context.Context) error {
 	return nil
 }
 
-type tableMux struct {
-}
+type tableMux struct{}
 
 func (s *tableMux) AcceptTable(ctx context.Context, metadata types.TableMetadata) (pxapi.TableRecordHandler, error) {
 	return &tablePrinter{}, nil

src/api/go/pxapi/results.go

@@ -181,7 +181,6 @@ func (s *ScriptResults) run() error {
 	ctx := s.c.Context()
 	for {
 		resp, err := s.c.Recv()
-
 		if err != nil {
 			if err == io.EOF {
 				// Stream has terminated.

src/api/go/pxapi/vizier.go

@@ -22,7 +22,6 @@ import (
 	"context"
 
 	"px.dev/pixie/src/api/go/pxapi/errdefs"
-
 	"px.dev/pixie/src/api/proto/vizierpb"
 )
 

src/carnot/docstring/pkg/docstring.go

@@ -80,6 +80,7 @@ func (w *parser) ArgMatch(s string) bool {
 
 	return allRe.MatchString(s) && w.isTabbedLine(s)
 }
+
 func (w *parser) ReturnMatch(s string) bool {
 	allRe := re.MustCompile(w.ReturnReStr())
 
@@ -373,8 +374,10 @@ func parseDocstring(docString string) (*FunctionDocstring, error) {
 	return p.parsedDoc, nil
 }
 
-const topicRegex = `:topic: (?P<topic>[^\s]*)\n`
-const opnameRegex = `:opname: (?P<opname>.*)\n`
+const (
+	topicRegex  = `:topic: (?P<topic>[^\s]*)\n`
+	opnameRegex = `:opname: (?P<opname>.*)\n`
+)
 
 // getTag finds the tag in the docstring if it exists.
 func getTag(docstring, tagRegex string) string {

src/carnot/docstring/tables/datatables.go

@@ -36,13 +36,11 @@ import (
 	"px.dev/pixie/src/shared/services"
 )
 
-var (
-	pxl = `
+var pxl = `
 import px
 px.display(px.GetTables(), 'table_desc')
 px.display(px.GetSchemas(), 'table_schemas')
 `
-)
 
 func init() {
 	pflag.String("cluster_id", "", "The cluster_id of the cluster to query")