Skip to content

Commit 6943ac4

Browse files
committed
review development.md, and add extra comments
1 parent b230cb5 commit 6943ac4

1 file changed

Lines changed: 11 additions & 3 deletions

File tree

DEVELOPMENT.md

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ sudo chmod 2775 <directory-path>
6666
2) Create/Use a registry you control and login
6767

6868
```sh
69-
docker login ghcr.io/myregistry
69+
docker login ghcr.io/<myregistry>
7070
```
7171

7272
3) Make Minikube run and deploy a vanilla pixie
@@ -82,12 +82,20 @@ export PX_CLOUD_ADDR=getcosmic.ai
8282
px auth
8383
px deploy -p=1Gi
8484
```
85-
4) Skaffold to deploy (after you have the vanilla setup working on minikube)
85+
For reference and further information https://docs.px.dev/installing-pixie/install-guides/hosted-pixie/cosmic-cloud
86+
87+
4) Once you make changes on source code, or switch to another source code version, use Skaffold to deploy (after you have the vanilla setup working on minikube)
8688

8789
your docker login token must still be valid
8890

8991
```sh
90-
skaffold run -f skaffold/skaffold_vizier.yaml -p x86_64_sysroot --default-repo=ghcr.io/k8sstormcenter
92+
> skaffold run -f skaffold/skaffold_vizier.yaml -p x86_64_sysroot --default-repo=ghcr.io/<myregistry>
93+
```
94+
95+
Optional: you can set default-repo on config, so that you don't need to pass it as an argument everytime
96+
```sh
97+
> skaffold config set default-repo ghcr.io/<myregistry>
98+
> skaffold run -f skaffold/skaffold_vizier.yaml -p x86_64_sysroot
9199
```
92100

93101
5) Golden image

0 commit comments

Comments
 (0)