Upgrade golangci-lint to v2

Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
(cherry picked from commit 9d994d8)

Author: ddelnano

.arclint

@@ -140,7 +140,7 @@
       ],
       "flags": [
         "--timeout=5m0s",
-        "--out-format=checkstyle"
+        "--output.checkstyle.path=stdout"
       ]
     },
     "jshint-ui": {

.golangci.yaml

@@ -1,62 +1,59 @@
 ---
+version: "2"
 run:
-  # Tell golangci-lint to not acquire a lock because
-  # arcanist will run multiple instances in parallel.
   allow-parallel-runners: true
-  # arcanist runs many of these in parallel causing
-  # CPU contention and longer runtimes.
-  timeout: 3m
-
-output:
-  sort-results: true
-
-issues:
-  max-issues-per-linter: 0
-  max-same-issues: 0
-  # TODO(ddelnano): Remove once typecheck is upgraded in next golangci-lint upgrade
-  # This error originates from the stdlib due to generics usage
-  exclude-rules:
-  - path: .*slices\/sort.go
-    linters:
-    - typecheck
-    text: "^(undefined: (min|max))"
-
 linters:
   enable:
   - asciicheck
-  - errcheck
-  # Although goimports includes gofmt, it doesn't support the simplify option.
-  # So we include gofmt here.
-  - gofmt
-  - gosimple
-  - govet
-  - ineffassign
   - makezero
   - misspell
   - nakedret
   - nolintlint
   - nonamedreturns
   - predeclared
   - revive
-  - staticcheck
-  # https://github.com/golangci/golangci-lint/issues/2649
-  # - structcheck
-  - typecheck
-  - unused
-  # https://github.com/golangci/golangci-lint/issues/2649
-  # - wastedassign
   - whitespace
-  disable:
-  # The following linters are run separately by arcanist at the moment.
-  # This is because we have autofix hooks for these linters.
-  - goimports
-  disable-all: false
-
-linters-settings:
-  errcheck:
-    # yamllint disable-line rule:line-length
-    ignore: io:Close,github.com/fatih/color,github.com/spf13/pflag:MarkHidden,github.com/spf13/viper:(BindEnv|BindPFlag),github.com/spf13/cobra:(Help|MarkFlagRequired|Usage),github.com/segmentio/analytics-go/v3:Enqueue,database/sql:Rollback,github.com/nats-io/nats.go:Unsubscribe
-  goimports:
-    local-prefixes: px.dev
-  nakedret:
-    max-func-lines: 0
+  settings:
+    errcheck:
+      exclude-functions:
+      - io.Close
+      - github.com/spf13/pflag.MarkHidden
+      - github.com/spf13/viper.BindEnv
+      - github.com/spf13/viper.BindPFlag
+      - github.com/spf13/cobra.Help
+      - github.com/spf13/cobra.MarkFlagRequired
+      - github.com/spf13/cobra.Usage
+      - (github.com/segmentio/analytics-go/v3.Client).Enqueue
+      - database/sql.Rollback
+      - github.com/nats-io/nats.go.Unsubscribe
+    staticcheck:
+      checks:
+      - all
+      - "-ST1005"  # ignore the "ST1005: error strings should not be capitalized" check
+  exclusions:
+    generated: lax
+    presets:
+    - comments
+    - common-false-positives
+    - legacy
+    - std-error-handling
+    paths:
+    - third_party$
+    - builtin$
+    - examples$
+issues:
+  max-issues-per-linter: 0
+  max-same-issues: 0
+formatters:
+  enable:
+  - gofmt
+  settings:
+    goimports:
+      local-prefixes:
+      - px.dev
+  exclusions:
+    generated: lax
+    paths:
+    - third_party$
+    - builtin$
+    - examples$

docker.properties

@@ -1,4 +1,4 @@
-DOCKER_IMAGE_TAG=202502242148
-LINTER_IMAGE_DIGEST=eb7613e8aab9eb4620d6fae2618c966092abca8734abf90f0238db7de4535f15
-DEV_IMAGE_DIGEST=8316e718b16de940e2a5ac64fb6e57dc9ed28ca2ed437302e339964e9b42c9f2
-DEV_IMAGE_WITH_EXTRAS_DIGEST=b6d4c2404b30d06c2322d531620dcbe810a2c534f1cd0aa2389c75ed91d9bc24
+DOCKER_IMAGE_TAG=202504121153
+LINTER_IMAGE_DIGEST=ff369d95c4c84c95b668498219fda60ff8126828839171262f2eee58bd95ce19
+DEV_IMAGE_DIGEST=91e7fb85e0497340df5efaf035b65d98eab458908f852a782aeeb5ea0b69b5c9
+DEV_IMAGE_WITH_EXTRAS_DIGEST=f90e8b9b69d5870a7115ad434388da7bcef05f4a6c47e937a5a6348a22613ab4

tools/arc_addons/pixielabs/lint/ArcanistGolangCiLinter.php

@@ -49,7 +49,7 @@ public function getInstallInstructions() {
   }
 
   protected function getDefaultFlags() {
-    return array('--out-format=checkstyle');
+    return array('--output.text.path=stdout');
   }
 
   protected function getPathArgumentForLinterFuture($path) {
@@ -95,6 +95,11 @@ protected function parseLinterOutput($path, $err, $stdout, $stderr) {
       return [$message];
     }
 
+    $lines = explode("\n", $stdout);
+    // golangci-lint outputs a summary at the end of the output, which we
+    // don't want to parse. See the example below:
+    // 0 issues.
+    $stdout = preg_replace('/\d+ issue(?:s)?\./', '', $stdout);
     $ok = @$report_dom->loadXML($stdout);
 
     if (!$ok) {

tools/chef/cookbooks/px_dev/attributes/linux.rb

@@ -38,9 +38,9 @@
   'dea9ca38a0b852a74e81c26134671af7c0fbe65d81b0dc1c5bfe22cf7d4c8858'
 
 default['golangci-lint']['download_path'] =
-  'https://github.com/golangci/golangci-lint/releases/download/v1.51.1/golangci-lint-1.51.1-linux-amd64.tar.gz'
+  'https://github.com/golangci/golangci-lint/releases/download/v2.0.2/golangci-lint-2.0.2-linux-amd64.tar.gz'
 default['golangci-lint']['sha256'] =
-  '17aeb26c76820c22efa0e1838b0ab93e90cfedef43fbfc9a2f33f27eb9e5e070'
+  '89cc8a7810dc63b9a37900da03e37c3601caf46d42265d774e0f1a5d883d53e2'
 
 default['nodejs']['download_path'] =
   'https://nodejs.org/dist/v18.16.0/node-v18.16.0-linux-x64.tar.xz'

tools/chef/cookbooks/px_dev/attributes/mac_os_x.rb

@@ -39,9 +39,9 @@
   '7af054e5088b68c24b3d6e135e5ca8d91bbd5a05cb7f7f0187367b3e6e9e05ee'
 
 default['golangci-lint']['download_path'] =
-  'https://github.com/golangci/golangci-lint/releases/download/v1.51.1/golangci-lint-1.51.1-darwin-amd64.tar.gz'
+  'https://github.com/golangci/golangci-lint/releases/download/v2.0.2/golangci-lint-2.0.2-darwin-amd64.tar.gz'
 default['golangci-lint']['sha256'] =
-  'fba08acc4027f69f07cef48fbff70b8a7ecdfaa1c2aba9ad3fb31d60d9f5d4bc'
+  'a88cbdc86b483fe44e90bf2dcc3fec2af8c754116e6edf0aa6592cac5baa7a0e'
 
 default['nodejs']['download_path'] =
   'https://nodejs.org/dist/v18.16.0/node-v18.16.0-darwin-x64.tar.gz'