Skip to content

Commit c186bba

Browse files
committed
Fix missing file issues
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
1 parent b70029a commit c186bba

2 files changed

Lines changed: 9 additions & 34 deletions

File tree

src/stirling/obj_tools/dwarf_reader_test.cc

Lines changed: 8 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -24,34 +24,19 @@
2424
#include "src/common/testing/testing.h"
2525
#include "src/stirling/utils/detect_application.h"
2626

27-
constexpr std::string_view kTestGo1_17Binary =
28-
"src/stirling/obj_tools/testdata/go/test_go_1_17_binary";
29-
constexpr std::string_view kTestGo1_18Binary =
30-
"src/stirling/obj_tools/testdata/go/test_go_1_18_binary";
31-
constexpr std::string_view kTestGo1_19Binary =
32-
"src/stirling/obj_tools/testdata/go/test_go_1_19_binary";
33-
constexpr std::string_view kTestGo1_20Binary =
34-
"src/stirling/obj_tools/testdata/go/test_go_1_20_binary";
35-
constexpr std::string_view kTestGo1_21Binary =
36-
"src/stirling/obj_tools/testdata/go/test_go_1_21_binary";
37-
constexpr std::string_view kTestGo1_22Binary =
38-
"src/stirling/obj_tools/testdata/go/test_go_1_22_binary";
3927
constexpr std::string_view kTestGo1_23Binary =
4028
"src/stirling/obj_tools/testdata/go/test_go_1_23_binary";
29+
constexpr std::string_view kTestGo1_24Binary =
30+
"src/stirling/obj_tools/testdata/go/test_go_1_23_binary";
4131
constexpr std::string_view kGoGRPCServer =
42-
"src/stirling/testing/demo_apps/go_grpc_tls_pl/server/golang_1_19_grpc_tls_server_binary";
32+
"src/stirling/testing/demo_apps/go_grpc_tls_pl/server/golang_1_24_grpc_tls_server_binary";
4333
constexpr std::string_view kCppBinary = "src/stirling/obj_tools/testdata/cc/test_exe_/test_exe";
4434
constexpr std::string_view kGoBinaryUnconventional =
4535
"src/stirling/obj_tools/testdata/go/sockshop_payments_service";
4636

4737
const auto kCPPBinaryPath = px::testing::BazelRunfilePath(kCppBinary);
48-
const auto kGo1_17BinaryPath = px::testing::BazelRunfilePath(kTestGo1_17Binary);
49-
const auto kGo1_18BinaryPath = px::testing::BazelRunfilePath(kTestGo1_18Binary);
50-
const auto kGo1_19BinaryPath = px::testing::BazelRunfilePath(kTestGo1_19Binary);
51-
const auto kGo1_20BinaryPath = px::testing::BazelRunfilePath(kTestGo1_20Binary);
52-
const auto kGo1_21BinaryPath = px::testing::BazelRunfilePath(kTestGo1_21Binary);
53-
const auto kGo1_22BinaryPath = px::testing::BazelRunfilePath(kTestGo1_22Binary);
5438
const auto kGo1_23BinaryPath = px::testing::BazelRunfilePath(kTestGo1_23Binary);
39+
const auto kGo1_24BinaryPath = px::testing::BazelRunfilePath(kTestGo1_24Binary);
5540
const auto kGoServerBinaryPath = px::testing::BazelRunfilePath(kGoGRPCServer);
5641
const auto kGoBinaryUnconventionalPath = px::testing::BazelRunfilePath(kGoBinaryUnconventional);
5742

@@ -578,20 +563,10 @@ INSTANTIATE_TEST_SUITE_P(CppDwarfReaderParameterizedTest, CppDwarfReaderTest,
578563
DwarfReaderTestParam{kCPPBinaryPath, false}));
579564

580565
INSTANTIATE_TEST_SUITE_P(GolangDwarfReaderParameterizedTest, GolangDwarfReaderTest,
581-
::testing::Values(DwarfReaderTestParam{kGo1_17BinaryPath, true},
582-
DwarfReaderTestParam{kGo1_17BinaryPath, false},
583-
DwarfReaderTestParam{kGo1_18BinaryPath, true},
584-
DwarfReaderTestParam{kGo1_18BinaryPath, false},
585-
DwarfReaderTestParam{kGo1_19BinaryPath, true},
586-
DwarfReaderTestParam{kGo1_19BinaryPath, false},
587-
DwarfReaderTestParam{kGo1_20BinaryPath, true},
588-
DwarfReaderTestParam{kGo1_20BinaryPath, false},
589-
DwarfReaderTestParam{kGo1_21BinaryPath, true},
590-
DwarfReaderTestParam{kGo1_21BinaryPath, false},
591-
DwarfReaderTestParam{kGo1_22BinaryPath, true},
592-
DwarfReaderTestParam{kGo1_22BinaryPath, false},
593-
DwarfReaderTestParam{kGo1_23BinaryPath, true},
594-
DwarfReaderTestParam{kGo1_23BinaryPath, false}));
566+
::testing::Values(DwarfReaderTestParam{kGo1_23BinaryPath, true},
567+
DwarfReaderTestParam{kGo1_23BinaryPath, false},
568+
DwarfReaderTestParam{kGo1_24BinaryPath, true},
569+
DwarfReaderTestParam{kGo1_24BinaryPath, false}));
595570

596571
INSTANTIATE_TEST_SUITE_P(GolangDwarfReaderParameterizedIndexTest, GolangDwarfReaderIndexTest,
597572
::testing::Values(true, false));

src/stirling/source_connectors/dynamic_tracer/dynamic_tracing/autogen_test.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
#include "src/common/testing/testing.h"
2323
#include "src/stirling/source_connectors/dynamic_tracer/dynamic_tracing/autogen.h"
2424

25-
constexpr std::string_view kBinaryPath = "src/stirling/obj_tools/testdata/go/test_go_1_21_binary";
25+
constexpr std::string_view kBinaryPath = "src/stirling/obj_tools/testdata/go/test_go_1_24_binary";
2626

2727
namespace px {
2828
namespace stirling {

0 commit comments

Comments
 (0)