Push to ghcr.io/pixie-io due to New Relic deprecation

Signed-off-by: Dom Del Nano <ddelnano@gmail.com>

Author: ddelnano

.github/workflows/vizier_release.yaml

@@ -6,6 +6,7 @@ on:
     - release/vizier/**
 permissions:
   contents: read
+  packages: write
 env:
   VERSIONS_FILE: "VERSIONS.json"
 jobs:
@@ -33,10 +34,8 @@ jobs:
       with:
         download_toplevel: 'true'
         BB_API_KEY: ${{ secrets.BB_IO_API_KEY }}
-    - id: gcloud-creds
-      uses: ./.github/actions/gcloud_creds
-      with:
-        SERVICE_ACCOUNT_KEY: ${{ secrets.GH_RELEASE_SA_PEM_B64 }}
+    - name: Login to GHCR
+      run: echo "${{ github.token }}" | docker login ghcr.io -u ${{ github.actor }} --password-stdin
     - name: Import GPG key
       env:
         BUILDBOT_GPG_KEY_B64: ${{ secrets.BUILDBOT_GPG_KEY_B64 }}
@@ -49,7 +48,6 @@ jobs:
         JOB_NAME: ${{ github.job }}
         COSIGN_PASSWORD: ${{secrets.COSIGN_PASSWORD}}
         COSIGN_PRIVATE_KEY: ${{secrets.COSIGN_PRIVATE_KEY}}
-        GOOGLE_APPLICATION_CREDENTIALS: ${{ steps.gcloud-creds.outputs.gcloud-creds }}
         BUILDBOT_GPG_KEY_ID: ${{ secrets.BUILDBOT_GPG_KEY_ID }}
         GH_REPO: ${{ github.repository }}
       shell: bash
@@ -60,20 +58,6 @@ jobs:
         export INDEX_FILE="$(pwd)/index.yaml"
         ./ci/save_version_info.sh
         ./ci/vizier_build_release.sh
-    - name: Build & Export Docs
-      env:
-        PXL_DOCS_GCS_PATH: "gs://pixie-dev-public/pxl-docs.json"
-      run: |
-        docs="$(mktemp)"
-        bazel run //src/carnot/docstring:docstring -- --output_json "${docs}"
-        gsutil cp "${docs}" "${PXL_DOCS_GCS_PATH}"
-    - name: Update GCS Manifest
-      env:
-        ARTIFACT_MANIFEST_BUCKET: "pixie-dev-public"
-        # Use the old style versions file instead of the new updates for the gcs manifest.
-        MANIFEST_UPDATES: ""
-        GOOGLE_APPLICATION_CREDENTIALS: ${{ steps.gcloud-creds.outputs.gcloud-creds }}
-      run: ./ci/update_artifact_manifest.sh
     - uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02  # v4.6.2
       with:
         name: manifest-updates

ci/artifact_mirrors.yaml

@@ -4,8 +4,3 @@
 - name: gh-releases
   type: gh-releases
   url_format: 'https://github.com/${gh_repo}/releases/download/release/${component}/v${version}/${artifact_name}'
-- name: pixie-oss-gcs
-  type: gcs
-  bucket: pixie-dev-public
-  path_format: '${component}/${version}/${artifact_name}'
-  url_format: 'https://storage.googleapis.com/pixie-dev-public/${component}/${version}/${artifact_name}'

ci/image_utils.sh

@@ -42,13 +42,11 @@ push_multiarch_image() {
   x86_image="${multiarch_image}-x86_64"
   aarch64_image="${multiarch_image}-aarch64"
   echo "Building ${multiarch_image} manifest"
-  # If the multiarch manifest list already exists locally, remove it before building a new one.
-  # otherwise, the docker manifest create step will fail because it can't amend manifests to an existing image.
-  # We could use the --amend flag to `manifest create` but it doesn't seem to overwrite existing images with the same tag,
-  # instead it seems to just ignore images that already exist in the local manifest.
-  docker manifest rm "${multiarch_image}" || true
-  docker manifest create "${multiarch_image}" "${x86_image}" "${aarch64_image}"
-  pushed_digest=$(docker manifest push "${multiarch_image}")
+  crane index append \
+    --manifest "${x86_image}" \
+    --manifest "${aarch64_image}" \
+    --tag "${multiarch_image}"
+  pushed_digest=$(crane digest "${multiarch_image}")
 
   sign_image "${multiarch_image}" "${pushed_digest}"
 }

ci/vizier_build_release.sh

@@ -35,7 +35,7 @@ echo "The release tag is: ${release_tag}"
 bazel run -c opt //src/utils/artifacts/versions_gen:versions_gen -- \
       --repo_path "${repo_path}" --artifact_name vizier --versions_file "${versions_file}"
 
-image_repo="gcr.io/pixie-oss/pixie-prod"
+image_repo="ghcr.io/pixie-io"
 
 push_all_multiarch_images "//k8s/vizier:vizier_images_push" "//k8s/vizier:list_image_bundle" "${release_tag}" "${image_repo}"
 

src/shared/metadata/cgroup_path_resolver.cc

@@ -35,7 +35,7 @@ namespace md {
 
 StatusOr<std::vector<std::string>> CGroupBasePaths(std::string_view sysfs_path) {
   std::vector<std::string> base_paths;
-  // Different hosts may mount different cgroup dirs. Try a couple for robustness.
+  // Different hosts may mount different cgroup dirs. Try a couple for robustness
   const std::vector<std::string> cgroup_dirs = {"cpu,cpuacct", "cpu", "pids"};
 
   for (const auto& cgroup_dir : cgroup_dirs) {