Skip to content

Upgrade controller-gen to address panics from go generate directive#2167

Merged
ddelnano merged 3 commits intopixie-io:mainfrom
ddelnano:ddelnano/fix-controller-gen-generation
Apr 15, 2025
Merged

Upgrade controller-gen to address panics from go generate directive#2167
ddelnano merged 3 commits intopixie-io:mainfrom
ddelnano:ddelnano/fix-controller-gen-generation

Conversation

@ddelnano
Copy link
Copy Markdown
Member

@ddelnano ddelnano commented Apr 3, 2025 •
edited
Loading

Summary: Upgrade controller-gen to address panics from go generate directive

Our go upgrade to 1.24 caused our controller-gen's go generate directive to start failing. This is because the trivialVersions setting of controller-gen was removed. From searching the controller-gen issues, I believe Go 1.22 and later hits this problem for controller-gen versions < v0.14 (kubernetes-sigs/controller-tools#888 (comment))

The pr-genfiles GitHub action that runs our go generates does not trigger on go.mod or go.sum changes, so this was missed when Go was upgraded.

I'm not too familiar with controller-gen and the generated file changes are minor, but please let me know if this requires more extensive testing. If there were larger CRD changes, I would expect that it would require testing on different k8s versions with an operator release build. I don't think this change warrants it, but please advise if you feel differently.

Relevant Issues: N/A

Type of change: /kind bugfix

Test Plan: Inspected generated file changes

  • px.dev_viziers.yaml: Description changes are all whitespace changes and appear equivalent
  • px.dev_viziers.yaml: CRD top level status field was removed. I don't believe our operator code uses this nor did I see any reference from k8s release notes on this deprecation
  • Removal of // +build !ignore_autogenerated -- this is an older syntax from controller-gen's pre Go 1.17 usage

@ddelnano ddelnano mentioned this pull request Apr 12, 2025
Merged
1 task
ddelnano added a commit that referenced this pull request Apr 14, 2025
@ddelnano
Upgrade golangci-lint to v2 (#2169)
abe7238 
Summary: Upgrade golangci-lint to v2

This upgrades golangci-lint to v2 and remediates the golangci-lint
crashes seen in other PRs (#2167). The vast majority of the new
violations have been resolved with the exception of some more stylistic
staticcheck cases.

Rather than ignoring these cases, they should be easy to handle if/when
the offending code is modified. The specific violations can be seen in
the Test plan below.

The pr-genfile-checker issues related to go generate will be fixed in
#2167. I opted to split these changes into two PRs despite them both
needing to be available for a successful build.

Relevant Issues: N/A

Type of change: /kind dependency

Test Plan: Existing build and the following checks
- [x] `CGO_ENABLED=0 golangci-lint run` succeeds for the majority of
checks

<details><summary>command output</summary>

```
root@px-dev-docker-dev-vm:/px/src/px.dev/pixie# CGO_ENABLED=0 golangci-lint run
src/cloud/api/controllers/session_middleware.go:173:2: QF1007: could merge conditional assignment into variable declaration (staticcheck)
        forceBearer := false
        ^
src/cloud/artifact_tracker/controllers/server.go:176:5: QF1001: could apply De Morgan's law (staticcheck)
        if !(at == vpb.AT_DARWIN_AMD64 || at == vpb.AT_LINUX_AMD64 || at == vpb.AT_CONTAINER_SET_YAMLS || at == vpb.AT_CONTAINER_SET_TEMPLATE_YAMLS) {
           ^
src/cloud/autocomplete/suggester.go:176:5: QF1003: could use tagged switch on a.Type (staticcheck)
                                if a.Type == vispb.PX_POD {
                                ^
src/cloud/autocomplete/suggester.go:276:23: QF1001: could apply De Morgan's law (staticcheck)
                        if res.NS != "" && !(md.EsMDType(res.Kind) == md.EsMDTypeNamespace || md.EsMDType(res.Kind) == md.EsMDTypeNode) {
                                           ^
src/cloud/plugin/controllers/server.go:563:5: S1009: should omit nil check; len() for nil maps is defined as zero (staticcheck)
        if req.Configurations != nil && len(req.Configurations) > 0 {
           ^
src/cloud/profile/controllers/server.go:170:2: QF1003: could use tagged switch on err (staticcheck)
        if err == datastore.ErrOrgNotFound {
        ^
src/cloud/project_manager/datastore/datastore_test.go:27:2: ST1019: package "github.com/golang-migrate/migrate/source/go_bindata" is being imported more than once (staticcheck)
        _ "github.com/golang-migrate/migrate/source/go_bindata"
        ^
src/cloud/project_manager/datastore/datastore_test.go:28:2: ST1019(related information): other import of "github.com/golang-migrate/migrate/source/go_bindata" (staticcheck)
        bindata "github.com/golang-migrate/migrate/source/go_bindata"
        ^
src/cloud/shared/idprovider/client.go:535:6: QF1001: could apply De Morgan's law (staticcheck)
                if !(k == "Set-Cookie" || k == "Location") {
                   ^
src/cloud/shared/idprovider/client_test.go:96:44: ST1013: should use constant http.StatusFound instead of numeric literal 302 (staticcheck)
                http.Redirect(w, r, consentURL.String(), 302)
                                                         ^
src/common/testing/test_utils/cert_generator/cert_generator.go:120:2: QF1003: could use tagged switch on keyType (staticcheck)
        if keyType == "pkcs1" {
        ^
src/e2e_test/perf_tool/pkg/metrics/data_loss_handler.go:87:6: QF1009: probably want to use time.Time.Equal instead (staticcheck)
        if (ts == time.Time{}) {
            ^
src/e2e_test/perf_tool/pkg/metrics/prometheus_recorder.go:129:7: QF1001: could apply De Morgan's law (staticcheck)
                        if !(mf.GetType() == io_prometheus_client.MetricType_COUNTER || mf.GetType() == io_prometheus_client.MetricType_GAUGE) {
                           ^
src/e2e_test/perf_tool/pkg/suites/experiments.go:27:2: ST1019: package "px.dev/pixie/src/e2e_test/perf_tool/experimentpb" is being imported more than once (staticcheck)
        "px.dev/pixie/src/e2e_test/perf_tool/experimentpb"
        ^
src/e2e_test/perf_tool/pkg/suites/experiments.go:28:2: ST1019(related information): other import of "px.dev/pixie/src/e2e_test/perf_tool/experimentpb" (staticcheck)
        pb "px.dev/pixie/src/e2e_test/perf_tool/experimentpb"
        ^
src/e2e_test/vizier/exectime/cmd/benchmark.go:136:29: ST1016: methods on the same type should have the same receiver name (seen 1x "t", 4x "d") (staticcheck)
func (d *ErrorDistribution) Append(v interface{}) {
                            ^
src/e2e_test/vizier/exectime/cmd/benchmark.go:175:29: ST1016: methods on the same type should have the same receiver name (seen 1x "t", 5x "d") (staticcheck)
func (d *BytesDistribution) Append(v interface{}) {
                            ^
src/operator/controllers/monitor.go:49:2: ST1019: package "px.dev/pixie/src/operator/apis/px.dev/v1alpha1" is being imported more than once (staticcheck)
        "px.dev/pixie/src/operator/apis/px.dev/v1alpha1"
        ^
src/operator/controllers/monitor.go:50:2: ST1019(related information): other import of "px.dev/pixie/src/operator/apis/px.dev/v1alpha1" (staticcheck)
        pixiev1alpha1 "px.dev/pixie/src/operator/apis/px.dev/v1alpha1"
        ^
src/operator/controllers/monitor.go:194:24: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
        m.podStates.write(pod.ObjectMeta.Labels["name"], pod.ObjectMeta.Name, &podWrapper{pod: pod})
                              ^
src/operator/controllers/monitor.go:204:26: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                m.podStates.delete(pod.ObjectMeta.Labels["name"], pod.ObjectMeta.Name)
                                       ^
src/operator/controllers/monitor.go:207:24: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
        m.podStates.write(pod.ObjectMeta.Labels["name"], pod.ObjectMeta.Name, &podWrapper{pod: pod})
                              ^
src/operator/controllers/monitor.go:215:25: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
        m.podStates.delete(pod.ObjectMeta.Labels["name"], pod.ObjectMeta.Name)
                               ^
src/operator/controllers/monitor.go:418:7: QF1001: could apply De Morgan's law (staticcheck)
                        if !(ownerRef.Kind == "StatefulSet") {
                           ^
src/operator/controllers/monitor.go:455:13: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                        if p.pod.ObjectMeta.Labels["plane"] != "control" {
                                 ^
src/operator/controllers/monitor.go:675:2: QF1003: could use tagged switch on state.Reason (staticcheck)
        if state.Reason == status.NATSPodFailed {
        ^
src/pixie_cli/pkg/components/table_renderer.go:167:3: QF1012: Use fmt.Fprintf(...) instead of WriteString(fmt.Sprintf(...)) (staticcheck)
                buf.WriteString(fmt.Sprintf("%q:", fmt.Sprintf("%v", mi.Key)))
                ^
src/pixie_cli/pkg/components/table_renderer.go:331:14: QF1004: could use strings.ReplaceAll instead (staticcheck)
                        dataStr = strings.Replace(dataStr, "\"", "\"\"", -1)
                                  ^
src/shared/artifacts/manifest/manifest.go:51:28: ST1016: methods on the same type should have the same receiver name (seen 2x "m", 5x "a") (staticcheck)
func (a *ArtifactManifest) ArtifactSets() []*versionspb.ArtifactSet {
                           ^
src/shared/k8s/proto_utils_test.go:1017:35: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
        assert.Equal(t, "object_md", obj.ObjectMeta.Name)
                                         ^
src/shared/k8s/proto_utils_test.go:1319:33: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
        assert.Equal(t, "object_md", e.ObjectMeta.Name)
                                       ^
src/shared/k8s/proto_utils_test.go:1478:35: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
        assert.Equal(t, "object_md", obj.ObjectMeta.Name)
                                         ^
src/shared/services/election/election.go:58:56: ST1011: var expectedMaxSkewMS is of type time.Duration; don't use unit-specific suffix "MS" (staticcheck)
func NewK8sLeaderElectionMgr(electionNamespace string, expectedMaxSkewMS, renewDeadlineMS time.Duration, electionName string) (*K8sLeaderElectionMgr, error) {
                                                       ^
src/stirling/testing/demo_apps/go_http/go_http_client/main.go:73:3: QF1003: could use tagged switch on *reqType (staticcheck)
                if *reqType == "get" || *reqType == "mix" {
                ^
src/utils/artifacts/versions_gen/main.go:50:2: QF1002: could use tagged switch on artifactName (staticcheck)
        switch {
        ^
src/utils/dev_dns_updater/dev_dns_updater.go:128:18: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                svcName := svc.ObjectMeta.Name
                               ^
src/utils/dev_dns_updater/dev_dns_updater.go:142:19: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                                        SvcName: svc.ObjectMeta.Name,
                                                     ^
src/utils/dev_dns_updater/dev_dns_updater.go:153:20: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                                                SvcName: svc.ObjectMeta.Name,
                                                             ^
src/utils/shared/k8s/delete.go:380:45: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                err = svcs.Delete(context.Background(), s.ObjectMeta.Name, metav1.DeleteOptions{})
                                                          ^
src/utils/shared/k8s/delete.go:398:45: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                err = pods.Delete(context.Background(), s.ObjectMeta.Name, metav1.DeleteOptions{})
                                                          ^
src/vizier/services/cloud_connector/bridge/vzinfo.go:419:30: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                return unhealthyPEMPods[i].ObjectMeta.Name < unhealthyPEMPods[j].ObjectMeta.Name
                                           ^
src/vizier/services/cloud_connector/bridge/vzinfo.go:594:14: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                                if len(j.ObjectMeta.OwnerReferences) > 0 && j.ObjectMeta.OwnerReferences[0].Name == cronJob && j.Status.Succeeded == 1 {
                                         ^
src/vizier/services/cloud_connector/bridge/vzinfo.go:595:76: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                                        err = v.clientset.BatchV1().Jobs(v.ns).Delete(context.Background(), j.ObjectMeta.Name, metav1.DeleteOptions{
                                                                                                              ^
src/vizier/services/cloud_connector/vzmetrics/scrape.go:115:8: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                if p.ObjectMeta.Annotations[scrapeAnnotationName] != "true" {
                     ^
src/vizier/services/cloud_connector/vzmetrics/scrape.go:118:16: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                podName := p.ObjectMeta.Name
                             ^
src/vizier/services/cloud_connector/vzmetrics/scrape.go:119:17: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                port, ok := p.ObjectMeta.Annotations[portAnnotationName]
                              ^
src/vizier/services/metadata/controllers/k8smeta/k8s_metadata_handler_test.go:504:3: QF1003: could use tagged switch on prevUpdateVersion (staticcheck)
                if prevUpdateVersion == 3 {
                ^
src/vizier/services/metadata/controllers/k8smeta/k8s_metadata_handler_test.go:523:3: QF1003: could use tagged switch on prevUpdateVersion (staticcheck)
                if prevUpdateVersion == 3 {
                ^
src/vizier/services/metadata/controllers/k8smeta/k8s_metadata_store.go:141:3: QF1006: could lift into loop condition (staticcheck)
                if tIdx == len(tKeys) && uIdx == len(uKeys) {
                ^
src/vizier/services/metadata/controllers/server.go:260:8: QF1001: could apply De Morgan's law (staticcheck)
                        for !(finishedUpdates && finishedSchema) {
                            ^
50 issues:
* staticcheck: 50

```

</details>

---------

Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
ddelnano added 3 commits April 14, 2025 21:32
@ddelnano
Upgrade controller-gen to v0.17.2 to fix go generate panic issues
c52d06a 
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
@ddelnano
Run go generate after controller-gen upgrade
489d875 
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
@ddelnano
Recreate docker images after rebase that included golangci-lint changes
92310af 
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
@ddelnano ddelnano force-pushed the ddelnano/fix-controller-gen-generation branch from 9d994d8 to 92310af Compare April 14, 2025 21:50
@ddelnano ddelnano marked this pull request as ready for review April 14, 2025 21:55
@ddelnano ddelnano requested review from a team as code owners April 14, 2025 21:55
@ddelnano ddelnano merged commit e408814 into pixie-io:main Apr 15, 2025
25 checks passed
@ddelnano ddelnano deleted the ddelnano/fix-controller-gen-generation branch April 15, 2025 03:10
ddelnano added a commit to ddelnano/pixie that referenced this pull request Aug 6, 2025
@ddelnano @cosmic-copybara
Upgrade golangci-lint to v2 (pixie-io#2169)
2a1637d 
Summary: Upgrade golangci-lint to v2

This upgrades golangci-lint to v2 and remediates the golangci-lint
crashes seen in other PRs (pixie-io#2167). The vast majority of the new
violations have been resolved with the exception of some more stylistic
staticcheck cases.

Rather than ignoring these cases, they should be easy to handle if/when
the offending code is modified. The specific violations can be seen in
the Test plan below.

The pr-genfile-checker issues related to go generate will be fixed in
pixie-io#2167. I opted to split these changes into two PRs despite them both
needing to be available for a successful build.

Relevant Issues: N/A

Type of change: /kind dependency

Test Plan: Existing build and the following checks
- [x] `CGO_ENABLED=0 golangci-lint run` succeeds for the majority of
checks

<details><summary>command output</summary>

```
root@px-dev-docker-dev-vm:/px/src/px.dev/pixie# CGO_ENABLED=0 golangci-lint run
src/cloud/api/controllers/session_middleware.go:173:2: QF1007: could merge conditional assignment into variable declaration (staticcheck)
        forceBearer := false
        ^
src/cloud/artifact_tracker/controllers/server.go:176:5: QF1001: could apply De Morgan's law (staticcheck)
        if !(at == vpb.AT_DARWIN_AMD64 || at == vpb.AT_LINUX_AMD64 || at == vpb.AT_CONTAINER_SET_YAMLS || at == vpb.AT_CONTAINER_SET_TEMPLATE_YAMLS) {
           ^
src/cloud/autocomplete/suggester.go:176:5: QF1003: could use tagged switch on a.Type (staticcheck)
                                if a.Type == vispb.PX_POD {
                                ^
src/cloud/autocomplete/suggester.go:276:23: QF1001: could apply De Morgan's law (staticcheck)
                        if res.NS != "" && !(md.EsMDType(res.Kind) == md.EsMDTypeNamespace || md.EsMDType(res.Kind) == md.EsMDTypeNode) {
                                           ^
src/cloud/plugin/controllers/server.go:563:5: S1009: should omit nil check; len() for nil maps is defined as zero (staticcheck)
        if req.Configurations != nil && len(req.Configurations) > 0 {
           ^
src/cloud/profile/controllers/server.go:170:2: QF1003: could use tagged switch on err (staticcheck)
        if err == datastore.ErrOrgNotFound {
        ^
src/cloud/project_manager/datastore/datastore_test.go:27:2: ST1019: package "github.com/golang-migrate/migrate/source/go_bindata" is being imported more than once (staticcheck)
        _ "github.com/golang-migrate/migrate/source/go_bindata"
        ^
src/cloud/project_manager/datastore/datastore_test.go:28:2: ST1019(related information): other import of "github.com/golang-migrate/migrate/source/go_bindata" (staticcheck)
        bindata "github.com/golang-migrate/migrate/source/go_bindata"
        ^
src/cloud/shared/idprovider/client.go:535:6: QF1001: could apply De Morgan's law (staticcheck)
                if !(k == "Set-Cookie" || k == "Location") {
                   ^
src/cloud/shared/idprovider/client_test.go:96:44: ST1013: should use constant http.StatusFound instead of numeric literal 302 (staticcheck)
                http.Redirect(w, r, consentURL.String(), 302)
                                                         ^
src/common/testing/test_utils/cert_generator/cert_generator.go:120:2: QF1003: could use tagged switch on keyType (staticcheck)
        if keyType == "pkcs1" {
        ^
src/e2e_test/perf_tool/pkg/metrics/data_loss_handler.go:87:6: QF1009: probably want to use time.Time.Equal instead (staticcheck)
        if (ts == time.Time{}) {
            ^
src/e2e_test/perf_tool/pkg/metrics/prometheus_recorder.go:129:7: QF1001: could apply De Morgan's law (staticcheck)
                        if !(mf.GetType() == io_prometheus_client.MetricType_COUNTER || mf.GetType() == io_prometheus_client.MetricType_GAUGE) {
                           ^
src/e2e_test/perf_tool/pkg/suites/experiments.go:27:2: ST1019: package "px.dev/pixie/src/e2e_test/perf_tool/experimentpb" is being imported more than once (staticcheck)
        "px.dev/pixie/src/e2e_test/perf_tool/experimentpb"
        ^
src/e2e_test/perf_tool/pkg/suites/experiments.go:28:2: ST1019(related information): other import of "px.dev/pixie/src/e2e_test/perf_tool/experimentpb" (staticcheck)
        pb "px.dev/pixie/src/e2e_test/perf_tool/experimentpb"
        ^
src/e2e_test/vizier/exectime/cmd/benchmark.go:136:29: ST1016: methods on the same type should have the same receiver name (seen 1x "t", 4x "d") (staticcheck)
func (d *ErrorDistribution) Append(v interface{}) {
                            ^
src/e2e_test/vizier/exectime/cmd/benchmark.go:175:29: ST1016: methods on the same type should have the same receiver name (seen 1x "t", 5x "d") (staticcheck)
func (d *BytesDistribution) Append(v interface{}) {
                            ^
src/operator/controllers/monitor.go:49:2: ST1019: package "px.dev/pixie/src/operator/apis/px.dev/v1alpha1" is being imported more than once (staticcheck)
        "px.dev/pixie/src/operator/apis/px.dev/v1alpha1"
        ^
src/operator/controllers/monitor.go:50:2: ST1019(related information): other import of "px.dev/pixie/src/operator/apis/px.dev/v1alpha1" (staticcheck)
        pixiev1alpha1 "px.dev/pixie/src/operator/apis/px.dev/v1alpha1"
        ^
src/operator/controllers/monitor.go:194:24: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
        m.podStates.write(pod.ObjectMeta.Labels["name"], pod.ObjectMeta.Name, &podWrapper{pod: pod})
                              ^
src/operator/controllers/monitor.go:204:26: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                m.podStates.delete(pod.ObjectMeta.Labels["name"], pod.ObjectMeta.Name)
                                       ^
src/operator/controllers/monitor.go:207:24: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
        m.podStates.write(pod.ObjectMeta.Labels["name"], pod.ObjectMeta.Name, &podWrapper{pod: pod})
                              ^
src/operator/controllers/monitor.go:215:25: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
        m.podStates.delete(pod.ObjectMeta.Labels["name"], pod.ObjectMeta.Name)
                               ^
src/operator/controllers/monitor.go:418:7: QF1001: could apply De Morgan's law (staticcheck)
                        if !(ownerRef.Kind == "StatefulSet") {
                           ^
src/operator/controllers/monitor.go:455:13: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                        if p.pod.ObjectMeta.Labels["plane"] != "control" {
                                 ^
src/operator/controllers/monitor.go:675:2: QF1003: could use tagged switch on state.Reason (staticcheck)
        if state.Reason == status.NATSPodFailed {
        ^
src/pixie_cli/pkg/components/table_renderer.go:167:3: QF1012: Use fmt.Fprintf(...) instead of WriteString(fmt.Sprintf(...)) (staticcheck)
                buf.WriteString(fmt.Sprintf("%q:", fmt.Sprintf("%v", mi.Key)))
                ^
src/pixie_cli/pkg/components/table_renderer.go:331:14: QF1004: could use strings.ReplaceAll instead (staticcheck)
                        dataStr = strings.Replace(dataStr, "\"", "\"\"", -1)
                                  ^
src/shared/artifacts/manifest/manifest.go:51:28: ST1016: methods on the same type should have the same receiver name (seen 2x "m", 5x "a") (staticcheck)
func (a *ArtifactManifest) ArtifactSets() []*versionspb.ArtifactSet {
                           ^
src/shared/k8s/proto_utils_test.go:1017:35: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
        assert.Equal(t, "object_md", obj.ObjectMeta.Name)
                                         ^
src/shared/k8s/proto_utils_test.go:1319:33: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
        assert.Equal(t, "object_md", e.ObjectMeta.Name)
                                       ^
src/shared/k8s/proto_utils_test.go:1478:35: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
        assert.Equal(t, "object_md", obj.ObjectMeta.Name)
                                         ^
src/shared/services/election/election.go:58:56: ST1011: var expectedMaxSkewMS is of type time.Duration; don't use unit-specific suffix "MS" (staticcheck)
func NewK8sLeaderElectionMgr(electionNamespace string, expectedMaxSkewMS, renewDeadlineMS time.Duration, electionName string) (*K8sLeaderElectionMgr, error) {
                                                       ^
src/stirling/testing/demo_apps/go_http/go_http_client/main.go:73:3: QF1003: could use tagged switch on *reqType (staticcheck)
                if *reqType == "get" || *reqType == "mix" {
                ^
src/utils/artifacts/versions_gen/main.go:50:2: QF1002: could use tagged switch on artifactName (staticcheck)
        switch {
        ^
src/utils/dev_dns_updater/dev_dns_updater.go:128:18: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                svcName := svc.ObjectMeta.Name
                               ^
src/utils/dev_dns_updater/dev_dns_updater.go:142:19: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                                        SvcName: svc.ObjectMeta.Name,
                                                     ^
src/utils/dev_dns_updater/dev_dns_updater.go:153:20: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                                                SvcName: svc.ObjectMeta.Name,
                                                             ^
src/utils/shared/k8s/delete.go:380:45: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                err = svcs.Delete(context.Background(), s.ObjectMeta.Name, metav1.DeleteOptions{})
                                                          ^
src/utils/shared/k8s/delete.go:398:45: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                err = pods.Delete(context.Background(), s.ObjectMeta.Name, metav1.DeleteOptions{})
                                                          ^
src/vizier/services/cloud_connector/bridge/vzinfo.go:419:30: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                return unhealthyPEMPods[i].ObjectMeta.Name < unhealthyPEMPods[j].ObjectMeta.Name
                                           ^
src/vizier/services/cloud_connector/bridge/vzinfo.go:594:14: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                                if len(j.ObjectMeta.OwnerReferences) > 0 && j.ObjectMeta.OwnerReferences[0].Name == cronJob && j.Status.Succeeded == 1 {
                                         ^
src/vizier/services/cloud_connector/bridge/vzinfo.go:595:76: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                                        err = v.clientset.BatchV1().Jobs(v.ns).Delete(context.Background(), j.ObjectMeta.Name, metav1.DeleteOptions{
                                                                                                              ^
src/vizier/services/cloud_connector/vzmetrics/scrape.go:115:8: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                if p.ObjectMeta.Annotations[scrapeAnnotationName] != "true" {
                     ^
src/vizier/services/cloud_connector/vzmetrics/scrape.go:118:16: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                podName := p.ObjectMeta.Name
                             ^
src/vizier/services/cloud_connector/vzmetrics/scrape.go:119:17: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                port, ok := p.ObjectMeta.Annotations[portAnnotationName]
                              ^
src/vizier/services/metadata/controllers/k8smeta/k8s_metadata_handler_test.go:504:3: QF1003: could use tagged switch on prevUpdateVersion (staticcheck)
                if prevUpdateVersion == 3 {
                ^
src/vizier/services/metadata/controllers/k8smeta/k8s_metadata_handler_test.go:523:3: QF1003: could use tagged switch on prevUpdateVersion (staticcheck)
                if prevUpdateVersion == 3 {
                ^
src/vizier/services/metadata/controllers/k8smeta/k8s_metadata_store.go:141:3: QF1006: could lift into loop condition (staticcheck)
                if tIdx == len(tKeys) && uIdx == len(uKeys) {
                ^
src/vizier/services/metadata/controllers/server.go:260:8: QF1001: could apply De Morgan's law (staticcheck)
                        for !(finishedUpdates && finishedSchema) {
                            ^
50 issues:
* staticcheck: 50

```

</details>

---------

Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
GitOrigin-RevId: abe7238
ddelnano added a commit to ddelnano/pixie that referenced this pull request Aug 6, 2025
@ddelnano @cosmic-copybara
Upgrade controller-gen to address panics from go generate directive (p…
2945cab 
…ixie-io#2167)

Summary: Upgrade controller-gen to address panics from go generate
directive

Our go upgrade to 1.24 caused our controller-gen's `go generate`
directive to start failing. This is because the `trivialVersions`
setting of controller-gen was removed. From searching the controller-gen
issues, I believe Go 1.22 and later hits this problem for controller-gen
versions < v0.14
(kubernetes-sigs/controller-tools#888 (comment))

The `pr-genfiles` GitHub action that runs our go generates does not
trigger on `go.mod` or `go.sum` changes, so this was missed when Go was
upgraded.

I'm not too familiar with controller-gen and the generated file changes
are minor, but please let me know if this requires more extensive
testing. If there were larger CRD changes, I would expect that it would
require testing on different k8s versions with an operator release
build. I don't think this change warrants it, but please advise if you
feel differently.

Relevant Issues: N/A

Type of change: /kind bugfix

Test Plan: Inspected generated file changes
- [x] `px.dev_viziers.yaml`: Description changes are all whitespace
changes and appear equivalent
- [x] `px.dev_viziers.yaml`: CRD top level `status` field was removed. I
don't believe our operator code uses this nor did I see any reference
from k8s release notes on this deprecation
- [x] Removal of `// +build !ignore_autogenerated` -- this is an older
syntax from controller-gen's pre Go 1.17 usage

---------

Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
GitOrigin-RevId: e408814
ddelnano added a commit to k8sstormcenter/pixie that referenced this pull request Feb 25, 2026
@ddelnano
Upgrade golangci-lint to v2 (pixie-io#2169)
13269cb 
Summary: Upgrade golangci-lint to v2

This upgrades golangci-lint to v2 and remediates the golangci-lint
crashes seen in other PRs (pixie-io#2167). The vast majority of the new
violations have been resolved with the exception of some more stylistic
staticcheck cases.

Rather than ignoring these cases, they should be easy to handle if/when
the offending code is modified. The specific violations can be seen in
the Test plan below.

The pr-genfile-checker issues related to go generate will be fixed in
pixie-io#2167. I opted to split these changes into two PRs despite them both
needing to be available for a successful build.

Relevant Issues: N/A

Type of change: /kind dependency

Test Plan: Existing build and the following checks
- [x] `CGO_ENABLED=0 golangci-lint run` succeeds for the majority of
checks

<details><summary>command output</summary>

```
root@px-dev-docker-dev-vm:/px/src/px.dev/pixie# CGO_ENABLED=0 golangci-lint run
src/cloud/api/controllers/session_middleware.go:173:2: QF1007: could merge conditional assignment into variable declaration (staticcheck)
        forceBearer := false
        ^
src/cloud/artifact_tracker/controllers/server.go:176:5: QF1001: could apply De Morgan's law (staticcheck)
        if !(at == vpb.AT_DARWIN_AMD64 || at == vpb.AT_LINUX_AMD64 || at == vpb.AT_CONTAINER_SET_YAMLS || at == vpb.AT_CONTAINER_SET_TEMPLATE_YAMLS) {
           ^
src/cloud/autocomplete/suggester.go:176:5: QF1003: could use tagged switch on a.Type (staticcheck)
                                if a.Type == vispb.PX_POD {
                                ^
src/cloud/autocomplete/suggester.go:276:23: QF1001: could apply De Morgan's law (staticcheck)
                        if res.NS != "" && !(md.EsMDType(res.Kind) == md.EsMDTypeNamespace || md.EsMDType(res.Kind) == md.EsMDTypeNode) {
                                           ^
src/cloud/plugin/controllers/server.go:563:5: S1009: should omit nil check; len() for nil maps is defined as zero (staticcheck)
        if req.Configurations != nil && len(req.Configurations) > 0 {
           ^
src/cloud/profile/controllers/server.go:170:2: QF1003: could use tagged switch on err (staticcheck)
        if err == datastore.ErrOrgNotFound {
        ^
src/cloud/project_manager/datastore/datastore_test.go:27:2: ST1019: package "github.com/golang-migrate/migrate/source/go_bindata" is being imported more than once (staticcheck)
        _ "github.com/golang-migrate/migrate/source/go_bindata"
        ^
src/cloud/project_manager/datastore/datastore_test.go:28:2: ST1019(related information): other import of "github.com/golang-migrate/migrate/source/go_bindata" (staticcheck)
        bindata "github.com/golang-migrate/migrate/source/go_bindata"
        ^
src/cloud/shared/idprovider/client.go:535:6: QF1001: could apply De Morgan's law (staticcheck)
                if !(k == "Set-Cookie" || k == "Location") {
                   ^
src/cloud/shared/idprovider/client_test.go:96:44: ST1013: should use constant http.StatusFound instead of numeric literal 302 (staticcheck)
                http.Redirect(w, r, consentURL.String(), 302)
                                                         ^
src/common/testing/test_utils/cert_generator/cert_generator.go:120:2: QF1003: could use tagged switch on keyType (staticcheck)
        if keyType == "pkcs1" {
        ^
src/e2e_test/perf_tool/pkg/metrics/data_loss_handler.go:87:6: QF1009: probably want to use time.Time.Equal instead (staticcheck)
        if (ts == time.Time{}) {
            ^
src/e2e_test/perf_tool/pkg/metrics/prometheus_recorder.go:129:7: QF1001: could apply De Morgan's law (staticcheck)
                        if !(mf.GetType() == io_prometheus_client.MetricType_COUNTER || mf.GetType() == io_prometheus_client.MetricType_GAUGE) {
                           ^
src/e2e_test/perf_tool/pkg/suites/experiments.go:27:2: ST1019: package "px.dev/pixie/src/e2e_test/perf_tool/experimentpb" is being imported more than once (staticcheck)
        "px.dev/pixie/src/e2e_test/perf_tool/experimentpb"
        ^
src/e2e_test/perf_tool/pkg/suites/experiments.go:28:2: ST1019(related information): other import of "px.dev/pixie/src/e2e_test/perf_tool/experimentpb" (staticcheck)
        pb "px.dev/pixie/src/e2e_test/perf_tool/experimentpb"
        ^
src/e2e_test/vizier/exectime/cmd/benchmark.go:136:29: ST1016: methods on the same type should have the same receiver name (seen 1x "t", 4x "d") (staticcheck)
func (d *ErrorDistribution) Append(v interface{}) {
                            ^
src/e2e_test/vizier/exectime/cmd/benchmark.go:175:29: ST1016: methods on the same type should have the same receiver name (seen 1x "t", 5x "d") (staticcheck)
func (d *BytesDistribution) Append(v interface{}) {
                            ^
src/operator/controllers/monitor.go:49:2: ST1019: package "px.dev/pixie/src/operator/apis/px.dev/v1alpha1" is being imported more than once (staticcheck)
        "px.dev/pixie/src/operator/apis/px.dev/v1alpha1"
        ^
src/operator/controllers/monitor.go:50:2: ST1019(related information): other import of "px.dev/pixie/src/operator/apis/px.dev/v1alpha1" (staticcheck)
        pixiev1alpha1 "px.dev/pixie/src/operator/apis/px.dev/v1alpha1"
        ^
src/operator/controllers/monitor.go:194:24: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
        m.podStates.write(pod.ObjectMeta.Labels["name"], pod.ObjectMeta.Name, &podWrapper{pod: pod})
                              ^
src/operator/controllers/monitor.go:204:26: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                m.podStates.delete(pod.ObjectMeta.Labels["name"], pod.ObjectMeta.Name)
                                       ^
src/operator/controllers/monitor.go:207:24: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
        m.podStates.write(pod.ObjectMeta.Labels["name"], pod.ObjectMeta.Name, &podWrapper{pod: pod})
                              ^
src/operator/controllers/monitor.go:215:25: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
        m.podStates.delete(pod.ObjectMeta.Labels["name"], pod.ObjectMeta.Name)
                               ^
src/operator/controllers/monitor.go:418:7: QF1001: could apply De Morgan's law (staticcheck)
                        if !(ownerRef.Kind == "StatefulSet") {
                           ^
src/operator/controllers/monitor.go:455:13: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                        if p.pod.ObjectMeta.Labels["plane"] != "control" {
                                 ^
src/operator/controllers/monitor.go:675:2: QF1003: could use tagged switch on state.Reason (staticcheck)
        if state.Reason == status.NATSPodFailed {
        ^
src/pixie_cli/pkg/components/table_renderer.go:167:3: QF1012: Use fmt.Fprintf(...) instead of WriteString(fmt.Sprintf(...)) (staticcheck)
                buf.WriteString(fmt.Sprintf("%q:", fmt.Sprintf("%v", mi.Key)))
                ^
src/pixie_cli/pkg/components/table_renderer.go:331:14: QF1004: could use strings.ReplaceAll instead (staticcheck)
                        dataStr = strings.Replace(dataStr, "\"", "\"\"", -1)
                                  ^
src/shared/artifacts/manifest/manifest.go:51:28: ST1016: methods on the same type should have the same receiver name (seen 2x "m", 5x "a") (staticcheck)
func (a *ArtifactManifest) ArtifactSets() []*versionspb.ArtifactSet {
                           ^
src/shared/k8s/proto_utils_test.go:1017:35: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
        assert.Equal(t, "object_md", obj.ObjectMeta.Name)
                                         ^
src/shared/k8s/proto_utils_test.go:1319:33: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
        assert.Equal(t, "object_md", e.ObjectMeta.Name)
                                       ^
src/shared/k8s/proto_utils_test.go:1478:35: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
        assert.Equal(t, "object_md", obj.ObjectMeta.Name)
                                         ^
src/shared/services/election/election.go:58:56: ST1011: var expectedMaxSkewMS is of type time.Duration; don't use unit-specific suffix "MS" (staticcheck)
func NewK8sLeaderElectionMgr(electionNamespace string, expectedMaxSkewMS, renewDeadlineMS time.Duration, electionName string) (*K8sLeaderElectionMgr, error) {
                                                       ^
src/stirling/testing/demo_apps/go_http/go_http_client/main.go:73:3: QF1003: could use tagged switch on *reqType (staticcheck)
                if *reqType == "get" || *reqType == "mix" {
                ^
src/utils/artifacts/versions_gen/main.go:50:2: QF1002: could use tagged switch on artifactName (staticcheck)
        switch {
        ^
src/utils/dev_dns_updater/dev_dns_updater.go:128:18: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                svcName := svc.ObjectMeta.Name
                               ^
src/utils/dev_dns_updater/dev_dns_updater.go:142:19: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                                        SvcName: svc.ObjectMeta.Name,
                                                     ^
src/utils/dev_dns_updater/dev_dns_updater.go:153:20: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                                                SvcName: svc.ObjectMeta.Name,
                                                             ^
src/utils/shared/k8s/delete.go:380:45: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                err = svcs.Delete(context.Background(), s.ObjectMeta.Name, metav1.DeleteOptions{})
                                                          ^
src/utils/shared/k8s/delete.go:398:45: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                err = pods.Delete(context.Background(), s.ObjectMeta.Name, metav1.DeleteOptions{})
                                                          ^
src/vizier/services/cloud_connector/bridge/vzinfo.go:419:30: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                return unhealthyPEMPods[i].ObjectMeta.Name < unhealthyPEMPods[j].ObjectMeta.Name
                                           ^
src/vizier/services/cloud_connector/bridge/vzinfo.go:594:14: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                                if len(j.ObjectMeta.OwnerReferences) > 0 && j.ObjectMeta.OwnerReferences[0].Name == cronJob && j.Status.Succeeded == 1 {
                                         ^
src/vizier/services/cloud_connector/bridge/vzinfo.go:595:76: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                                        err = v.clientset.BatchV1().Jobs(v.ns).Delete(context.Background(), j.ObjectMeta.Name, metav1.DeleteOptions{
                                                                                                              ^
src/vizier/services/cloud_connector/vzmetrics/scrape.go:115:8: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                if p.ObjectMeta.Annotations[scrapeAnnotationName] != "true" {
                     ^
src/vizier/services/cloud_connector/vzmetrics/scrape.go:118:16: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                podName := p.ObjectMeta.Name
                             ^
src/vizier/services/cloud_connector/vzmetrics/scrape.go:119:17: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                port, ok := p.ObjectMeta.Annotations[portAnnotationName]
                              ^
src/vizier/services/metadata/controllers/k8smeta/k8s_metadata_handler_test.go:504:3: QF1003: could use tagged switch on prevUpdateVersion (staticcheck)
                if prevUpdateVersion == 3 {
                ^
src/vizier/services/metadata/controllers/k8smeta/k8s_metadata_handler_test.go:523:3: QF1003: could use tagged switch on prevUpdateVersion (staticcheck)
                if prevUpdateVersion == 3 {
                ^
src/vizier/services/metadata/controllers/k8smeta/k8s_metadata_store.go:141:3: QF1006: could lift into loop condition (staticcheck)
                if tIdx == len(tKeys) && uIdx == len(uKeys) {
                ^
src/vizier/services/metadata/controllers/server.go:260:8: QF1001: could apply De Morgan's law (staticcheck)
                        for !(finishedUpdates && finishedSchema) {
                            ^
50 issues:
* staticcheck: 50

```

</details>

---------

Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
ddelnano added a commit to k8sstormcenter/pixie that referenced this pull request Feb 25, 2026
@ddelnano
Upgrade controller-gen to address panics from go generate directive (p…
09530a6 
…ixie-io#2167)

Summary: Upgrade controller-gen to address panics from go generate
directive

Our go upgrade to 1.24 caused our controller-gen's `go generate`
directive to start failing. This is because the `trivialVersions`
setting of controller-gen was removed. From searching the controller-gen
issues, I believe Go 1.22 and later hits this problem for controller-gen
versions < v0.14
(kubernetes-sigs/controller-tools#888 (comment))

The `pr-genfiles` GitHub action that runs our go generates does not
trigger on `go.mod` or `go.sum` changes, so this was missed when Go was
upgraded.

I'm not too familiar with controller-gen and the generated file changes
are minor, but please let me know if this requires more extensive
testing. If there were larger CRD changes, I would expect that it would
require testing on different k8s versions with an operator release
build. I don't think this change warrants it, but please advise if you
feel differently.

Relevant Issues: N/A

Type of change: /kind bugfix

Test Plan: Inspected generated file changes
- [x] `px.dev_viziers.yaml`: Description changes are all whitespace
changes and appear equivalent
- [x] `px.dev_viziers.yaml`: CRD top level `status` field was removed. I
don't believe our operator code uses this nor did I see any reference
from k8s release notes on this deprecation
- [x] Removal of `// +build !ignore_autogenerated` -- this is an older
syntax from controller-gen's pre Go 1.17 usage

---------

Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
ddelnano added a commit to k8sstormcenter/pixie that referenced this pull request Feb 25, 2026
@ddelnano
Upgrade golangci-lint to v2 (pixie-io#2169)
2299132 
Summary: Upgrade golangci-lint to v2

This upgrades golangci-lint to v2 and remediates the golangci-lint
crashes seen in other PRs (pixie-io#2167). The vast majority of the new
violations have been resolved with the exception of some more stylistic
staticcheck cases.

Rather than ignoring these cases, they should be easy to handle if/when
the offending code is modified. The specific violations can be seen in
the Test plan below.

The pr-genfile-checker issues related to go generate will be fixed in
pixie-io#2167. I opted to split these changes into two PRs despite them both
needing to be available for a successful build.

Relevant Issues: N/A

Type of change: /kind dependency

Test Plan: Existing build and the following checks
- [x] `CGO_ENABLED=0 golangci-lint run` succeeds for the majority of
checks

<details><summary>command output</summary>

```
root@px-dev-docker-dev-vm:/px/src/px.dev/pixie# CGO_ENABLED=0 golangci-lint run
src/cloud/api/controllers/session_middleware.go:173:2: QF1007: could merge conditional assignment into variable declaration (staticcheck)
        forceBearer := false
        ^
src/cloud/artifact_tracker/controllers/server.go:176:5: QF1001: could apply De Morgan's law (staticcheck)
        if !(at == vpb.AT_DARWIN_AMD64 || at == vpb.AT_LINUX_AMD64 || at == vpb.AT_CONTAINER_SET_YAMLS || at == vpb.AT_CONTAINER_SET_TEMPLATE_YAMLS) {
           ^
src/cloud/autocomplete/suggester.go:176:5: QF1003: could use tagged switch on a.Type (staticcheck)
                                if a.Type == vispb.PX_POD {
                                ^
src/cloud/autocomplete/suggester.go:276:23: QF1001: could apply De Morgan's law (staticcheck)
                        if res.NS != "" && !(md.EsMDType(res.Kind) == md.EsMDTypeNamespace || md.EsMDType(res.Kind) == md.EsMDTypeNode) {
                                           ^
src/cloud/plugin/controllers/server.go:563:5: S1009: should omit nil check; len() for nil maps is defined as zero (staticcheck)
        if req.Configurations != nil && len(req.Configurations) > 0 {
           ^
src/cloud/profile/controllers/server.go:170:2: QF1003: could use tagged switch on err (staticcheck)
        if err == datastore.ErrOrgNotFound {
        ^
src/cloud/project_manager/datastore/datastore_test.go:27:2: ST1019: package "github.com/golang-migrate/migrate/source/go_bindata" is being imported more than once (staticcheck)
        _ "github.com/golang-migrate/migrate/source/go_bindata"
        ^
src/cloud/project_manager/datastore/datastore_test.go:28:2: ST1019(related information): other import of "github.com/golang-migrate/migrate/source/go_bindata" (staticcheck)
        bindata "github.com/golang-migrate/migrate/source/go_bindata"
        ^
src/cloud/shared/idprovider/client.go:535:6: QF1001: could apply De Morgan's law (staticcheck)
                if !(k == "Set-Cookie" || k == "Location") {
                   ^
src/cloud/shared/idprovider/client_test.go:96:44: ST1013: should use constant http.StatusFound instead of numeric literal 302 (staticcheck)
                http.Redirect(w, r, consentURL.String(), 302)
                                                         ^
src/common/testing/test_utils/cert_generator/cert_generator.go:120:2: QF1003: could use tagged switch on keyType (staticcheck)
        if keyType == "pkcs1" {
        ^
src/e2e_test/perf_tool/pkg/metrics/data_loss_handler.go:87:6: QF1009: probably want to use time.Time.Equal instead (staticcheck)
        if (ts == time.Time{}) {
            ^
src/e2e_test/perf_tool/pkg/metrics/prometheus_recorder.go:129:7: QF1001: could apply De Morgan's law (staticcheck)
                        if !(mf.GetType() == io_prometheus_client.MetricType_COUNTER || mf.GetType() == io_prometheus_client.MetricType_GAUGE) {
                           ^
src/e2e_test/perf_tool/pkg/suites/experiments.go:27:2: ST1019: package "px.dev/pixie/src/e2e_test/perf_tool/experimentpb" is being imported more than once (staticcheck)
        "px.dev/pixie/src/e2e_test/perf_tool/experimentpb"
        ^
src/e2e_test/perf_tool/pkg/suites/experiments.go:28:2: ST1019(related information): other import of "px.dev/pixie/src/e2e_test/perf_tool/experimentpb" (staticcheck)
        pb "px.dev/pixie/src/e2e_test/perf_tool/experimentpb"
        ^
src/e2e_test/vizier/exectime/cmd/benchmark.go:136:29: ST1016: methods on the same type should have the same receiver name (seen 1x "t", 4x "d") (staticcheck)
func (d *ErrorDistribution) Append(v interface{}) {
                            ^
src/e2e_test/vizier/exectime/cmd/benchmark.go:175:29: ST1016: methods on the same type should have the same receiver name (seen 1x "t", 5x "d") (staticcheck)
func (d *BytesDistribution) Append(v interface{}) {
                            ^
src/operator/controllers/monitor.go:49:2: ST1019: package "px.dev/pixie/src/operator/apis/px.dev/v1alpha1" is being imported more than once (staticcheck)
        "px.dev/pixie/src/operator/apis/px.dev/v1alpha1"
        ^
src/operator/controllers/monitor.go:50:2: ST1019(related information): other import of "px.dev/pixie/src/operator/apis/px.dev/v1alpha1" (staticcheck)
        pixiev1alpha1 "px.dev/pixie/src/operator/apis/px.dev/v1alpha1"
        ^
src/operator/controllers/monitor.go:194:24: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
        m.podStates.write(pod.ObjectMeta.Labels["name"], pod.ObjectMeta.Name, &podWrapper{pod: pod})
                              ^
src/operator/controllers/monitor.go:204:26: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                m.podStates.delete(pod.ObjectMeta.Labels["name"], pod.ObjectMeta.Name)
                                       ^
src/operator/controllers/monitor.go:207:24: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
        m.podStates.write(pod.ObjectMeta.Labels["name"], pod.ObjectMeta.Name, &podWrapper{pod: pod})
                              ^
src/operator/controllers/monitor.go:215:25: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
        m.podStates.delete(pod.ObjectMeta.Labels["name"], pod.ObjectMeta.Name)
                               ^
src/operator/controllers/monitor.go:418:7: QF1001: could apply De Morgan's law (staticcheck)
                        if !(ownerRef.Kind == "StatefulSet") {
                           ^
src/operator/controllers/monitor.go:455:13: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                        if p.pod.ObjectMeta.Labels["plane"] != "control" {
                                 ^
src/operator/controllers/monitor.go:675:2: QF1003: could use tagged switch on state.Reason (staticcheck)
        if state.Reason == status.NATSPodFailed {
        ^
src/pixie_cli/pkg/components/table_renderer.go:167:3: QF1012: Use fmt.Fprintf(...) instead of WriteString(fmt.Sprintf(...)) (staticcheck)
                buf.WriteString(fmt.Sprintf("%q:", fmt.Sprintf("%v", mi.Key)))
                ^
src/pixie_cli/pkg/components/table_renderer.go:331:14: QF1004: could use strings.ReplaceAll instead (staticcheck)
                        dataStr = strings.Replace(dataStr, "\"", "\"\"", -1)
                                  ^
src/shared/artifacts/manifest/manifest.go:51:28: ST1016: methods on the same type should have the same receiver name (seen 2x "m", 5x "a") (staticcheck)
func (a *ArtifactManifest) ArtifactSets() []*versionspb.ArtifactSet {
                           ^
src/shared/k8s/proto_utils_test.go:1017:35: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
        assert.Equal(t, "object_md", obj.ObjectMeta.Name)
                                         ^
src/shared/k8s/proto_utils_test.go:1319:33: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
        assert.Equal(t, "object_md", e.ObjectMeta.Name)
                                       ^
src/shared/k8s/proto_utils_test.go:1478:35: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
        assert.Equal(t, "object_md", obj.ObjectMeta.Name)
                                         ^
src/shared/services/election/election.go:58:56: ST1011: var expectedMaxSkewMS is of type time.Duration; don't use unit-specific suffix "MS" (staticcheck)
func NewK8sLeaderElectionMgr(electionNamespace string, expectedMaxSkewMS, renewDeadlineMS time.Duration, electionName string) (*K8sLeaderElectionMgr, error) {
                                                       ^
src/stirling/testing/demo_apps/go_http/go_http_client/main.go:73:3: QF1003: could use tagged switch on *reqType (staticcheck)
                if *reqType == "get" || *reqType == "mix" {
                ^
src/utils/artifacts/versions_gen/main.go:50:2: QF1002: could use tagged switch on artifactName (staticcheck)
        switch {
        ^
src/utils/dev_dns_updater/dev_dns_updater.go:128:18: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                svcName := svc.ObjectMeta.Name
                               ^
src/utils/dev_dns_updater/dev_dns_updater.go:142:19: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                                        SvcName: svc.ObjectMeta.Name,
                                                     ^
src/utils/dev_dns_updater/dev_dns_updater.go:153:20: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                                                SvcName: svc.ObjectMeta.Name,
                                                             ^
src/utils/shared/k8s/delete.go:380:45: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                err = svcs.Delete(context.Background(), s.ObjectMeta.Name, metav1.DeleteOptions{})
                                                          ^
src/utils/shared/k8s/delete.go:398:45: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                err = pods.Delete(context.Background(), s.ObjectMeta.Name, metav1.DeleteOptions{})
                                                          ^
src/vizier/services/cloud_connector/bridge/vzinfo.go:419:30: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                return unhealthyPEMPods[i].ObjectMeta.Name < unhealthyPEMPods[j].ObjectMeta.Name
                                           ^
src/vizier/services/cloud_connector/bridge/vzinfo.go:594:14: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                                if len(j.ObjectMeta.OwnerReferences) > 0 && j.ObjectMeta.OwnerReferences[0].Name == cronJob && j.Status.Succeeded == 1 {
                                         ^
src/vizier/services/cloud_connector/bridge/vzinfo.go:595:76: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                                        err = v.clientset.BatchV1().Jobs(v.ns).Delete(context.Background(), j.ObjectMeta.Name, metav1.DeleteOptions{
                                                                                                              ^
src/vizier/services/cloud_connector/vzmetrics/scrape.go:115:8: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                if p.ObjectMeta.Annotations[scrapeAnnotationName] != "true" {
                     ^
src/vizier/services/cloud_connector/vzmetrics/scrape.go:118:16: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                podName := p.ObjectMeta.Name
                             ^
src/vizier/services/cloud_connector/vzmetrics/scrape.go:119:17: QF1008: could remove embedded field "ObjectMeta" from selector (staticcheck)
                port, ok := p.ObjectMeta.Annotations[portAnnotationName]
                              ^
src/vizier/services/metadata/controllers/k8smeta/k8s_metadata_handler_test.go:504:3: QF1003: could use tagged switch on prevUpdateVersion (staticcheck)
                if prevUpdateVersion == 3 {
                ^
src/vizier/services/metadata/controllers/k8smeta/k8s_metadata_handler_test.go:523:3: QF1003: could use tagged switch on prevUpdateVersion (staticcheck)
                if prevUpdateVersion == 3 {
                ^
src/vizier/services/metadata/controllers/k8smeta/k8s_metadata_store.go:141:3: QF1006: could lift into loop condition (staticcheck)
                if tIdx == len(tKeys) && uIdx == len(uKeys) {
                ^
src/vizier/services/metadata/controllers/server.go:260:8: QF1001: could apply De Morgan's law (staticcheck)
                        for !(finishedUpdates && finishedSchema) {
                            ^
50 issues:
* staticcheck: 50

```

</details>

---------

Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
ddelnano added a commit to k8sstormcenter/pixie that referenced this pull request Feb 25, 2026
@ddelnano
Upgrade controller-gen to address panics from go generate directive (p…
274387e 
…ixie-io#2167)

Summary: Upgrade controller-gen to address panics from go generate
directive

Our go upgrade to 1.24 caused our controller-gen's `go generate`
directive to start failing. This is because the `trivialVersions`
setting of controller-gen was removed. From searching the controller-gen
issues, I believe Go 1.22 and later hits this problem for controller-gen
versions < v0.14
(kubernetes-sigs/controller-tools#888 (comment))

The `pr-genfiles` GitHub action that runs our go generates does not
trigger on `go.mod` or `go.sum` changes, so this was missed when Go was
upgraded.

I'm not too familiar with controller-gen and the generated file changes
are minor, but please let me know if this requires more extensive
testing. If there were larger CRD changes, I would expect that it would
require testing on different k8s versions with an operator release
build. I don't think this change warrants it, but please advise if you
feel differently.

Relevant Issues: N/A

Type of change: /kind bugfix

Test Plan: Inspected generated file changes
- [x] `px.dev_viziers.yaml`: Description changes are all whitespace
changes and appear equivalent
- [x] `px.dev_viziers.yaml`: CRD top level `status` field was removed. I
don't believe our operator code uses this nor did I see any reference
from k8s release notes on this deprecation
- [x] Removal of `// +build !ignore_autogenerated` -- this is an older
syntax from controller-gen's pre Go 1.17 usage

---------

Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vihangm vihangm vihangm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ddelnano @vihangm