Conversation
Signed-off-by: Vihang Mehta <vihang@gimletlabs.ai>
Contributor
|
I was preparing a PR for that, thanks for taking care of it! |
ddelnano
reviewed
Apr 21, 2025
ddelnano
approved these changes
Apr 21, 2025
JamesMBartlett
approved these changes
Apr 21, 2025
JamesMBartlett
approved these changes
Apr 21, 2025
ddelnano
pushed a commit
to ddelnano/pixie
that referenced
this pull request
Aug 6, 2025
Summary: There were two issues on main related to codeql. This attempts to address both of them. 1) since go 1.21, the go.mod file is expected to have a version of the form v1.X.Y instead of v1.X codeql warns about this, so this fixes the same. 2) given the recent change in GH action runners, the runners don't seem to have nodejs installed by default, this ensures that nodejs is indeed installed. Relevant Issues: N/A Type of change: /kind bug Test Plan: Tested e2e. Signed-off-by: Vihang Mehta <vihang@px.dev> GitOrigin-RevId: 2711c9f
ddelnano
pushed a commit
to k8sstormcenter/pixie
that referenced
this pull request
Feb 25, 2026
Summary: There were two issues on main related to codeql. This attempts to address both of them. 1) since go 1.21, the go.mod file is expected to have a version of the form v1.X.Y instead of v1.X codeql warns about this, so this fixes the same. 2) given the recent change in GH action runners, the runners don't seem to have nodejs installed by default, this ensures that nodejs is indeed installed. Relevant Issues: N/A Type of change: /kind bug Test Plan: Tested e2e. Signed-off-by: Vihang Mehta <vihang@px.dev>
ddelnano
pushed a commit
to k8sstormcenter/pixie
that referenced
this pull request
Feb 25, 2026
Summary: There were two issues on main related to codeql. This attempts to address both of them. 1) since go 1.21, the go.mod file is expected to have a version of the form v1.X.Y instead of v1.X codeql warns about this, so this fixes the same. 2) given the recent change in GH action runners, the runners don't seem to have nodejs installed by default, this ensures that nodejs is indeed installed. Relevant Issues: N/A Type of change: /kind bug Test Plan: Tested e2e. Signed-off-by: Vihang Mehta <vihang@px.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: There were two issues on main related to codeql. This attempts to address both of them.
Relevant Issues: N/A
Type of change: /kind bug
Test Plan: Tested e2e.