Add cross window support#647
Open
EliasWatson wants to merge 2 commits intopixijs:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #646
I added an e2e test that fails before the fix was made and passes after the fix. I have also tested this in my enterprise app and confirmed pop-out windows work.
#621 was a lot messier of a fix because I thought that we needed to handle all
instanceofchecks, even for internal classes. But that's not the case. When using a React portal to render into another window, all the code runs in the main window, soinstanceofworks fine. The issue arises when you get an HTML element or event from the other window. Those objects were created in the other window so comparing them to classes in the main window will fail.