Don't translate StatusPacket to os.Err(NotExist|Permission)

greatroar · greatroar · commit 63dbfdfd1922 · 2025-05-31T14:22:06.000+02:00
Doing this loses potentially useful information for the client. They
should instead check with errors.Is(err, fs.ErrNotExist), etc.; the
StatusPacket type has an Is method for this already.
diff --git a/client.go b/client.go
@@ -490,10 +490,6 @@ func statusToError(status *sshfx.StatusPacket, okExpected bool) error {
 
 	case sshfx.StatusEOF:
 		return io.EOF
-	case sshfx.StatusNoSuchFile:
-		return fs.ErrNotExist
-	case sshfx.StatusPermissionDenied:
-		return fs.ErrPermission
 	}
 
 	return status

Original file line number	Diff line number	Diff line change
`@@ -490,10 +490,6 @@ func statusToError(status *sshfx.StatusPacket, okExpected bool) error {`
`490`	`490`
`491`	`491`	`case sshfx.StatusEOF:`
`492`	`492`	`return io.EOF`
`493`		`- case sshfx.StatusNoSuchFile:`
`494`		`- return fs.ErrNotExist`
`495`		`- case sshfx.StatusPermissionDenied:`
`496`		`- return fs.ErrPermission`
`497`	`493`	`}`
`498`	`494`
`499`	`495`	`return status`