harden client reply parsers against malformed server replies#655
Open
drakkan wants to merge 1 commit into
Open
harden client reply parsers against malformed server replies#655drakkan wants to merge 1 commit into
drakkan wants to merge 1 commit into
Conversation
The client response decoders parsed server replies with the unchecked unmarshalUint32/unmarshalString helpers and with fixed-offset reads in unmarshalStatus. A malicious or compromised server could return a truncated or oversized reply and panic the client goroutine with an index- or slice-bounds-out-of-range. Convert these paths to the bounds-checked Safe variants and clamp the data-length before slicing, so a hostile reply returns an error instead of panicking. Reported by @mjbommar
puellanivis
reviewed
Jul 13, 2026
| } | ||
| count, data := unmarshalUint32(data) | ||
| for i := uint32(0); i < count; i++ { | ||
| for i := 0; i < count; i++ { |
Collaborator
There was a problem hiding this comment.
We can switch this to range i since we’re here.
Comment on lines
+205
to
+207
| if len(body) >= 5 { | ||
| id, _ = unmarshalUint32(body[1:]) | ||
| } |
Collaborator
There was a problem hiding this comment.
I think if this is false, then this would be an error… at least a ok == false situation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client response decoders parsed server replies with the unchecked unmarshalUint32/unmarshalString helpers and with fixed-offset reads in unmarshalStatus. A malicious or compromised server could return a truncated or oversized reply and panic the client goroutine with an index- or slice-bounds-out-of-range. Convert these paths to the bounds-checked Safe variants and clamp the data-length before slicing, so a hostile reply returns an error instead of panicking.
Reported by @mjbommar