Fix creating tmp files on different volumes (#10)

Author: mxcl

src/hooks/useCellar.ts

@@ -75,7 +75,7 @@ export default function useCellar() {
       throw new Error(`not-found:${pkgutils.str(pkg)}`)
     })()
     if (await vacant(installation.path)) {
-      throw new Error(`not-found:${pkgutils.str(installation.pkg)}`)
+      throw new Error(`not-found: ${pkgutils.str(installation.pkg)}`)
     }
     return installation
   }

src/prefab/install.ts

@@ -44,8 +44,7 @@ export default async function install(pkg: Package, logger?: Logger): Promise<In
   const { project, version } = pkg
 
   const cellar = useCellar()
-  const { prefix: tea_prefix } = useConfig()
-  const { compression } = useConfig().options
+  const { prefix: tea_prefix, options: { compression } } = useConfig()
   const stowage = StowageNativeBottle({ pkg: { project, version }, compression })
   const url = useOffLicense('s3').url(stowage)
   const tarball = useCache().path(stowage)
@@ -67,8 +66,8 @@ export default async function install(pkg: Package, logger?: Logger): Promise<In
     logger?.downloading({pkg})
 
     const tmpdir = Path.mktemp({
-      prefix: pkg.project.replaceAll("/", "_") + "_",
-      dir: tea_prefix.join("local/tmp")
+      dir: tea_prefix.join("local/tmp").join(pkg.project),
+      prefix: `v${pkg.version}.`
       //NOTE ^^ inside tea prefix to avoid TMPDIR is on a different volume problems
     })
     const tar_args = compression == 'xz' ? 'xJ' : 'xz'  // laughably confusing

src/utils/Path.ts

@@ -3,6 +3,8 @@ import { readLines } from "deno/io/read_lines.ts"
 import * as sys from "deno/path/mod.ts"
 import { PlainObject } from "is-what"
 import * as fs from "deno/fs/mod.ts"
+import { mkdtempSync } from "node:fs"
+import * as os from "node:os"
 
 // based on https://github.com/mxcl/Path.swift
 
@@ -208,8 +210,12 @@ export default class Path {
   }
 
   static mktemp(opts?: { prefix?: string, dir?: Path }): Path {
-    const {prefix, dir} = opts ?? {}
-    const rv = Deno.makeTempDirSync({prefix, dir: dir?.mkdir('p').string})
+    let {prefix, dir} = opts ?? {}
+    dir ??= new Path(os.tmpdir())
+    prefix ??= ""
+    if (!prefix.startsWith('/')) prefix = `/${prefix}`
+    // not using deno.makeTempDirSync because it's bugg’d and the node shim doesn’t handler `dir`
+    const rv = mkdtempSync(`${dir.mkdir('p')}${prefix}`)
     return new Path(rv)
   }
 

src/utils/semver.ts

@@ -84,10 +84,18 @@ export default class SemVer {
     return this.compare(that) > 0
   }
 
+  gte(that: SemVer): boolean {
+    return this.compare(that) >= 0
+  }
+
   lt(that: SemVer): boolean {
     return this.compare(that) < 0
   }
 
+  lte(that: SemVer): boolean {
+    return this.compare(that) <= 0
+  }
+
   compare(that: SemVer): number {
     return _compare(this, that)
   }