Fix the deno permissions for tests

Author: mxcl

deno.json

@@ -12,7 +12,7 @@
   },
   "pkgx": "deno^1.33.3 npm",
   "tasks": {
-    "test": "deno test --parallel --unstable -A",
+    "test": "deno test --parallel --unstable --allow-env --allow-read --allow-net=dist.pkgx.dev,github.com,codeload.github.com --allow-write --allow-run=tar,uname,/bin/sh,foo,'C:\\Windows\\system32\\cmd.exe'",
     "typecheck": "deno check --unstable ./mod.ts",
     "dnt": ".github/deno-to-node.ts"
   },

src/hooks/useConfig.ts

@@ -19,27 +19,26 @@ export interface Config {
   git?: Path
 }
 
-function platform_cache_default(home: Path) {
+function platform_cache_default(home: Path, { LOCALAPPDATA }: { LOCALAPPDATA?: string }) {
   switch (Deno.build.os) {
   case 'darwin':
     return home.join('Library/Caches')
   case 'windows':
-    return flatmap(Deno.env.get("LOCALAPPDATA"), Path.abs) ?? home.join('AppData/Local')
+    return flatmap(LOCALAPPDATA, Path.abs) ?? home.join('AppData/Local')
   default:
     return home.join('.cache')
   }
 }
 
-function platform_data_home_default(home: Path) {
+function platform_data_home_default(home: Path, { LOCALAPPDATA }: { LOCALAPPDATA?: string }) {
   switch (host().platform) {
   case 'darwin':
     return home.join("Library/Application Support")
   case 'windows': {
-    const LOCALAPPDATA = Deno.env.get('LOCALAPPDATA')
     if (LOCALAPPDATA) {
-      return new Path(LOCALAPPDATA).join("pkgx")
+      return new Path(LOCALAPPDATA)
     } else {
-      return home.join("AppData/Local/pkgx")
+      return home.join("AppData/Local")
     }}
   default:
     return home.join(".local/share")
@@ -52,8 +51,8 @@ export function ConfigDefault(env = Deno.env.toObject()): Config {
   const home = flatmap(env['PKGX_HOME'], x => new Path(x)) ?? Path.home()
   const prefix = flatmap(env['PKGX_DIR']?.trim(), x => new Path(x)) ?? home.join('.pkgx')
   const pantries = env['PKGX_PANTRY_PATH']?.split(SEP).compact(x => flatmap(x.trim(), x => Path.abs(x) ?? Path.cwd().join(x))) ?? []
-  const cache = (flatmap(env["XDG_CACHE_HOME"], Path.abs) ?? platform_cache_default(home)).join("pkgx")
-  const data = (flatmap(env["XDG_DATA_HOME"], Path.abs) ?? platform_data_home_default(home)).join("pkgx")
+  const cache = (flatmap(env["XDG_CACHE_HOME"], Path.abs) ?? platform_cache_default(home, env)).join("pkgx")
+  const data = (flatmap(env["XDG_DATA_HOME"], Path.abs) ?? platform_data_home_default(home, env)).join("pkgx")
   const isCI = boolize(env['CI']) ?? false
   const UserAgent = flatmap(getv(), v => `libpkgx/${v}`) ?? 'libpkgx'
   //TODO prefer 'xz' on Linux (as well) if supported

src/hooks/useTestConfig.ts

@@ -6,10 +6,7 @@ export function useBaseTestConfig(env?: Record<string, string>) {
   env ??= {}
 
   /// always prefer a new prefix
-  env.HOME ??= Path.mktemp().string
-  env.PKGX_DIR ??= Path.mktemp().string
-  env.XDG_DATA_HOME ??= Path.mktemp().string
-  env.XDG_CACHE_HOME ??= Path.mktemp().string
+  env.PKGX_HOME ??= Path.mktemp().string
 
   const config = ConfigDefault(env)
   if ('UserAgent' in env) {

src/plumbing/resolve.test.ts

@@ -11,7 +11,7 @@ import SemVer from "../utils/semver.ts"
 import Path from "../utils/Path.ts"
 
 Deno.test("resolve cellar.has", {
-  permissions: {'read': true, 'env': ["TMPDIR", "TMP", "TEMP", "HOME"], 'write': [Deno.env.get("TMPDIR") || Deno.env.get("TMP") || Deno.env.get("TEMP") || "/tmp"] }
+  permissions: {'read': true, 'env': ["TMPDIR", "TMP", "TEMP"], 'write': [Deno.env.get("TMPDIR") || Deno.env.get("TMP") || Deno.env.get("TEMP") || "/tmp"] }
 }, async runner => {
   const prefix = useTestConfig().prefix
   const pkg = { project: "foo", version: new SemVer("1.0.0") }