Add test to verify we fixed libtea useConfig use

Wild bug where separate instances of libtea were loaded that thus did not share config. Fixed in libtea 0.1.5, but theses tests fail before 0.1.5 and now pass.

Author: mxcl

README.md

@@ -16,7 +16,7 @@
 </p>
 
 
-# tea/cli 0.33.1
+# tea/cli 0.33.2
 
 `tea` puts the whole open source ecosystem at your fingertips:
 

tests/integration.suite.ts

@@ -16,7 +16,7 @@ type RunOptions = ({
 } | {
   cmd: string[]
 }) & {
-  env?: Record<string, string>
+  env?: Record<string, string | null>
   throws?: boolean
 }
 
@@ -35,6 +35,8 @@ const suite = describe({
     const tmp = new Path(await Deno.makeTempDir({ prefix: "tea-" }))
     const cwd = new Path(new URL(import.meta.url).pathname).parent().parent()
 
+    assert(cwd.join("deno.jsonc").isFile())
+
     //TODO use deno task compile, however seems to be a bug where we cannot control the output location
     const proc = Deno.run({
       cmd: [
@@ -71,7 +73,7 @@ const suite = describe({
 
   async beforeEach(this: This) {
     const tmp = new Path(await Deno.makeTempDir({ prefix: "tea-" }))
-    const TEA_PREFIX = existing_tea_prefix ?? tmp.join('opt').mkdir()
+    const TEA_PREFIX = tmp.join('opt').mkdir()
 
     this.TEA_PREFIX = TEA_PREFIX
     assert(this.TEA_PREFIX.isDirectory())
@@ -87,10 +89,15 @@ const suite = describe({
         if (value) env[key] = value
       }
       env['PATH'] = `${this.tea.parent()}:/usr/bin:/bin`  // these systems are full of junk so we prune PATH
-      env['TEA_PREFIX'] ??= TEA_PREFIX.string
+      if (env['TEA_PREFIX'] === undefined) env['TEA_PREFIX'] = TEA_PREFIX.string
+      if (env['TEA_PANTRY_PATH'] === undefined) env['TEA_PANTRY_PATH'] = this.TEA_PANTRY_PATH.string
+      if (env['TEA_CACHE_DIR'] === undefined) env['TEA_CACHE_DIR'] = this.TEA_CACHE_DIR.string
+
       env['CLICOLOR_FORCE'] = '0'
-      env['TEA_PANTRY_PATH'] ??= this.TEA_PANTRY_PATH.string
-      env['TEA_CACHE_DIR'] ??= this.TEA_CACHE_DIR.string
+
+      for (const [key, value] of Object.entries(env)) {
+        if (value === null) delete env[key]
+      }
 
       let stdout: "piped" | undefined
       let stderr: "piped" | undefined
@@ -106,7 +113,7 @@ const suite = describe({
           cmd.unshift(this.tea.string)
         }
 
-        const proc = Deno.run({ cmd, cwd: sandbox.string, stdout, stderr, env, clearEnv: true})
+        const proc = Deno.run({ cmd, cwd: sandbox.string, stdout, stderr, env: env as any, clearEnv: true})
         try {
           const status = await proc.status()
           if ((throws === undefined || throws) && !status.success) {

tests/integration/cli.test.ts

@@ -1,6 +1,7 @@
-import { assert, assertEquals, assertMatch } from "deno/testing/asserts.ts"
+import { assert, assertEquals, assertMatch, assertRejects } from "deno/testing/asserts.ts"
 import suite from "../integration.suite.ts"
 import { it } from "deno/testing/bdd.ts"
+import undent from "outdent"
 
 it(suite, "tea --help", async function() {
   const out = await this.run({args: ["--help"]}).stdout()
@@ -44,3 +45,23 @@ it(suite, "tea http-server --help (via npx provider)", async function() {
 it(suite, "tea pkg --version", async function() {
   await this.run({ args: ["pkg", "--version"] })
 })
+
+it(suite, "tea determines its own prefix and pantry works", async function() {
+  // this verifies that useConfig() works as expected even though seemingly
+  // deno loads separate copies of libtea for each of the import map methods we use
+  // history: there was a bug where libtea internally had a different config object than tea/cli
+  // testing the pantry works properly verifies that this is no longer the case
+
+  this.tea = this.tea.mv({ into: this.TEA_PREFIX.join("tea.xyz/v0.33.2/bin").mkdir('p') })
+
+  this.TEA_PREFIX
+    .join("tea.xyz/var/pantry/projects/foo.com").mkdir('p')
+    .join("package.yml").write({ text: undent`
+      provides: [bin/foo]
+      `})
+
+  const stdout = await this.run({ args: ["--prefix"], env: { TEA_PREFIX: null, TEA_PANTRY_PATH: null } }).stdout()
+  assertEquals(stdout.trim(), this.TEA_PREFIX.string)
+
+  await this.run({ args: ["--provides", "foo"], env: { TEA_PREFIX: null, TEA_PANTRY_PATH: null } })
+})

tests/unit/useConfig.test.ts

@@ -1,7 +1,8 @@
 import useConfig, { ConfigDefault } from "../../src/hooks/useConfig.ts"
 import { assertEquals } from "deno/testing/asserts.ts"
 import { _internals } from "tea/hooks/useConfig.ts"
-import { Path } from "tea"
+import { Path, hooks } from "tea"
+const { usePantry } = hooks
 
 Deno.test("prefix discovery", async () => {
   const tmp = new Path(await Deno.makeTempDir())
@@ -37,3 +38,18 @@ Deno.test("prefix discovery defaults to ~/.tea", async () => {
   const config = ConfigDefault(undefined, tea.string, {})
   assertEquals(config.prefix, Path.home().join(".tea"))
 })
+
+Deno.test("useConfig global state is shared across import styles", async () => {
+  // testing for a bug where imports of `"tea"` and `"tea/hooks/useConfig.ts"` would
+  // load their own copies of the global config object
+
+  const tmp = new Path(await Deno.makeTempDir())
+  const tea = tmp.join('tea.xyz/v0.33.2/bin').mkdir('p').join('tea').touch()
+
+  _internals.reset()
+  const defaults = ConfigDefault(undefined, tea.string, {})
+  const config = useConfig(defaults)
+
+  assertEquals(config.prefix, tmp)
+  assertEquals(usePantry().prefix, tmp.join("tea.xyz/var/pantry/projects"))
+})