fix lints

Author: jhheider

crates/lib/src/client.rs

@@ -29,8 +29,8 @@ fn get_user_agent() -> String {
     let os = std::env::consts::OS;
     let arch = std::env::consts::ARCH;
     let group = env::var("PKGX_USER_AGENT_GROUP");
-    let name = if group.is_ok() {
-        format!("pkgx[{}]", group.unwrap())
+    let name = if let Ok(valid_group) = group {
+        format!("pkgx[{}]", valid_group)
     } else {
         "pkgx".to_string()
     };

crates/lib/src/install.rs

@@ -98,9 +98,7 @@ where
         }
     });
 
-    let stream = stream
-        .map_err(|e| futures::io::Error::new(futures::io::ErrorKind::Other, e))
-        .into_async_read();
+    let stream = stream.map_err(futures::io::Error::other).into_async_read();
     let stream = stream.compat();
 
     // Step 2: Create a XZ decoder
@@ -169,8 +167,7 @@ async fn symlink(installation: &Installation, config: &Config) -> Result<(), Box
     };
     let most_minor = versions
         .iter()
-        .filter(|(version, _)| minor_range.satisfies(version))
-        .next_back()
+        .rfind(|(version, _)| minor_range.satisfies(version))
         .ok_or_else(|| {
             anyhow::anyhow!(
                 "Could not find most minor version for {}",
@@ -189,8 +186,7 @@ async fn symlink(installation: &Installation, config: &Config) -> Result<(), Box
 
     let most_major = versions
         .iter()
-        .filter(|(version, _)| major_range.satisfies(version))
-        .next_back()
+        .rfind(|(version, _)| major_range.satisfies(version))
         .ok_or_else(|| anyhow::anyhow!("Could not find most major version"))?;
 
     if most_major.0 != installation.pkg.version {

crates/lib/src/sync.rs

@@ -58,9 +58,7 @@ async fn download_and_extract_pantry(url: &str, dest: &PathBuf) -> Result<(), Bo
 
     let stream = rsp.bytes_stream();
 
-    let stream = stream
-        .map_err(|e| futures::io::Error::new(futures::io::ErrorKind::Other, e))
-        .into_async_read();
+    let stream = stream.map_err(futures::io::Error::other).into_async_read();
     let stream = stream.compat();
 
     let decoder = XzDecoder::new(stream);