Align Java compile options#4553
Merged
AuroraLS3 merged 5 commits intoplan-player-analytics:masterfrom Apr 8, 2026
Merged
Conversation
AuroraLS3
approved these changes
Apr 7, 2026
Collaborator
AuroraLS3
left a comment
There was a problem hiding this comment.
Thank you :)
I tested following versions
- ✔ Java 25 Paper 1.21.8
- ✔ Java 25 Bungeecord (latest)
- ✔ Java 25 Velocity 3.5.0-SNAPSHOT
- ✔ Java 21 Sponge 13
- ✖ Java 25 Sponge 13 (Did not function - which is expected)
- ✔ Java 25 Folia 1.20.4
- ✔ Java 11 nukkit
I assume you have tested following versions, please let me know if you have not.
- Java 11 Paper 1.12.2
- Java 25 Fabric
Collaborator
|
Sorry I meant Java 11 Paper 1.13.2 |
Collaborator
|
You might also want to edit Contributors.java |
Contributor
Author
Yeah, I just realized I tried on 1.12.2 with Java 11 and it worked so I'm assuming 1.13.2 also works xD |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
🚨 Please review the guidelines for contributing to this repository.
/Plan/common/src/main/java/com/djrapitops/plan/delivery/rendering/html/Contributors.java/Plan/common/src/main/java/com/djrapitops/plan/settings/locale/LangCode.javaDescription
Aligns Java compile options so that application code is compiled to a desired release version, while all other tasks (e.g. tests) can use the latest version. This now makes it possible to write tests with Java 25, while keeping application code per module at a specified release version. Shadowed module dependencies (apart from Adventure module) for the plugin module aren't also needed anymore. Since the module now technically "uses" the latest Java version, it accepts compiled classes with differing release versions without any errors.
I currently don't have the means to test this with all platform combinations, but I'd guess running each platform with their minimum supported Java version should suffice. I did decompress the output JAR and inspect a couple of common and platform classes, and their version headers looked correct.