Skip to content

Align Java compile options#4553

Merged
AuroraLS3 merged 5 commits intoplan-player-analytics:masterfrom
AnttiMK:feat/align-java-compile-options
Apr 8, 2026
Merged

Align Java compile options#4553
AuroraLS3 merged 5 commits intoplan-player-analytics:masterfrom
AnttiMK:feat/align-java-compile-options

Conversation

@AnttiMK
Copy link
Copy Markdown
Contributor

@AnttiMK AnttiMK commented Apr 6, 2026

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

  • Make sure your name is added to Contributors file /Plan/common/src/main/java/com/djrapitops/plan/delivery/rendering/html/Contributors.java
  • If PR:ing locale changes also add a LangCode with your name /Plan/common/src/main/java/com/djrapitops/plan/settings/locale/LangCode.java

Description

Aligns Java compile options so that application code is compiled to a desired release version, while all other tasks (e.g. tests) can use the latest version. This now makes it possible to write tests with Java 25, while keeping application code per module at a specified release version. Shadowed module dependencies (apart from Adventure module) for the plugin module aren't also needed anymore. Since the module now technically "uses" the latest Java version, it accepts compiled classes with differing release versions without any errors.

I currently don't have the means to test this with all platform combinations, but I'd guess running each platform with their minimum supported Java version should suffice. I did decompress the output JAR and inspect a couple of common and platform classes, and their version headers looked correct.

Copy link
Copy Markdown
Collaborator

@AuroraLS3 AuroraLS3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

I tested following versions

  • ✔ Java 25 Paper 1.21.8
  • ✔ Java 25 Bungeecord (latest)
  • ✔ Java 25 Velocity 3.5.0-SNAPSHOT
  • ✔ Java 21 Sponge 13
  • ✖ Java 25 Sponge 13 (Did not function - which is expected)
  • ✔ Java 25 Folia 1.20.4
  • ✔ Java 11 nukkit

I assume you have tested following versions, please let me know if you have not.

  • Java 11 Paper 1.12.2
  • Java 25 Fabric

@AuroraLS3
Copy link
Copy Markdown
Collaborator

Sorry I meant Java 11 Paper 1.13.2

@AuroraLS3
Copy link
Copy Markdown
Collaborator

You might also want to edit Contributors.java

@AnttiMK
Copy link
Copy Markdown
Contributor Author

AnttiMK commented Apr 8, 2026

I assume you have tested following versions

Yeah, I just realized I tried on 1.12.2 with Java 11 and it worked so I'm assuming 1.13.2 also works xD

@AuroraLS3 AuroraLS3 merged commit 6d4de55 into plan-player-analytics:master Apr 8, 2026
1 check passed
@AnttiMK AnttiMK deleted the feat/align-java-compile-options branch April 8, 2026 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants