fix: usage with starlette >= 1#5423
Open
grawlinson wants to merge 1 commit intoplatformio:developfrom
Open
Conversation
|
|
grawlinson
force-pushed
the
port-starlette-1
branch
from
3cac56d to
f84ce21
Compare
dekeonus
reviewed
Apr 30, 2026
|
I added support for starlette-1.0.0 to gentoo's build for platformio-core. |
starlette has removed the on_startup/shutdown handlers in favour of a lifespan handler. This commit implements support for starlette >= 1.
grawlinson
force-pushed
the
port-starlette-1
branch
from
f84ce21 to
c80af83
Compare
Author
I've just replaced the PR with this commit, as it's a lot better ... not to mention that it actually works! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 1.0.0, starlette has removed the on_startup/shutdown handlers (Kludex/starlette#3117) in favour of a lifespan handler. This commit implements support for starlette >= 1.
However, I have not touched
platformio/dependencies.pysince I do not know what this project's policy is on dependencies. Let me know if you'd like that implemented also.