Skip to content

fix: usage with starlette >= 1 #5423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
grawlinson wants to merge 1 commit into
base: develop
Choose a base branch
from
+19 −6
Open

fix: usage with starlette >= 1 #5423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions platformio/home/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@

import os
from urllib.parse import urlparse
import contextlib
import contextvars

import click
import uvicorn
Expand Down Expand Up @@ -86,18 +88,29 @@ def run_server(host, port, no_open, shutdown_timeout, home_url):
if path != "/":
routes.append(Route("/", protected_page))

no_open_var.set(no_open)
home_url_var.set(home_url)

uvicorn.run(
Starlette(
middleware=[Middleware(ShutdownMiddleware)],
routes=routes,
on_startup=[
lambda: click.echo(
"PIO Home has been started. Press Ctrl+C to shutdown."
),
lambda: None if no_open else click.launch(home_url),
],
lifespan=lifespan,
),
host=host,
port=port,
log_level="warning",
)


no_open_var = contextvars.ContextVar('no_open')
home_url_var = contextvars.ContextVar('home_url')

@contextlib.asynccontextmanager
async def lifespan(app):
no_open = no_open_var.get()
home_url = home_url_var.get()
click.echo("PIO Home has been started. Press Ctrl+C to shutdown.")
if not no_open:
click.launch(home_url)
yield