Declare pip runtime dependency#5468
Open
JamBalaya56562 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pipas a PlatformIO Python dependency so pipx/uvx/uv tool environments install it explicitlypipupgrade target fromupgrade_pip_dependencies()Root cause
PlatformIO invokes
python -m pipat runtime for tool/Python package installation, butpipwas not listed inget_pip_dependencies(). Isolated runners such as pipx, uvx, anduv tool installonly install declared dependencies, so those environments can omit thepipmodule and fail withNo module named pip.Fixes #5418.
Related to #5305.
Validation
C:\Users\Jam\AppData\Local\mise\installs\uv\0.11.26\uv.exe run --with pytest --with-editable . -- python -m pytest tests/misc/test_dependencies.pyC:\Users\Jam\AppData\Local\mise\installs\uv\0.11.26\uv.exe run --with-editable . -- python -c "import importlib.metadata as md; reqs=md.requires('platformio') or []; print([r for r in reqs if r == 'pip']); print(len(reqs))"mise exec uv@0.11.26 -- uv run --with pytest --with-editable . -- python -m pytest tests/misc/test_dependencies.py