Skip to content

Commit 54f9b4e

Browse files
committed
Drop dotCover from PR workflows and keep SonarCloud static analysis only
1 parent 40b6d8b commit 54f9b4e

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

.github/workflows/account.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ jobs:
103103
working-directory: application
104104
run: npx turbo run build --filter=@repo/emails
105105

106-
- name: Run Tests with dotCover and SonarScanner Reporting
106+
- name: Run Tests with SonarScanner Analysis
107107
working-directory: application
108108
env:
109109
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -112,11 +112,11 @@ jobs:
112112
if [[ "${{ vars.SONAR_PROJECT_KEY }}" == "" ]] || [[ "${{ vars.SONAR_ORGANIZATION }}" == "" ]] || [[ "${{ secrets.SONAR_TOKEN }}" == "" ]]; then
113113
echo "SonarCloud is not enabled. Skipping SonarCloud analysis."
114114
dotnet build account/Account.slnf --no-restore /p:Version=${{ steps.generate_version.outputs.version }} /p:DeploymentCommitHash=${{ github.event.pull_request.head.sha || github.sha }} /p:DeploymentGithubActionId=${{ github.run_id }} &&
115-
dotnet test account/Account.slnf --no-build --blame-hang-timeout 5m --logger "console;verbosity=normal"
115+
dotnet test account/Account.slnf --no-build
116116
else
117-
dotnet sonarscanner begin /k:"${{ vars.SONAR_PROJECT_KEY }}" /o:"${{ vars.SONAR_ORGANIZATION }}" /d:sonar.host.url="https://sonarcloud.io" /d:sonar.cs.dotcover.reportsPaths="coverage/dotCover.html" &&
117+
dotnet sonarscanner begin /k:"${{ vars.SONAR_PROJECT_KEY }}" /o:"${{ vars.SONAR_ORGANIZATION }}" /d:sonar.host.url="https://sonarcloud.io" &&
118118
dotnet build account/Account.slnf --no-restore /p:Version=${{ steps.generate_version.outputs.version }} /p:DeploymentCommitHash=${{ github.event.pull_request.head.sha || github.sha }} /p:DeploymentGithubActionId=${{ github.run_id }} &&
119-
dotnet dotcover test account/Account.slnf --no-build --blame-hang-timeout 5m --logger "console;verbosity=normal" --dcOutput=coverage/dotCover.html --dcReportType=HTML --dcFilters="+:Account*;+:SharedKernel;-:*.Tests;-:type=*.AppHost.*" &&
119+
dotnet test account/Account.slnf --no-build &&
120120
dotnet sonarscanner end
121121
fi
122122

.github/workflows/main.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ jobs:
103103
working-directory: application
104104
run: npx turbo run build --filter=@repo/emails
105105

106-
- name: Run Tests with dotCover and SonarScanner Reporting
106+
- name: Run Tests with SonarScanner Analysis
107107
working-directory: application
108108
env:
109109
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -114,9 +114,9 @@ jobs:
114114
dotnet build main/Main.slnf --no-restore /p:Version=${{ steps.generate_version.outputs.version }} /p:DeploymentCommitHash=${{ github.event.pull_request.head.sha || github.sha }} /p:DeploymentGithubActionId=${{ github.run_id }} &&
115115
dotnet test main/Main.slnf --no-build
116116
else
117-
dotnet sonarscanner begin /k:"${{ vars.SONAR_PROJECT_KEY }}" /o:"${{ vars.SONAR_ORGANIZATION }}" /d:sonar.host.url="https://sonarcloud.io" /d:sonar.cs.dotcover.reportsPaths="coverage/dotCover.html" &&
117+
dotnet sonarscanner begin /k:"${{ vars.SONAR_PROJECT_KEY }}" /o:"${{ vars.SONAR_ORGANIZATION }}" /d:sonar.host.url="https://sonarcloud.io" &&
118118
dotnet build main/Main.slnf --no-restore /p:Version=${{ steps.generate_version.outputs.version }} /p:DeploymentCommitHash=${{ github.event.pull_request.head.sha || github.sha }} /p:DeploymentGithubActionId=${{ github.run_id }} &&
119-
dotnet dotcover test main/Main.slnf --no-build --dcOutput=coverage/dotCover.html --dcReportType=HTML --dcFilters="+:Main*;+:SharedKernel;-:*.Tests;-:type=*.AppHost.*" &&
119+
dotnet test main/Main.slnf --no-build &&
120120
dotnet sonarscanner end
121121
fi
122122

0 commit comments

Comments
 (0)