Activate account-overview and compact-view kill-switch flags in e2e tests so Features and Beta sections render on default seed

Author: tjementum

application/account/WebApp/tests/e2e/feature-flag-flows.spec.ts

@@ -50,6 +50,19 @@ async function activateAndPinRollout(page: Page, flagKey: string, rolloutPercent
   expect(rolloutResponse.ok()).toBe(true);
 }
 
+// Globally activate a kill-switch flag via the back-office API. The reconciler creates kill-switch
+// flags inactive on first sight, so an admin must Activate before tenants can evaluate them or
+// before owner-configurable flags surface in the /account/settings Features section. The PUT is
+// idempotent — calling it on an already-active flag just refreshes EnabledAt.
+async function activateKillSwitchFlag(page: Page, flagKey: string): Promise<void> {
+  const headers = await getAntiforgeryHeaders(page);
+  const activateResponse = await page.request.put(
+    `${BACK_OFFICE_BASE_URL}/api/back-office/feature-flags/${flagKey}/activate`,
+    { headers }
+  );
+  expect(activateResponse.ok()).toBe(true);
+}
+
 // Remove every tenant-override on `flagKey` across the entire database. The override toggles in
 // @smoke pick the first "Test Organization" row, but the back-office tables interleave every
 // worker's tenant (and stale rows from old runs), so the .first() row is unpredictable unless we
@@ -179,11 +192,17 @@ test.describe("@smoke", () => {
 
     // Both @smoke and @comprehensive mutate the shared beta-features rollout; both leave it at 100
     // and remove any tenant-override they created, so cross-test ordering is deterministic.
-    await step("Activate beta-features and pin rollout to 100 via back-office API & verify tenants evaluate enabled")(
-      async () => {
-        await activateAndPinRollout(page, "beta-features", 100);
-      }
-    )();
+    // account-overview and compact-view are kill-switch flags created inactive by the reconciler —
+    // activate them here so the Features section on /account/settings and the Feature preferences
+    // section on /user/preferences later in this test are non-empty (those sections are hidden when
+    // no tenant- or user-configurable flag has an active base row).
+    await step(
+      "Activate beta-features, account-overview, compact-view and pin beta-features rollout to 100 via back-office API & verify tenants evaluate enabled"
+    )(async () => {
+      await activateAndPinRollout(page, "beta-features", 100);
+      await activateKillSwitchFlag(page, "account-overview");
+      await activateKillSwitchFlag(page, "compact-view");
+    })();
 
     await step("Remove all leftover tenant overrides for beta-features & verify clean precondition")(async () => {
       await removeAllTenantOverrides(page, "beta-features");

application/account/WebApp/tests/e2e/user-management-flows.spec.ts

@@ -1,14 +1,43 @@
-import { expect } from "@playwright/test";
+import { type BrowserContext, expect, type Page } from "@playwright/test";
 import { test } from "@shared/e2e/fixtures/page-auth";
+import { getBackOfficeBaseUrl } from "@shared/e2e/utils/constants";
 import {
   createTestContext,
   expectToastMessage,
   selectOption,
   typeOneTimeCode
 } from "@shared/e2e/utils/test-assertions";
-import { completeSignupFlow, getVerificationCode, testUser } from "@shared/e2e/utils/test-data";
+import { completeSignupFlow, getVerificationCode, logInAsAdmin, testUser } from "@shared/e2e/utils/test-data";
 import { step } from "@shared/e2e/utils/test-step-wrapper";
 
+const BACK_OFFICE_BASE_URL = getBackOfficeBaseUrl();
+
+// account-overview is a kill-switch flag — the reconciler creates the base row inactive on first
+// sight, so the Features section on /account/settings stays empty (the section returns null when
+// no tenant-configurable flag has an active base row) until an admin explicitly activates it.
+// Activating is idempotent (PUT just resets EnabledAt), so this can run for every test that needs
+// the toggle without coordinating across tests.
+async function activateAccountOverviewFlag(browserContext: BrowserContext): Promise<void> {
+  const backOfficePage = await browserContext.newPage();
+  await backOfficePage.goto(`${BACK_OFFICE_BASE_URL}/feature-flags`);
+  await logInAsAdmin(backOfficePage, `${BACK_OFFICE_BASE_URL}/feature-flags`);
+
+  const antiforgeryToken = await getAntiforgeryToken(backOfficePage);
+  const activateResponse = await backOfficePage.request.put(
+    `${BACK_OFFICE_BASE_URL}/api/back-office/feature-flags/account-overview/activate`,
+    { headers: { "x-xsrf-token": antiforgeryToken } }
+  );
+  expect(activateResponse.ok()).toBe(true);
+
+  await backOfficePage.close();
+}
+
+async function getAntiforgeryToken(page: Page): Promise<string> {
+  return page.evaluate(
+    () => document.head.querySelector('meta[name="antiforgeryToken"]')?.getAttribute("content") ?? ""
+  );
+}
+
 test.describe("@smoke", () => {
   /**
    * COMPREHENSIVE USER MANAGEMENT WORKFLOW
@@ -470,12 +499,23 @@ test.describe("@comprehensive", () => {
    * - Permanent delete user via confirmation dialog
    * - Empty recycle bin functionality
    */
-  test("should handle single and bulk user deletion workflows with dashboard integration", async ({ page }) => {
+  test("should handle single and bulk user deletion workflows with dashboard integration", async ({
+    page,
+    browser
+  }) => {
     const context = createTestContext(page);
     const owner = testUser();
     const user1 = testUser();
     const user2 = testUser();
 
+    // The Features section on /account/settings only renders when at least one tenant-configurable
+    // flag has an active base row. account-overview is the only such flag and is a kill-switch flag
+    // (created inactive by the reconciler), so activate it once via the back-office API up front so
+    // the later "Enable the account-overview feature flag via settings" step finds the section.
+    const backOfficeContext = await browser.newContext({ baseURL: BACK_OFFICE_BASE_URL, ignoreHTTPSErrors: true });
+    await activateAccountOverviewFlag(backOfficeContext);
+    await backOfficeContext.close();
+
     // === USER SETUP SECTION ===
     await step("Complete owner signup & verify dashboard")(async () => {
       await completeSignupFlow(page, expect, owner, context);