Add CI workflow for developer CLI and tighten frontend-quality gates (#890)

### Summary & Motivation

Bring the developer CLI under CI and close two gaps in the existing
frontend pipeline.

- Add `.github/workflows/developer-cli.yml` that runs build, format, and
lint on the developer CLI whenever files under `developer-cli/**`
change. Mirrors the backend pattern from `main.yml` and skips the CLI's
self-rebuild path with `DEVELOPERCLI_SKIP_CHANGE_DETECTION=1`. Make it a
required check on `main` to gate merges.
- Add a frontend formatting diff check to `main.yml` and `account.yml`
(run `npm run format` then `git diff --exit-code`). The backend already
had this; the frontend only ran lint, so `oxfmt`/`oxlint --fix` drift
could land silently.
- Replace the AI-driven `translate` developer-CLI command with a
missing-translation check inside `lint --frontend`. The check parses
every non-`en-US` `.po` file (excluding `node_modules`) with
`Karambolo.PO` and fails with a per-file count when entries have empty
`msgstr`. Drops the `translate` command and its OpenAI/Azure dependency
closure (Azure.AI.OpenAI, Microsoft.Extensions.AI{,.OpenAI}, OpenAI).
`Karambolo.PO` is kept for the new check; `SecretHelper` is kept since
downstream projects may use it.
- Fill in the existing 26 missing Danish translations in
`account/WebApp` and `account/BackOffice` so the new check passes on
this branch.
- Drop dotCover from the PR workflows in `main.yml` / `account.yml`.
SonarCloud's static analysis stays; coverage is not enforced on PRs.
Re-introducing coverage on `main` (full-backend, no TypeScript) is
tracked separately.
- Drop the now-stale Coverage badge from `README.md` since coverage is
no longer produced on every PR.
- Drop the redundant `forcePrompt:` named argument in
`InstallCommand.GitHooksSync.Sync(true)` so JetBrains cleanup doesn't
rewrite it under the new format gate.

### Checklist

- [x] I have added tests, or done manual regression tests
- [x] I have updated the documentation, if necessary

Author: tjementum

.github/workflows/account.yml

@@ -103,7 +103,7 @@ jobs:
         working-directory: application
         run: npx turbo run build --filter=@repo/emails
 
-      - name: Run Tests with dotCover and SonarScanner Reporting
+      - name: Run Tests with SonarScanner Analysis
         working-directory: application
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -114,9 +114,9 @@ jobs:
             dotnet build account/Account.slnf --no-restore /p:Version=${{ steps.generate_version.outputs.version }} /p:DeploymentCommitHash=${{ github.event.pull_request.head.sha || github.sha }} /p:DeploymentGithubActionId=${{ github.run_id }} &&
             dotnet test account/Account.slnf --no-build
           else
-            dotnet sonarscanner begin /k:"${{ vars.SONAR_PROJECT_KEY }}" /o:"${{ vars.SONAR_ORGANIZATION }}" /d:sonar.host.url="https://sonarcloud.io" /d:sonar.cs.dotcover.reportsPaths="coverage/dotCover.html" &&
+            dotnet sonarscanner begin /k:"${{ vars.SONAR_PROJECT_KEY }}" /o:"${{ vars.SONAR_ORGANIZATION }}" /d:sonar.host.url="https://sonarcloud.io" &&
             dotnet build account/Account.slnf --no-restore /p:Version=${{ steps.generate_version.outputs.version }} /p:DeploymentCommitHash=${{ github.event.pull_request.head.sha || github.sha }} /p:DeploymentGithubActionId=${{ github.run_id }} &&
-            dotnet dotcover test account/Account.slnf --no-build --dcOutput=coverage/dotCover.html --dcReportType=HTML --dcFilters="+:Account*;+:SharedKernel;-:*.Tests;-:type=*.AppHost.*" &&
+            dotnet test account/Account.slnf --no-build &&
             dotnet sonarscanner end
           fi
 
@@ -223,10 +223,32 @@ jobs:
         working-directory: application/account/WebApp
         run: npm run lint
 
+      - name: Check for Frontend Formatting Issues
+        working-directory: application/account/WebApp
+        run: |
+          npm run format
+
+          # Check for any changes made by the code formatter
+          git diff --exit-code || {
+            echo "Formatting issues detected. Please run 'npm run format' from /application/account/WebApp folder locally and commit the formatted code."
+            exit 1
+          }
+
       - name: Run Back Office Lint
         working-directory: application/account/BackOffice
         run: npm run lint
 
+      - name: Check for Back Office Formatting Issues
+        working-directory: application/account/BackOffice
+        run: |
+          npm run format
+
+          # Check for any changes made by the code formatter
+          git diff --exit-code || {
+            echo "Formatting issues detected. Please run 'npm run format' from /application/account/BackOffice folder locally and commit the formatted code."
+            exit 1
+          }
+
   database-migrations-stage:
     name: Database Staging
     if: ${{ vars.STAGING_CLUSTER_ENABLED == 'true' }}

.github/workflows/developer-cli.yml

@@ -0,0 +1,70 @@
+name: Developer CLI
+
+on:
+  push:
+    branches:
+      - main
+    paths:
+      - "developer-cli/**"
+      - ".github/workflows/developer-cli.yml"
+      - "!**.md"
+  pull_request:
+    paths:
+      - "developer-cli/**"
+      - ".github/workflows/developer-cli.yml"
+      - "!**.md"
+  workflow_dispatch:
+
+permissions:
+  contents: read
+
+jobs:
+  build-and-verify:
+    name: Build, Lint, and Format
+    runs-on: ubuntu-24.04
+
+    env:
+      # Skip the CLI's self-rebuild on every invocation; we build explicitly below.
+      DEVELOPERCLI_SKIP_CHANGE_DETECTION: "1"
+
+    steps:
+      - name: Checkout Code
+        uses: actions/checkout@v6
+
+      - name: Setup .NET Core SDK
+        uses: actions/setup-dotnet@v5
+        with:
+          global-json-file: developer-cli/global.json
+
+      - name: Restore .NET Tools
+        working-directory: developer-cli
+        run: dotnet tool restore
+
+      - name: Restore .NET Dependencies
+        working-directory: developer-cli
+        run: dotnet restore
+
+      - name: Build Developer CLI
+        working-directory: developer-cli
+        run: dotnet build DeveloperCli.slnx --no-restore
+
+      - name: Run Code Linting
+        working-directory: developer-cli
+        run: |
+          dotnet run --no-build -- lint --cli --no-build | tee lint-output.log
+
+          if ! grep -q "No developer-cli issues found!" lint-output.log; then
+            echo "Code linting issues found."
+            exit 1
+          fi
+
+      - name: Check for Code Formatting Issues
+        working-directory: developer-cli
+        run: |
+          dotnet run --no-build -- format --cli --no-build
+
+          # Check for any changes made by the code formatter
+          git diff --exit-code || {
+            echo "Formatting issues detected. Please run 'dotnet run -- format --cli' from /developer-cli folder locally and commit the formatted code."
+            exit 1
+          }

.github/workflows/main.yml

@@ -103,7 +103,7 @@ jobs:
         working-directory: application
         run: npx turbo run build --filter=@repo/emails
 
-      - name: Run Tests with dotCover and SonarScanner Reporting
+      - name: Run Tests with SonarScanner Analysis
         working-directory: application
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -114,9 +114,9 @@ jobs:
             dotnet build main/Main.slnf --no-restore /p:Version=${{ steps.generate_version.outputs.version }} /p:DeploymentCommitHash=${{ github.event.pull_request.head.sha || github.sha }} /p:DeploymentGithubActionId=${{ github.run_id }} &&
             dotnet test main/Main.slnf --no-build
           else
-            dotnet sonarscanner begin /k:"${{ vars.SONAR_PROJECT_KEY }}" /o:"${{ vars.SONAR_ORGANIZATION }}" /d:sonar.host.url="https://sonarcloud.io" /d:sonar.cs.dotcover.reportsPaths="coverage/dotCover.html" &&
+            dotnet sonarscanner begin /k:"${{ vars.SONAR_PROJECT_KEY }}" /o:"${{ vars.SONAR_ORGANIZATION }}" /d:sonar.host.url="https://sonarcloud.io" &&
             dotnet build main/Main.slnf --no-restore /p:Version=${{ steps.generate_version.outputs.version }} /p:DeploymentCommitHash=${{ github.event.pull_request.head.sha || github.sha }} /p:DeploymentGithubActionId=${{ github.run_id }} &&
-            dotnet dotcover test main/Main.slnf --no-build --dcOutput=coverage/dotCover.html --dcReportType=HTML --dcFilters="+:Main*;+:SharedKernel;-:*.Tests;-:type=*.AppHost.*" &&
+            dotnet test main/Main.slnf --no-build &&
             dotnet sonarscanner end
           fi
 
@@ -218,6 +218,17 @@ jobs:
         working-directory: application/main/WebApp
         run: npm run lint
 
+      - name: Check for Frontend Formatting Issues
+        working-directory: application/main/WebApp
+        run: |
+          npm run format
+
+          # Check for any changes made by the code formatter
+          git diff --exit-code || {
+            echo "Formatting issues detected. Please run 'npm run format' from /application/main/WebApp folder locally and commit the formatted code."
+            exit 1
+          }
+
   database-migrations-stage:
     name: Database Staging
     if: ${{ vars.STAGING_CLUSTER_ENABLED == 'true' }}

README.md

@@ -11,7 +11,6 @@
 [![GitHub issues with roadmap label](https://img.shields.io/github/issues-raw/platformplatform/PlatformPlatform/roadmap?label=roadmap&logo=github&color=%23006B75)](https://github.com/orgs/PlatformPlatform/projects/2/views/2?filterQuery=is%3Aopen+label%3Aroadmap)
 [![GitHub issues with bug label](https://img.shields.io/github/issues-raw/platformplatform/PlatformPlatform/bug?label=bugs&logo=github&color=red)](https://github.com/platformplatform/PlatformPlatform/issues?q=is%3Aissue+is%3Aopen+label%3Abug)
 
-<a href="https://sonarcloud.io/component_measures?id=PlatformPlatform_platformplatform&metric=coverage" target="_blank" rel="noopener noreferrer"><img src="https://sonarcloud.io/api/project_badges/measure?project=PlatformPlatform_platformplatform&metric=coverage" alt="Coverage" /></a>
 <a href="https://sonarcloud.io/summary/overall?id=PlatformPlatform_platformplatform" target="_blank" rel="noopener noreferrer"><img src="https://sonarcloud.io/api/project_badges/measure?project=PlatformPlatform_platformplatform&metric=alert_status" alt="Quality Gate Status" /></a>
 <a href="https://sonarcloud.io/component_measures?id=PlatformPlatform_platformplatform&metric=Security" target="_blank" rel="noopener noreferrer"><img src="https://sonarcloud.io/api/project_badges/measure?project=PlatformPlatform_platformplatform&metric=security_rating" alt="Security Rating" /></a>
 <a href="https://sonarcloud.io/component_measures?id=PlatformPlatform_platformplatform&metric=Reliability" target="_blank" rel="noopener noreferrer"><img src="https://sonarcloud.io/api/project_badges/measure?project=PlatformPlatform_platformplatform&metric=reliability_rating" alt="Reliability Rating" /></a>

application/account/WebApp/shared/translations/locale/da-DK.po

@@ -186,7 +186,7 @@ msgid "Achieved in Microsoft Defender for Cloud following Azure best practices"
 msgstr "Opnået i Microsoft Defender for Cloud ved at følge Azures bedste praksis"
 
 msgid "Action"
-msgstr ""
+msgstr "Handling"
 
 msgid "Activating subscription"
 msgstr "Aktiverer abonnement"
@@ -204,7 +204,7 @@ msgid "Active users in the past 30 days"
 msgstr "Aktive brugere i de sidste 30 dage"
 
 msgid "Add an extra layer of security to your account."
-msgstr ""
+msgstr "Tilføj et ekstra sikkerhedslag til din konto."
 
 msgid "Add billing information"
 msgstr "Tilføj faktureringsoplysninger"
@@ -461,7 +461,7 @@ msgid "Bold"
 msgstr "Fed"
 
 msgid "Bordered row for stand-alone settings or list items."
-msgstr ""
+msgstr "Række med kant til selvstændige indstillinger eller listeelementer."
 
 msgid "Bottom"
 msgstr "Bund"
@@ -1059,7 +1059,7 @@ msgid "Email address"
 msgstr "E-mailadresse"
 
 msgid "Email me when a new device signs in."
-msgstr ""
+msgstr "Send mig en e-mail, når en ny enhed logger ind."
 
 msgid "Email support"
 msgstr "E-mail-support"
@@ -1137,7 +1137,7 @@ msgid "Export as PDF"
 msgstr "Eksporter som PDF"
 
 msgid "External"
-msgstr ""
+msgstr "Ekstern"
 
 msgid "Extra large"
 msgstr "Ekstra stor"
@@ -1290,7 +1290,7 @@ msgid "Indeterminate"
 msgstr "Ubestemt"
 
 msgid "Indeterminate loading indicator. Use Progress when you can show how much work remains; reach for Spinner when you can't."
-msgstr ""
+msgstr "Ubestemt indlæsningsindikator. Brug Progress, når du kan vise, hvor meget arbejde der er tilbage; vælg Spinner, når du ikke kan."
 
 msgid "Indian"
 msgstr "Indisk"
@@ -1344,13 +1344,13 @@ msgid "Italic"
 msgstr "Kursiv"
 
 msgid "Item — clickable row"
-msgstr ""
+msgstr "Element — klikbar række"
 
 msgid "Item — image media"
-msgstr ""
+msgstr "Element — billedmedie"
 
 msgid "Item — variants"
-msgstr ""
+msgstr "Element — varianter"
 
 msgid "Item archived"
 msgstr "Element arkiveret"
@@ -1359,7 +1359,7 @@ msgid "Item deleted"
 msgstr "Element slettet"
 
 msgid "ItemGroup — settings list"
-msgstr ""
+msgstr "ItemGroup — indstillingsliste"
 
 msgid "January - June 2024"
 msgstr "Januar - juni 2024"
@@ -1506,7 +1506,7 @@ msgid "Logged out"
 msgstr "Logget ud"
 
 msgid "Login alerts"
-msgstr ""
+msgstr "Login-advarsler"
 
 msgid "Login method"
 msgstr "Login-metode"
@@ -1533,7 +1533,7 @@ msgid "Main navigation"
 msgstr "Hovednavigation"
 
 msgid "Manage"
-msgstr ""
+msgstr "Administrer"
 
 msgid "Manage subscription"
 msgstr "Administrer abonnement"
@@ -1641,7 +1641,7 @@ msgid "Multi-select summary side pane"
 msgstr "Oversigtspanel for flervalg"
 
 msgid "Muted"
-msgstr ""
+msgstr "Dæmpet"
 
 msgid "Name"
 msgstr "Navn"
@@ -1740,7 +1740,7 @@ msgid "Number (integer)"
 msgstr "Tal (heltal)"
 
 msgid "Off"
-msgstr ""
+msgstr "Fra"
 
 msgid "OK"
 msgstr "OK"
@@ -1749,7 +1749,7 @@ msgid "Okonomiyaki"
 msgstr "Okonomiyaki"
 
 msgid "On"
-msgstr ""
+msgstr "Til"
 
 msgid "One-time code"
 msgstr "Engangskode"
@@ -1824,7 +1824,7 @@ msgid "Palak paneer"
 msgstr "Palak paneer"
 
 msgid "Passkeys"
-msgstr ""
+msgstr "Passkeys"
 
 msgid "Passwordless deployments"
 msgstr "Adgangskodeløse implementeringer"
@@ -2388,7 +2388,7 @@ msgid "Sidebar footer"
 msgstr "Sidemenu-sidefod"
 
 msgid "Sign in without a password using your device."
-msgstr ""
+msgstr "Log ind uden adgangskode med din enhed."
 
 msgid "Sign up"
 msgstr "Tilmeld dig"
@@ -2421,10 +2421,10 @@ msgid "SLA"
 msgstr "SLA"
 
 msgid "Slider (range)"
-msgstr ""
+msgstr "Slider (interval)"
 
 msgid "Slider with steps"
-msgstr ""
+msgstr "Slider med trin"
 
 msgid "Slow-cooked classics"
 msgstr "Langtidsstegte klassikere"
@@ -2463,7 +2463,7 @@ msgid "Spaghetti carbonara"
 msgstr "Spaghetti carbonara"
 
 msgid "Spinner"
-msgstr ""
+msgstr "Spinner"
 
 msgid "Split buttons"
 msgstr "Delte knapper"
@@ -2512,7 +2512,7 @@ msgid "Subscription"
 msgstr "Abonnement"
 
 msgid "Subtle background for grouped rows inside a panel."
-msgstr ""
+msgstr "Diskret baggrund til grupperede rækker i et panel."
 
 msgid "Succeeded"
 msgstr "Gennemført"
@@ -2542,7 +2542,7 @@ msgid "Tablet"
 msgstr "Tablet"
 
 msgid "Tabs"
-msgstr ""
+msgstr "Faner"
 
 msgid "Tacos al pastor"
 msgstr "Tacos al pastor"
@@ -2731,7 +2731,7 @@ msgid "Try again"
 msgstr "Prøv igen"
 
 msgid "Two-factor authentication"
-msgstr ""
+msgstr "Tofaktor-godkendelse"
 
 msgid "Type a command or search..."
 msgstr "Skriv en kommando eller søg..."
@@ -2921,7 +2921,7 @@ msgid "View profile"
 msgstr "Se profil"
 
 msgid "View profile verification"
-msgstr ""
+msgstr "Vis profilbekræftelse"
 
 msgid "View users"
 msgstr "Se brugere"
@@ -3038,7 +3038,7 @@ msgid "Your plan will be downgraded to {planName} at the end of your current bil
 msgstr "Din plan vil blive nedgraderet til {planName} ved udgangen af din nuværende faktureringsperiode. Du beholder dine nuværende planfunktioner indtil da."
 
 msgid "Your profile has been verified"
-msgstr ""
+msgstr "Din profil er blevet bekræftet"
 
 msgid "Your scheduled downgrade has been cancelled."
 msgstr "Din planlagte nedgradering er blevet afbrudt."

developer-cli/Commands/InstallCommand.cs

@@ -68,7 +68,7 @@ private static void Execute(bool force)
         {
             AnsiConsole.WriteLine();
             RegisterAlias();
-            GitHooksSync.Sync(forcePrompt: true);
+            GitHooksSync.Sync(true);
         }
 
         AnsiConsole.MarkupLine(