Activity::wait() should check for the cancelled state

pjcdawkins · pjcdawkins · commit bf97f314bcf1 · 2022-05-17T11:57:19.000+01:00
diff --git a/src/Model/Activity.php b/src/Model/Activity.php
@@ -67,7 +67,7 @@ public function wait(callable $onPoll = null, callable $onLog = null, $pollInter
             }
         }
         $retries = 0;
-        while (!$this->isComplete()) {
+        while (!$this->isComplete() && $this->state !== self::STATE_CANCELLED) {
             usleep($pollInterval * 1000000);
             try {
                 $this->refresh(['timeout' => $pollInterval + 5]);

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ public function wait(callable $onPoll = null, callable $onLog = null, $pollInter`
`67`	`67`	`}`
`68`	`68`	`}`
`69`	`69`	`$retries = 0;`
`70`		`- while (!$this->isComplete()) {`
	`70`	`+ while (!$this->isComplete() && $this->state !== self::STATE_CANCELLED) {`
`71`	`71`	`usleep($pollInterval * 1000000);`
`72`	`72`	`try {`
`73`	`73`	`$this->refresh(['timeout' => $pollInterval + 5]);`