Commit 59f8c50
authored
Fix Googlebot homepage screenshot: unbounded
### Motivation
Live test screenshot of https://nicegui.io looks like:
<img height="300" alt="image"
src="https://github.com/user-attachments/assets/2c182de6-8c90-40e4-8188-8d4fa288fdad"
/>
while the rest of the pages are all normal.
### Implementation
The implementation details of `Google Inspection Tool smartphone`
remains intentionally sparse by Google, but it is likely that it
simulates a really long screen to facilitate taking a long screenshot
without scrolling-and-stitching.
Assuming this is true, I set a `max-h-[200vw]` to limit the first chunk
in our documentation to a 1:2 aspect ratio.
As no mainstream phone broke the 2:1 aspect ratio bound, 99% users
should not notice a difference.
For the 1% (Foldable phone users on external screen), you will have a
blue bar at the bottom, but I'd argue the visual balance is better after
this fix anyways 🤷
<img height="300" alt="image"
src="https://github.com/user-attachments/assets/2c2ec512-9fe6-41cd-b8fe-b97d747fa9c1"
/>
### Progress
- [x] I chose a meaningful title that completes the sentence: "If
applied, this PR will..."
- [x] The implementation is complete.
- [x] If this PR addresses a security issue, it has been coordinated via
the [security
advisory](https://github.com/zauberzeug/nicegui/security/advisories/new)
process.
- [x] Pytests have been added (or are not necessary).
- [x] Documentation has been added (or is not necessary).h-screen (zauberzeug#5792)1 parent 6ba80ed commit 59f8c50
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| |||
0 commit comments