Skip to content

Commit 3523b59

Browse files
committed
Refactor percentage clauses
1 parent 348e70e commit 3523b59

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

extra/lib/plausible/stats/funnel.ex

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -168,11 +168,7 @@ defmodule Plausible.Stats.Funnel do
168168
|> Enum.reverse()
169169
end
170170

171-
defp percentage(x, y) when x in [0, nil] or y in [0, nil] do
172-
"0"
173-
end
174-
175-
defp percentage(x, y) do
171+
defp percentage(x, y) when is_integer(x) and x > 0 and is_integer(y) and y > 0 do
176172
result =
177173
x
178174
|> Decimal.div(y)
@@ -187,4 +183,8 @@ defmodule Plausible.Stats.Funnel do
187183
decimal -> decimal
188184
end
189185
end
186+
187+
defp percentage(_x, _y) do
188+
"0"
189+
end
190190
end

0 commit comments

Comments
 (0)