Remove inner validation

Author: ukutaht

lib/plausible/stats/api_query_parser.ex

@@ -130,14 +130,6 @@ defmodule Plausible.Stats.ApiQueryParser do
        when operator in [:not, :and, :or, :has_done, :has_not_done],
        do: {:ok, []}
 
-  defp parse_clauses_list([_operator, _dimension, [] | _rest] = filter) do
-    {:error,
-     %QueryError{
-       code: :invalid_filters,
-       message: "Invalid filter '#{i(filter)}': filter clauses cannot be empty."
-     }}
-  end
-
   defp parse_clauses_list([operator, dimension, list | _rest] = filter) when is_list(list) do
     all_strings? = Enum.all?(list, &is_binary/1)
     all_integers? = Enum.all?(list, &is_integer/1)

test/plausible_web/controllers/api/external_stats_controller/query_validations_test.exs

@@ -255,40 +255,4 @@ defmodule PlausibleWeb.Api.ExternalStatsController.QueryValidationsTest do
              }
     end
   end
-
-  describe "empty filter clauses" do
-    test "returns 400 for contains with empty list", %{
-      conn: conn,
-      site: site
-    } do
-      conn =
-        post(conn, "/api/v2/query", %{
-          "site_id" => site.domain,
-          "date_range" => "all",
-          "metrics" => ["pageviews"],
-          "filters" => [["contains", "event:page", []]]
-        })
-
-      assert json_response(conn, 400) == %{
-               "error" => ~s|#/filters/0: Invalid filter ["contains", "event:page", []]|
-             }
-    end
-
-    test "returns 400 for is with empty list", %{
-      conn: conn,
-      site: site
-    } do
-      conn =
-        post(conn, "/api/v2/query", %{
-          "site_id" => site.domain,
-          "date_range" => "all",
-          "metrics" => ["pageviews"],
-          "filters" => [["is", "event:page", []]]
-        })
-
-      assert json_response(conn, 400) == %{
-               "error" => ~s|#/filters/0: Invalid filter ["is", "event:page", []]|
-             }
-    end
-  end
 end