Script v2: Remove fallbacks for /js/s-... urls#5629
Merged
Conversation
macobo
approved these changes
Aug 11, 2025
Contributor
macobo
left a comment
macobo
left a comment
There was a problem hiding this comment.
Added another dependency in the description.
Approved, though let's not merge yet. If you head out to vacation first I'll make sure this will get merged.
Contributor
|
We're good to go on the GTM side (https://3.basecamp.com/5308029/buckets/38940211/messages/8628780884#__recording_8953801938), so I think this is good to merge once the other two PRs are merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
After all current sites using the v2 tracker URL starting with s- have migrated, we can remove the fallbacks.
Tests
Changelog
Documentation
Dark mode