Bring autoconfigure notification a step forwards in custom events cre…#5912
Merged
Conversation
…ation flow - Rather than showing a notification that custom events have been detected at the bottom of the form, we now show a modal prior to the form, that allows the user to add them instantly or set them up manually.
|
sanne-san
force-pushed
the
sanne-custom-events-autoconfigure
branch
from
f437a99 to
83a162c
Compare
apata
approved these changes
Dec 3, 2025
Member
|
I have some minor/stylistic reservations I'd like to push here later today if that's OK. |
Contributor
Author
Absolutely, thanks! |
Member
|
There's something fishy going on with those tests, investigating... Sorry it's taking so long. |
aerosol
approved these changes
Dec 3, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ation flow
Changes
Before:
After:
CleanShot.2025-11-26.at.14.14.33.mp4
Tests
Documentation
Dark mode