Add :segment_id field to shared_links schema#5924
Merged
Merged
Conversation
aerosol
reviewed
Dec 2, 2025
9 tasks
apata
changed the title
aerosol
reviewed
Dec 3, 2025
| add :segment_id, references(:segments, on_delete: :delete_all) | ||
| end | ||
|
|
||
| create index(:shared_links, [:segment_id]) |
Member
There was a problem hiding this comment.
this feels unnecessary, foreign keys are indexes on their own?
Contributor
Author
There was a problem hiding this comment.
Postgres docs advise creating an index on the referencing columns: https://www.postgresql.org/docs/current/ddl-constraints.html#DDL-CONSTRAINTS-FK:~:text=Since%20a%20DELETE,the%20referencing%20columns.
Contributor
Author
There was a problem hiding this comment.
Ain't no shame, thanks for raising the question!
aerosol
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds field to shared_links schema that allows limiting that shared link to this particular segment only.
Tests
Changelog
Documentation
Dark mode