Skip to content

Add :segment_id field to shared_links schema #5924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
apata merged 3 commits into from
Dec 4, 2025
Merged

Add :segment_id field to shared_links schema #5924

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f161e1
Add :limited_to_segment_id field to shared_links schema
apata Dec 1, 2025
924e77e
Refactor column name, add FK, index, and on delete cascade
apata Dec 2, 2025
0fb3035
Format
apata Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions priv/repo/migrations/20251201154500_add_limited_to_segment_to_shared_links.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
defmodule Plausible.Repo.Migrations.AddLimitedToSegmentToSharedLinks do
use Ecto.Migration

def change do
alter table(:shared_links) do
add :segment_id, references(:segments, on_delete: :delete_all)
end

create index(:shared_links, [:segment_id])

@aerosol aerosol Dec 3, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this feels unnecessary, foreign keys are indexes on their own?

@apata apata Dec 3, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Postgres docs advise creating an index on the referencing columns: https://www.postgresql.org/docs/current/ddl-constraints.html#DDL-CONSTRAINTS-FK:~:text=Since%20a%20DELETE,the%20referencing%20columns.

@aerosol aerosol Dec 3, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 /me goes on a walk of shame

@apata apata Dec 4, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ain't no shame, thanks for raising the question!

end
end
Loading