Skip to content

Fix postgrex disconnection during async tests #5926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cnkk merged 1 commit into from
Dec 2, 2025
Merged

Fix postgrex disconnection during async tests #5926

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions test/plausible_web/live/change_domain_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,15 @@ defmodule PlausibleWeb.Live.ChangeDomainTest do
[{192, 168, 1, 2}]
end)

# Stub detection by default to prevent async task race conditions
# Tests that need specific detection results can override this stub
stub_detection_result(%{
"v1Detected" => false,
"gtmLikely" => false,
"wordpressLikely" => false,
"wordpressPlugin" => false
})

:ok
end
end
Expand Down Expand Up @@ -74,15 +83,6 @@ defmodule PlausibleWeb.Live.ChangeDomainTest do
end

test "successful form submission updates database", %{conn: conn, site: site} do
on_ee do
stub_detection_result(%{
"v1Detected" => false,
"gtmLikely" => false,
"wordpressLikely" => false,
"wordpressPlugin" => false
})
end

original_domain = site.domain
new_domain = "new.#{site.domain}"
{:ok, lv, _html} = live(conn, "/#{site.domain}/change-domain")
Expand All @@ -91,6 +91,10 @@ defmodule PlausibleWeb.Live.ChangeDomainTest do
|> element("form")
|> render_submit(%{site: %{domain: new_domain}})

on_ee do
render_async(lv, 500)
end

site = Repo.reload!(site)
assert site.domain == new_domain
assert site.domain_changed_from == original_domain
Expand Down
Loading