Refactor main graph to d3.js#6159
Merged
RobertJoonas merged 40 commits intomain-graph-v2-backendfrom Apr 15, 2026
Merged
Conversation
|
cddaaaa to
2d27729
Compare
916c50b to
91df8c6
Compare
|
b590145 to
c37fa8f
Compare
47d0f68 to
df87958
Compare
7257733 to
6a3120a
Compare
apata
commented
Apr 14, 2026
Comment on lines
+6
to
+13
| const browserDateFormat = Intl.DateTimeFormat(navigator.language, { | ||
| hour: 'numeric' | ||
| }) | ||
|
|
||
| export function is12HourClock() { | ||
| return browserDateFormat.resolvedOptions().hour12 | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Copied from date-formatter.js that was deleted.
RobertJoonas
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors line graph to Typescript, from chart.js library to d3.js library. Depends on the new query backend. #6173
The rationale for switching the library:
we need d3.js for the complicated world map (can't be done with chart.js)
having two charting libraries increases the size of dashboard javascript and therefore makes the website take longer to load
Test side-by-side
Remove console.log of "effect running"
Delete line-graph.js (-301)
Delete graph-util.js (-127)
Delete graph-tooltip.js (-216)
Delete date-formatter.js (-115)
Changes
Fixes
Tests
Changelog
Documentation
Dark mode