Skip to content

Fix top pages comparison tooltip missing date labels #6221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sanne-san merged 3 commits into from
Apr 6, 2026
+9 −1
Merged

Fix top pages comparison tooltip missing date labels #6221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
755ccab
Fix top pages comparison tooltip missing date labels
sanne-san Apr 3, 2026
28db1d3
Add changelog entry
sanne-san Apr 3, 2026
3e937f2
Add meta assertions to pages controller tests
sanne-san Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ All notable changes to this project will be documented in this file.
- Fixed Stats API timeseries returning time buckets falling outside the queried range
- Fixed issue with all non-interactive events being counted as interactive
- Fixed countries map countries staying highlighted on Chrome
- Fixed comparison tooltip in the top pages report missing date labels

## v3.2.0 - 2026-01-16

Expand Down
2 changes: 1 addition & 1 deletion lib/plausible_web/controllers/api/stats_controller.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -723,7 +723,7 @@ defmodule PlausibleWeb.Api.StatsController do
else
json(conn, %{
results: pages,
meta: Map.merge(meta, Stats.Breakdown.formatted_date_ranges(query)),
meta: Map.new(meta.values) |> Map.merge(Stats.Breakdown.formatted_date_ranges(query)),
Copy link
Copy Markdown
Contributor

@apata apata Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion, non-blocking: I think we should add an assertion about pages.meta to an existing pages controller test, it doesn't seem to be covered at all right now.

Copy link
Copy Markdown
Contributor Author

@sanne-san sanne-san Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, done!

skip_imported_reason: meta[:imports_skip_reason]
})
end
Expand Down
7 changes: 7 additions & 0 deletions test/plausible_web/controllers/api/stats_controller/pages_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -657,6 +657,8 @@ defmodule PlausibleWeb.Api.StatsController.PagesTest do
"percentage" => 100.0
}
]

assert json_response(conn, 200)["meta"] == %{"date_range_label" => "1 Jan 2021"}
end

test "returns top pages with :not_member filter on custom pageview props including (none) value",
Expand Down Expand Up @@ -2212,6 +2214,11 @@ defmodule PlausibleWeb.Api.StatsController.PagesTest do
}
}
]

assert json_response(conn, 200)["meta"] == %{
"date_range_label" => "2 Jan 2021",
"comparison_date_range_label" => "1 Jan 2021"
}
end

on_ee do
Expand Down
Loading