Add highlighted vertical line to graph (with tooltip sticky to the line)#6293
Merged
Add highlighted vertical line to graph (with tooltip sticky to the line)#6293
Conversation
|
RobertJoonas
approved these changes
May 4, 2026
Contributor
RobertJoonas
left a comment
RobertJoonas
left a comment
There was a problem hiding this comment.
The UX feels amazing and looks good code-wise too. Nice work! 🙌
Comment on lines
+278
to
+283
| setTooltip({ | ||
| selectedIndex: closestPoint.index, | ||
| x: closestPoint.x, | ||
| y: 0, | ||
| persistent: true | ||
| }) |
Contributor
There was a problem hiding this comment.
Nitpick (non-blocking): Looks like the y position of the tooltip is always a fixed 0 (and I think that makes perfect sense with the vertical line!) Did you consider removing the y value from the state?
Contributor
Author
There was a problem hiding this comment.
Thanks and well spotted! I did consider it, but then decided to keep the (x, y) positioning API. With just x, it's slightly less self-explanatory. However, now that you pointed it out, I can see how it may be confusing and a source of bugs. Suggestion applied! c8d8fb0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
On touch devices, a tap summons the tooltip at tapped x-value (pre-existing logic). When the tooltip has been summoned, dragging on the graph horizontally moves the tooltip (new functionality in this PR). Panning vertically dismisses the tooltip (pre-existing logic). Dragging horizontally without the tooltip being summoned has no effect (pre-existing logic).
There's a pre-existing bug that clicks on menus don't dismiss the tooltip on mobile: this will be addressed separately.
Tests
Changelog
Documentation
Dark mode