Improve columnar display depending on journey state#6297
Merged
Conversation
We detect whether the journey has ended: when the active column has finished loading returning no results and at least one step is selected. This helps to hide pointless column when journey ends - `numColumns` caps at `number of steps + 1` (instead of the fixed minimum of 3), so the empty next step column won't be rendered. When there's only 1 step and active column is loading, `numColumns` is also capped similarily - to prevent 3rd column from flashing briefly while the API call is in flight, only to disappear if it turns out the journey has ended. Column 3 remains visible while changing selection at column 2.
|
zoldar
approved these changes
Apr 30, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We detect whether the journey has ended: when the active column has finished loading returning no results and at least one step is selected.
This helps to hide pointless column when journey ends -
numColumnscaps atnumber of steps + 1(instead of the fixed minimum of 3), so the empty next step column won't be rendered.When there's only 1 step and active column is loading,
numColumnsis also capped similarily - to prevent 3rd column from flashing briefly while the API call is in flight, only to disappear if it turns out the journey has ended.Column 3 remains visible while changing selection at column 2.
Additionally, when browsing the journey backwards, the "end" message signals reaching "beginning" of the journey.