Add custom and pageview goals to exploration suggestions#6299
Draft
Add custom and pageview goals to exploration suggestions#6299
Conversation
|
zoldar
force-pushed
the
exploration-add-pageview-and-custom-goals
branch
from
9b07856 to
d5ca259
Compare
zoldar
force-pushed
the
exploration-add-pageview-and-custom-goals
branch
from
d5ca259 to
ad50d15
Compare
This reverts commit 183e723.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR makes exploration UI account for custom and pageview goals in suggestions and exploration funnel queries.
The goals that match the event or pageview exactly, replace it. Pageview goals using a pattern are always rendered as they can neither match exact event or pageview, nor can thay match a wildcard entry, which has a different definition (it applies only to subpaths delimited "/" and not just by prefix).
The current implementation introduces a significant performance regression. It will be addressed by a subsequent refactoring - either as a part of this PR or in a follow-up.
Tests