Fix match_day_of_week for year_over_year comparisons in day and 24h periods#6300
Merged
RobertJoonas merged 1 commit intomasterfrom May 4, 2026
Merged
Fix match_day_of_week for year_over_year comparisons in day and 24h periods#6300RobertJoonas merged 1 commit intomasterfrom
RobertJoonas merged 1 commit intomasterfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Currently, the
Last 24handtodayperiods are not respectingmatch_day_of_weekinyear_over_yearcomparison mode.For
Last 24hit was never implemented. For thetodayperiod it used to work before #6205 because it didn't get the special "datetime" treatment (therefore, it fell into the defaultget_comparison_date_range(%Query{include: %{compare: :year_over_year}} = source_query)function clause, and gotmaybe_match_day_of_weekcalled on the result).This PR implements the missing piece and adds tests.
Tests
Changelog
Documentation
Dark mode