basic query building

Author: benwilson512

lib/ecto/adapters/clickhouse/connection.ex

@@ -678,14 +678,11 @@ defmodule Ecto.Adapters.ClickHouse.Connection do
 
   defp expr({:in, _, [_, {:^, _, [_ix, 0]}]}, _sources, _params, _query), do: "0"
 
-  # Handle IN with pinned array parameter - use single array param instead of expanding
   defp expr({:in, _, [left, {:^, _, [ix, len]}]}, sources, params, query) when len > 0 do
-    # Collect all the individual params into a single array
-    array_values = Enum.map(ix..(ix + len - 1), &Enum.at(params, &1))
-    p = build_param(ix, array_values)
-    binding() |> dbg
+    array_values = Enum.at(params, ix)
+    param = build_param(ix, array_values)
 
-    [expr(left, sources, params, query), " IN ", p]
+    [expr(left, sources, params, query), " IN ", param]
   end
 
   defp expr({:in, _, [left, right]}, sources, params, query) do

test/ecto/adapters/clickhouse/connection_test.exs

@@ -1019,15 +1019,15 @@ defmodule Ecto.Adapters.ClickHouse.ConnectionTest do
     assert all(query) == ~s[SELECT 0 FROM "schema" AS s0]
 
     query = Schema |> select([e], 1 in ^[1, 2, 3])
-    assert all(query) == ~s[SELECT 1 IN ({$0:Int64},{$1:Int64},{$2:Int64}) FROM "schema" AS s0]
+    assert all(query) == ~s[SELECT 1 IN {$0:Array(Int64)} FROM "schema" AS s0]
 
     query = Schema |> select([e], 1 in [1, ^2, 3])
     assert all(query) == ~s[SELECT 1 IN (1,{$0:Int64},3) FROM "schema" AS s0]
 
     query = Schema |> select([e], e.x == ^0 or e.x in ^[1, 2, 3] or e.x == ^4)
 
     assert all(query) ==
-             ~s[SELECT (s0."x" = {$0:Int64}) OR (s0."x" IN ({$1:Int64},{$2:Int64},{$3:Int64})) OR (s0."x" = {$4:Int64}) FROM "schema" AS s0]
+             ~s[SELECT (s0."x" = {$0:Int64}) OR (s0."x" IN {$1:Array(Int64)}) OR (s0."x" = {$2:Int64}) FROM "schema" AS s0]
 
     query = Schema |> select([e], e in [1, 2, 3])