poking around

Author: benwilson512

lib/ecto/adapters/clickhouse.ex

@@ -164,6 +164,7 @@ defmodule Ecto.Adapters.ClickHouse do
   def dumpers(:uuid, Ecto.UUID), do: [&__MODULE__.hex_uuid/1]
   def dumpers(:uuid, type), do: [type, &__MODULE__.hex_uuid/1]
   def dumpers(:binary_id, type), do: [type, &__MODULE__.hex_uuid/1]
+  def dumpers({:in, sub}, {:in, sub}), do: [{:array, sub}]
   def dumpers(_primitive, {:parameterized, {Ch, params}}), do: [dumper(params)]
   def dumpers({:parameterized, {Ch, params}}, type), do: [type, dumper(params)]
   def dumpers(_primitive, type), do: [type]

lib/ecto/adapters/clickhouse/connection.ex

@@ -678,6 +678,16 @@ defmodule Ecto.Adapters.ClickHouse.Connection do
 
   defp expr({:in, _, [_, {:^, _, [_ix, 0]}]}, _sources, _params, _query), do: "0"
 
+  # Handle IN with pinned array parameter - use single array param instead of expanding
+  defp expr({:in, _, [left, {:^, _, [ix, len]}]}, sources, params, query) when len > 0 do
+    # Collect all the individual params into a single array
+    array_values = Enum.map(ix..(ix + len - 1), &Enum.at(params, &1))
+    p = build_param(ix, array_values)
+    binding() |> dbg
+
+    [expr(left, sources, params, query), " IN ", p]
+  end
+
   defp expr({:in, _, [left, right]}, sources, params, query) do
     [expr(left, sources, params, query), " IN ", expr(right, sources, params, query)]
   end

test/ecto/integration/assoc_test.exs

@@ -5,6 +5,7 @@ defmodule Ecto.Integration.AssocTest do
   alias Ecto.Integration.{Post, Comment, Permalink}
 
   test "has_many assoc" do
+    Logger.configure(level: :debug)
     p1 = TestRepo.insert!(%Post{title: "1"})
     p2 = TestRepo.insert!(%Post{title: "2"})
 
@@ -16,6 +17,8 @@ defmodule Ecto.Integration.AssocTest do
     assert c1.id == cid1
     assert c2.id == cid2
 
+    TestRepo.to_sql(:all, Ecto.assoc([p1, p2], :comments)) |> dbg
+
     [c1, c2, c3] = TestRepo.all(Ecto.assoc([p1, p2], :comments)) |> Enum.sort_by(& &1.id)
     assert c1.id == cid1
     assert c2.id == cid2