WebGL _uploadDirtyTextures

Author: heretique

src/platform/graphics/webgl/webgl-graphics-device.js

@@ -1170,6 +1170,22 @@ class WebglGraphicsDevice extends GraphicsDevice {
         this.gpuProfiler.request();
     }
 
+    _uploadDirtyTextures() {
+
+        this.textures.forEach((texture) => {
+            if (texture._needsUpload || texture._needsMipmapsUpload) {
+                if (!texture.impl._glTexture) {
+                    texture.impl.initialize(this, texture);
+                }
+
+                this.bindTexture(texture);
+                texture.impl.upload(this, texture);
+                texture._needsUpload = false;
+                texture._needsMipmapsUpload = false;
+            }
+        });
+    }
+
     /**
      * Start a render pass.
      *
@@ -1181,6 +1197,8 @@ class WebglGraphicsDevice extends GraphicsDevice {
         DebugGraphics.pushGpuMarker(this, `Pass:${renderPass.name}`);
         DebugGraphics.pushGpuMarker(this, `START-PASS`);
 
+        this._uploadDirtyTextures();
+
         // set up render target
         const rt = renderPass.renderTarget ?? this.backBuffer;
         this.renderTarget = rt;
@@ -1543,7 +1561,7 @@ class WebglGraphicsDevice extends GraphicsDevice {
         if (!impl._glTexture)
             impl.initialize(this, texture);
 
-        if (impl.dirtyParameterFlags > 0 || texture._needsUpload || texture._needsMipmapsUpload) {
+        if (impl.dirtyParameterFlags > 0) {
 
             // Ensure the specified texture unit is active
             this.activeTexture(textureUnit);
@@ -1555,12 +1573,6 @@ class WebglGraphicsDevice extends GraphicsDevice {
                 this.setTextureParameters(texture);
                 impl.dirtyParameterFlags = 0;
             }
-
-            if (texture._needsUpload || texture._needsMipmapsUpload) {
-                impl.upload(this, texture);
-                texture._needsUpload = false;
-                texture._needsMipmapsUpload = false;
-            }
         } else {
             // Ensure the texture is currently bound to the correct target on the specified texture unit.
             // If the texture is already bound to the correct target on the specified unit, there's no need

src/platform/graphics/webgl/webgl-render-target.js

@@ -150,6 +150,7 @@ class WebglRenderTarget {
                         colorBuffer._width = Math.min(colorBuffer.width, device.maxRenderBufferSize);
                         colorBuffer._height = Math.min(colorBuffer.height, device.maxRenderBufferSize);
                         device.setTexture(colorBuffer, 0);
+                        colorBuffer.upload(true);
                     }
                     // Attach the color buffer
                     gl.framebufferTexture2D(
@@ -174,6 +175,7 @@ class WebglRenderTarget {
                     depthBuffer._width = Math.min(depthBuffer.width, device.maxRenderBufferSize);
                     depthBuffer._height = Math.min(depthBuffer.height, device.maxRenderBufferSize);
                     device.setTexture(depthBuffer, 0);
+                    depthBuffer.upload(true);
                 }
                 // Attach
                 if (target._stencil) {

src/platform/graphics/webgpu/webgpu-graphics-device.js

@@ -619,7 +619,7 @@ class WebgpuGraphicsDevice extends GraphicsDevice {
     _uploadDirtyTextures() {
 
         this.textures.forEach((texture) => {
-            if (texture._needsUpload || texture._needsMipmaps) {
+            if (texture._needsUpload || texture._needsMipmapsUpload) {
                 texture.upload();
             }
         });