docs: add compute shader definition types#9067
Merged
Merged
Conversation
Build size reportThis PR does not change the size of the minified bundles.
|
Public API reportThis PR changes the public API surface (+1 / −1), per the docs' rules (@ignore / @Private / undocumented are excluded). Show API diff-Shader.constructor(graphicsDevice: GraphicsDevice, definition: { attributes: object; cdefines: Map<string, string>; cincludes: Map<string, string>; computeEntryPoint: string; cshader: string; feedbackVaryings: string[]; fincludes: Map<string, string>; fragmentOutputTypes: string | string[]; fshader: string; name: string; shaderLanguage: string; useTransformFeedback: boolean; vincludes: Map<string, string>; vshader: string })
+Shader.constructor(graphicsDevice: GraphicsDevice, definition: { attributes: object; cdefines: Map<string, string>; cincludes: Map<string, string>; computeBindGroupFormat: BindGroupFormat; computeEntryPoint: string; computeUniformBufferFormats: object; cshader: string; feedbackVaryings: string[]; fincludes: Map<string, string>; fragmentOutputTypes: string | string[]; fshader: string; name: string; shaderLanguage: string; useTransformFeedback: boolean; vincludes: Map<string, string>; vshader: string })Informational only — this never fails the build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
computeBindGroupFormatandcomputeUniformBufferFormatson the publicShaderdefinition.Fixes #9060
Public API changes
The generated
Shaderdefinition type now includes the existing WebGPU compute options.Before:
After:
This corrects the type declarations only; runtime behavior is unchanged.
Testing
npm run build:typesnpm run test:typesnpm run lintPerformance considerations
None. This is a JSDoc/type declaration correction with no runtime changes.