Merge pull request #439 from xuwei-k/add-implicit-type

add explicit type annotations for implicit val

Author: mkurz

app/actors/DocumentationActor.scala

@@ -230,7 +230,7 @@ class DocumentationActor(
   import DocumentationActor._
   import actors.{ DocumentationLoadingActor => Loader }
 
-  implicit val timeout = Timeout(5.seconds)
+  implicit val timeout: Timeout = Timeout(5.seconds)
   implicit val system: ActorSystem[Nothing] = context.system
   import system.executionContext
 

app/controllers/documentation/DocumentationController.scala

@@ -35,7 +35,7 @@ class DocumentationController @Inject()(
 )(implicit actorSystem: akka.actor.ActorSystem, reverseRouter: ReverseRouter)
     extends AbstractController(components) {
 
-  private implicit val timeout = Timeout(5.seconds)
+  private implicit val timeout: Timeout = Timeout(5.seconds)
   private implicit val typedSystem: ActorSystem[Nothing] = actorSystem.toTyped
   import typedSystem.executionContext
 

app/models/Releases.scala

@@ -1,6 +1,6 @@
 package models
 
-import play.api.libs.json.Json
+import play.api.libs.json.{Json, Reads}
 
 case class PlayRelease(
     version: String,
@@ -13,13 +13,13 @@ case class PlayRelease(
 }
 
 object PlayRelease {
-  implicit val releaseReads = Json.reads[PlayRelease]
+  implicit val releaseReads: Reads[PlayRelease] = Json.reads[PlayRelease]
 }
 
 case class PlayReleases(latest: PlayRelease, development: Seq[PlayRelease], previous: Seq[PlayRelease])
 
 object PlayReleases {
-  implicit val playReleasesReads = Json.reads[PlayReleases]
+  implicit val playReleasesReads: Reads[PlayReleases] = Json.reads[PlayReleases]
 }
 
 private[models] object SecurifyUrl {

app/models/github/GitHub.scala

@@ -13,7 +13,7 @@ case class Team(id: Long, name: String, url: String, members_url: String) {
 }
 
 object Team {
-  implicit val jsonReads = Json.reads[Team]
+  implicit val jsonReads: Reads[Team] = Json.reads[Team]
 }
 
 /**
@@ -37,7 +37,7 @@ case class GitHubUser(
 }
 
 object GitHubUser {
-  implicit val jsonReads = Json.reads[GitHubUser]
+  implicit val jsonReads: Reads[GitHubUser] = Json.reads[GitHubUser]
 }
 
 case class Repository(id: Long, name: String, full_name: String, fork: Boolean, contributors_url: String) {
@@ -46,7 +46,7 @@ case class Repository(id: Long, name: String, full_name: String, fork: Boolean,
 }
 
 object Repository {
-  implicit val jsonReads = Json.reads[Repository]
+  implicit val jsonReads: Reads[Repository] = Json.reads[Repository]
 }
 
 case class Organisation(id: Long, login: String, url: String, repos_url: String, members_url: String) {
@@ -55,5 +55,5 @@ case class Organisation(id: Long, login: String, url: String, repos_url: String,
 }
 
 object Organisation {
-  implicit val jsonReads = Json.reads[Organisation]
+  implicit val jsonReads: Reads[Organisation] = Json.reads[Organisation]
 }

test/services/github/GitHubSpec.scala

@@ -1,6 +1,7 @@
 package services.github
 
 import play.api.http.DefaultFileMimeTypesProvider
+import play.api.http.DefaultFileMimeTypes
 import play.api.http.FileMimeTypesConfiguration
 import play.api.mvc.Results._
 import play.api.routing.sird.{ GET => Get, _ }
@@ -15,7 +16,7 @@ import scala.concurrent.Future
 
 object GitHubSpec extends PlaySpecification {
 
-  implicit val fileMimeTypes = new DefaultFileMimeTypesProvider(
+  implicit val fileMimeTypes: DefaultFileMimeTypes = new DefaultFileMimeTypesProvider(
     FileMimeTypesConfiguration(Map("json" -> "application/json")),
   ).get