test: add ExpectDownload regression test for mobile emulation context#589
Closed
AbhinavMir wants to merge 1 commit into
Closed
test: add ExpectDownload regression test for mobile emulation context#589AbhinavMir wants to merge 1 commit into
AbhinavMir wants to merge 1 commit into
Conversation
Adds TestDownloadInMobileContext covering the iPad Mini / IsMobile + HasTouch context to confirm that the page-level "download" channel event still fires under mobile emulation. Refs playwright-community#579.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a regression test,
TestDownloadInMobileContext, that exercisesPage.ExpectDownloadunder an iPad Mini emulation context (IsMobile: true,HasTouch: true). The test confirms that the page-level"download"channel event still fires correctly under mobile emulation and thatDownload.URL()/Download.SuggestedFilename()return the expected values.Refs #579.
Notes on #579
I was unable to reproduce a real bug from the report. After investigating, the snippet in the issue clicks
<a href="…some.jpg">against a server that does not sendContent-Disposition: attachmentand the anchor has nodownloadattribute, so the browser navigates to the resource instead of triggering a download —ExpectDownloadthen correctly times out. With the same iPad Mini /IsMobilecontext plus a properly configured download (this PR's test),ExpectDownloadresolves as expected.I'm opening this as a draft so a maintainer can decide whether:
downloadattribute /Content-Disposition: attachmentrequirement.Test plan
go test ./tests -run TestDownloadInMobileContext -v— passesgo test ./tests -run "TestDownloadBasic|TestDownloadCancel|TestDownloadInMobileContext" -v— all passgo vet ./...clean,gofmtclean