phpstan 9

Author: smnandre

phpstan.dist.neon

@@ -1,4 +1,4 @@
 parameters:
-    level: 9
+    level: 10
     paths:
         - src/

src/Client/PlaywrightClient.php

@@ -49,7 +49,6 @@ class PlaywrightClient extends AbstractBrowser
 {
     private ?SymfonyRequest $lastSymfonyRequest = null;
     private ?SymfonyResponse $lastSymfonyResponse = null;
-    private ?Crawler $lastCrawler = null;
     /** @var string[] */
     private array $interceptedHosts = ['localhost', '127.0.0.1', 'testapp.local'];
     private ?object $hookReceiver = null;
@@ -167,7 +166,7 @@ public function getCrawler(): Crawler
     {
         $page = $this->getPage();
         if (null === $page) {
-            return $this->lastCrawler = new Crawler('', $this->baseUrl);
+            return new Crawler('', $this->baseUrl);
         }
 
         $content = '';
@@ -188,19 +187,10 @@ public function getCrawler(): Crawler
             }
         }
 
-        return $this->lastCrawler = new Crawler($content, $page->url());
+        return new Crawler($content, $page->url());
     }
 
-    private function getNodeFromField(mixed $field): \DOMElement
-    {
-        $reflection = new \ReflectionClass($field);
-        $property = $reflection->getProperty('node');
-        $node = $property->getValue($field);
-
-        \assert($node instanceof \DOMElement);
 
-        return $node;
-    }
 
     /**
      * @param array<string, mixed> $options

src/Test/Assert/PlaywrightTestAssertionsTrait.php

@@ -65,27 +65,21 @@ protected function assertResponseStatusCode(int $expectedCode): void
     {
         $response = $this->getLastResponse();
         $this->assertNotNull($response, 'No response available');
-        if (null !== $response) {
-            $this->assertSame($expectedCode, $response->getStatusCode(), sprintf('Expected status code %d, got %d', $expectedCode, $response->getStatusCode()));
-        }
+        $this->assertSame($expectedCode, $response->getStatusCode(), sprintf('Expected status code %d, got %d', $expectedCode, $response->getStatusCode()));
     }
 
     protected function assertResponseIsSuccessful(): void
     {
         $response = $this->getLastResponse();
         $this->assertNotNull($response, 'No response available');
-        if (null !== $response) {
-            $this->assertTrue($response->isSuccessful(), sprintf('Expected successful response, got %d', $response->getStatusCode()));
-        }
+        $this->assertTrue($response->isSuccessful(), sprintf('Expected successful response, got %d', $response->getStatusCode()));
     }
 
     protected function assertResponseIsRedirect(): void
     {
         $response = $this->getLastResponse();
         $this->assertNotNull($response, 'No response available');
-        if (null !== $response) {
-            $this->assertTrue($response->isRedirect(), sprintf('Expected redirect response, got %d', $response->getStatusCode()));
-        }
+        $this->assertTrue($response->isRedirect(), sprintf('Expected redirect response, got %d', $response->getStatusCode()));
     }
 
     protected function click(string $selector): void

src/Util/CookieJarSync.php

@@ -30,12 +30,12 @@ public static function fromContext(CookieJar $jar, BrowserContextInterface $cont
         foreach ($context->cookies() as $c) {
             $jar->set(new Cookie(
                 name: (string) $c['name'],
-                value: (string) ($c['value'] ?? ''),
-                expires: isset($c['expires']) ? (int) $c['expires'] : null,
-                path: (string) ($c['path'] ?? '/'),
-                domain: (string) ($c['domain'] ?? ''),
-                secure: (bool) ($c['secure'] ?? false),
-                httponly: (bool) ($c['httpOnly'] ?? false),
+                value: (string) $c['value'],
+                expires: $c['expires'],
+                path: (string) $c['path'],
+                domain: (string) $c['domain'],
+                secure: (bool) $c['secure'],
+                httponly: (bool) $c['httpOnly'],
             ));
         }
     }
@@ -45,12 +45,12 @@ public static function toJarFromUrl(CookieJar $jar, BrowserContextInterface $con
         foreach ($context->cookies([$url]) as $c) {
             $jar->set(new Cookie(
                 name: (string) $c['name'],
-                value: (string) ($c['value'] ?? ''),
-                expires: isset($c['expires']) ? (int) $c['expires'] : null,
-                path: (string) ($c['path'] ?? '/'),
-                domain: (string) ($c['domain'] ?? ''),
-                secure: (bool) ($c['secure'] ?? false),
-                httponly: (bool) ($c['httpOnly'] ?? false),
+                value: (string) $c['value'],
+                expires: $c['expires'],
+                path: (string) $c['path'],
+                domain: (string) $c['domain'],
+                secure: (bool) $c['secure'],
+                httponly: (bool) $c['httpOnly'],
             ));
         }
     }

src/Util/FormInteractor.php

@@ -15,6 +15,7 @@
 namespace Playwright\Symfony\Util;
 
 use Playwright\Page\PageInterface;
+use Symfony\Component\DomCrawler\Field\FormField;
 use Symfony\Component\DomCrawler\Form;
 
 /**
@@ -31,7 +32,7 @@ public static function fill(PageInterface $page, Form $form): void
             $xpath = XPathHelper::buildXPath($node);
             $locator = $page->locator('xpath='.$xpath);
 
-            $type = strtolower($node->getAttribute('type') ?? '');
+            $type = $node->getAttribute('type') ?: '';
 
             if ('select' === $node->tagName) {
                 $values = $field->getValue();
@@ -62,11 +63,15 @@ public static function fill(PageInterface $page, Form $form): void
             }
 
             // Default: text-like inputs and textarea
-            $locator->fill((string) $field->getValue());
+            $value = $field->getValue();
+            if (\is_array($value)) {
+                $value = implode('', $value);
+            }
+            $locator->fill((string) $value);
         }
     }
 
-    private static function getNodeFromField(mixed $field): \DOMElement
+    private static function getNodeFromField(FormField $field): \DOMElement
     {
         $reflection = new \ReflectionClass($field);
         $property = $reflection->getProperty('node');