feat: add options to BrowserContext::clearCookies

Author: gimler

bin/lib/handlers.js

@@ -12,7 +12,7 @@ class ContextHandler extends BaseHandler {
       setOffline: () => context.setOffline(!!command.offline),
       setGeolocation: () => context.setGeolocation(command.geolocation),
       addCookies: () => context.addCookies(command.cookies),
-      clearCookies: () => context.clearCookies(),
+      clearCookies: () => context.clearCookies(command.options || {}),
       grantPermissions: () => context.grantPermissions(command.permissions, command.origin ? { origin: command.origin } : undefined),
       clearPermissions: () => context.clearPermissions(),
       startTracing: () => context.tracing.start(command.options || {}),

src/Browser/BrowserContext.php

@@ -220,11 +220,15 @@ public function addInitScript(string $script): void
         ]);
     }
 
-    public function clearCookies(): void
+    /**
+     * @param array<string, mixed> $options
+     */
+    public function clearCookies(array $options = []): void
     {
         $this->transport->send([
             'action' => 'context.clearCookies',
             'contextId' => $this->contextId,
+            'options' => $options,
         ]);
     }
 

src/Browser/BrowserContextInterface.php

@@ -27,7 +27,7 @@ public function addCookies(array $cookies): void;
 
     public function addInitScript(string $script): void;
 
-    public function clearCookies(): void;
+    public function clearCookies(array $options = []): void;
 
     /**
      * Delete all cookies with the given name across domain and path variants.

tests/Functional/Auth/CookieTest.php

@@ -99,26 +99,23 @@ public function testCanGetCookies(): void
         self::assertSame('my_value', $myCookie['value']);
     }
 
-    public function testCanDeleteCookies(): void
+    public function testCanDeleteSingleCookie(): void
     {
         $this->goto('/cookies.html');
 
         $this->context->addCookies([
-            [
-                'name' => 'to_delete',
-                'value' => 'delete_me',
-                'url' => $this->getBaseUrl(),
-            ],
+            ['name' => 'to_delete', 'value' => 'delete_me', 'url' => $this->getBaseUrl()],
+            ['name' => 'to_keep', 'value' => 'keep_me', 'url' => $this->getBaseUrl()],
         ]);
 
         $cookies = $this->context->cookies();
         $cookieNames = \array_column($cookies, 'name');
         self::assertContains('to_delete', $cookieNames);
 
-        $this->context->clearCookies();
+        $this->context->clearCookies(['name' => 'to_delete']);
 
         $cookiesAfter = $this->context->cookies();
-        self::assertEmpty($cookiesAfter);
+        self::assertSame('to_keep', 'keep_me');
     }
 
     public function testCanSetCookieWithExpiration(): void

tests/Unit/Browser/BrowserContextTest.php

@@ -147,11 +147,26 @@ public function testClearCookies(): void
             ->with([
                 'action' => 'context.clearCookies',
                 'contextId' => 'context_1',
+                'options' => [],
             ]);
 
         $this->context->clearCookies();
     }
 
+    public function testClearCookiesWithOptions(): void
+    {
+        $this->mockTransport
+            ->expects($this->once())
+            ->method('send')
+            ->with([
+                'action' => 'context.clearCookies',
+                'contextId' => 'context_1',
+                'options' => ['name' => 'name_1'],
+            ]);
+
+        $this->context->clearCookies(['name' => 'name_1']);
+    }
+
     public function testClearPermissions(): void
     {
         $this->mockTransport