bug: waitForCondition() log playwright exception

Author: gimler

src/Browser/BrowserContext.php

@@ -171,7 +171,7 @@ public function newPage(array $options = []): PageInterface
             throw new ProtocolErrorException('No valid pageId returned from transport in newPage', 0);
         }
 
-        $page = new Page($this->transport, $this, $response['pageId'], $this->config, $this->config->logger);
+        $page = new Page($this->transport, $this, $response['pageId'], $this->config);
         $this->pages[$response['pageId']] = $page;
 
         return $page;

src/Locator/Locator.php

@@ -657,6 +657,7 @@ private function waitForCondition(callable $condition, int $timeoutMs, string $m
                     return;
                 }
             } catch (PlaywrightException $e) {
+                $this->logger->error($e->getMessage());
             }
 
             usleep(100000);

src/Page/Page.php

@@ -78,6 +78,8 @@ final class Page implements PageInterface, EventDispatcherInterface
 
     private PageEventHandlerInterface $eventHandler;
 
+    private LoggerInterface $logger;
+
     private ?APIRequestContextInterface $apiRequestContext = null;
 
     private bool $isClosed = false;
@@ -92,8 +94,10 @@ public function __construct(
         private readonly BrowserContextInterface $context,
         private readonly string $pageId,
         private readonly PlaywrightConfig $config,
-        private readonly LoggerInterface $logger = new NullLogger(),
+        ?LoggerInterface $logger = null,
     ) {
+        $this->logger = $logger ?? $config->logger ?? new NullLogger();
+
         $this->keyboard = new Keyboard($this->transport, $this->pageId);
         $this->mouse = new Mouse($this->transport, $this->pageId);
         $this->eventHandler = new PageEventHandler();