Merge pull request #51 from ssmiller25/bug/manifest-withiplisten

Accomidate for exceptions for IP Address Parameters

Author: acastle

internal/manifest/kubernetes.go

@@ -5,6 +5,7 @@ import (
 	"io/ioutil"
 	"os"
 	"path/filepath"
+	"regexp"
 	"runtime"
 	"strings"
 
@@ -227,6 +228,7 @@ func getImagesFromContainers(containers []corev1.Container) []string {
 	var images []string
 
 	var imgStringsToFilter []string
+	var regexToFilter []string
 
 	//Work-around for mis-identified image parameters that include a URL
 	imgStringsToFilter = append(imgStringsToFilter, "http://")
@@ -243,6 +245,9 @@ func getImagesFromContainers(containers []corev1.Container) []string {
 	imgStringsToFilter = append(imgStringsToFilter, ":critical")
 	imgStringsToFilter = append(imgStringsToFilter, ":off")
 
+	// Looking for strings like 0.0.0.0:5332
+	regexToFilter = append(regexToFilter, ".*\\d*\\.\\d*:\\d")
+
 	for _, container := range containers {
 		images = append(images, container.Image)
 
@@ -267,6 +272,14 @@ func getImagesFromContainers(containers []corev1.Container) []string {
 				}
 			}
 
+			for _, regexpPattern := range regexToFilter {
+				found, _ := regexp.MatchString(regexpPattern, image)
+
+				if found {
+					skiploop = true
+				}
+			}
+
 			if skiploop {
 				continue
 			}

internal/manifest/kubernetes_test.go

@@ -81,3 +81,24 @@ func TestGetImagesFromContainers_WithLogComponent(t *testing.T) {
 	}
 
 }
+
+func TestGetImagesFromContainers_WithIPParameter(t *testing.T) {
+	containers := []corev1.Container{
+		{
+			Image: "baseimage:v1",
+			Args: []string{
+				"--serving-address=0.0.0.0:6443",
+			},
+		},
+	}
+	actual := getImagesFromContainers(containers)
+
+	if !contains(actual, "baseimage:v1") {
+		t.Errorf("expected baseimage:v1 to exist in list of images but it did not: %v", actual)
+	}
+
+	if contains(actual, "0.0.0.0:6443") {
+		t.Errorf("Invalid image parsing for args contain an ip addresses: %v", actual)
+	}
+
+}