Update golangci-lint configuration and fix issues

Author: Danielius1922

.golangci.yml

@@ -1,45 +1,46 @@
 linters-settings:
-  govet:
-    check-shadowing: true
   exhaustive:
     default-signifies-exhaustive: true
   gocyclo:
     min-complexity: 15
   gomoddirectives:
     replace-allow-list:
       - github.com/pion/dtls/v2
+  govet:
+    enable:
+      - nilness
+      - shadow
   gomodguard:
     blocked:
       modules:
         - github.com/pkg/errors:
             recommendations:
             - errors
   stylecheck:
-    go: "1.18"
     checks: ["all", "-ST1000" , "-ST1003"]
 
+
 linters:
   enable:
+    - asasalint        # Check for pass []any as any in variadic func(...any)
     - asciicheck       # Simple linter to check that your code does not contain non-ASCII identifiers
     - bidichk          # Checks for dangerous unicode character sequences
-    # - bodyclose        # checks whether HTTP response body is closed successfully
-    # - contextcheck     # check the function whether use a non-inherited context
-    - decorder         # check declaration order and count of types, constants, variables and functions
-    # - depguard         # Go linter that checks if package imports are in a list of acceptable packages
+    - bodyclose        # Checks whether HTTP response body is closed successfully
+    # - copyloopvar      # Detects places where loop variables are copied
+    - decorder         # Check declaration order and count of types, constants, variables and functions
     - dogsled          # Checks assignments with too many blank identifiers (e.g. x, _, _, _, := f())
     - dupl             # Tool for code clone detection
-    - durationcheck    # check for two durations multiplied together
+    - dupword          # A linter that checks for duplicate words in the source code (usually miswritten)
+    - durationcheck    # Check for two durations multiplied together
     - errcheck         # Errcheck is a program for checking for unchecked errors in go programs. These unchecked errors can be critical bugs in some cases
     - errchkjson       # Checks types passed to the json encoding functions. Reports unsupported types and optionally reports occasions, where the check for the returned error can be omitted.
     - errname          # Checks that sentinel errors are prefixed with the `Err` and error types are suffixed with the `Error`.
     - errorlint        # errorlint is a linter for that can be used to find code that will cause problems with the error wrapping scheme introduced in Go 1.13.
-    - exhaustive       # check exhaustiveness of enum switch statements
+    - execinquery      # Execinquery is a linter about query string checker in Query function which reads your Go src files and warning it finds.
     - exportloopref    # checks for pointers to enclosing loop variables
-    # - forbidigo        # Forbids identifiers
     - forcetypeassert  # finds forced type assertions
     - gci              # Gci control golang package import order and make it always deterministic.
-    # - gochecknoglobals # Checks that no globals are present in Go code
-    # - gochecknoinits   # Checks that no init functions are present in Go code
+    - gocheckcompilerdirectives  # Checks that go compiler directive comments (//go:) are valid.
     - gocognit         # Computes and checks the cognitive complexity of functions
     - goconst          # Finds repeated strings that could be replaced by a constant
     - gocritic         # The most opinionated Go source code linter
@@ -54,51 +55,75 @@ linters:
     - gomodguard       # Allow and block list linter for direct Go module dependencies. This is different from depguard where there are different block types for example version constraints and module recommendations.
     - goprintffuncname # Checks that printf-like functions are named with `f` at the end
     - gosec            # Inspects source code for security problems
+    - gosmopolitan     # Report certain i18n/l10n anti-patterns in your Go codebase
     - gosimple         # Linter for Go source code that specializes in simplifying a code
     - govet            # Vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string
-    - grouper          # An analyzer to analyze expression groups.
+    - grouper          # An analyzer to analyze expression groups
     - importas         # Enforces consistent import aliases
     - ineffassign      # Detects when assignments to existing variables are not used
+    # - intrange         # Intrange is a linter to find places where for loops could make use of an integer range
+    - loggercheck      # Checks key value pairs for common logger libraries (kitlog,klog,logr,zap).
+    - makezero         # Finds slice declarations with non-zero initial length
+    - mirror           # Reports wrong mirror patterns of bytes/strings usage
     - misspell         # Finds commonly misspelled English words in comments
     - nakedret         # Finds naked returns in functions greater than a specified function length
+    - nestif           # Reports deeply nested if statements
     - nilerr           # Finds the code that returns nil even if it checks that the error is not nil.
     - nilnil           # Checks that there is no simultaneous return of `nil` error and an invalid value.
-    # - noctx            # noctx finds sending http request without context.Context
+    - noctx            # noctx finds sending http request without context.Context
     - nolintlint       # Reports ill-formed or insufficient nolint directives
-    # - paralleltest     # paralleltest detects missing usage of t.Parallel() method in your Go test
+    - nosprintfhostport # Checks for misuse of Sprintf to construct a host with port in a URL
+    - perfsprint       # Checks that fmt.Sprintf can be replaced with a faster alternative.
+    - prealloc         # Finds slice declarations that could potentially be preallocated
     - predeclared      # find code that shadows one of Go's predeclared identifiers
-    # - revive           # golint replacement, finds style mistakes
+    - protogetter      # Reports direct reads from proto message fields when getters should be used.
+    - revive           # golint replacement, finds style mistakes
+    - reassign         # Checks that package variables are not reassigned
+    - sloglint         # Ensure consistent code style when using log/slog
+    - spancheck        # Checks for mistakes with OpenTelemetry/Census spans
     - staticcheck      # Staticcheck is a go vet on steroids, applying a ton of static analysis checks
     - stylecheck       # Stylecheck is a replacement for golint
+    - tagliatelle      # Checks the struct tags.
     - tenv             # tenv is analyzer that detects using os.Setenv instead of t.Setenv since Go1.17
-    # - tparallel        # tparallel detects inappropriate usage of t.Parallel() method in your Go test codes
+    - testableexamples # linter checks if examples are testable (have an expected output)
+    - testifylint      # Checks usage of github.com/stretchr/testify.
+    - tparallel        # tparallel detects inappropriate usage of t.Parallel() method in your Go test codes
     - typecheck        # Like the front-end of a Go compiler, parses and type-checks Go code
     - unconvert        # Remove unnecessary type conversions
     - unparam          # Reports unused function parameters
     - unused           # Checks Go code for unused constants, variables, functions and types
-    # - wastedassign     # wastedassign finds wasted assignment statements
+    - usestdlibvars    # A linter that detect the possibility to use variables/constants from the Go standard library.
+    - wastedassign     # wastedassign finds wasted assignment statements
     - whitespace       # Tool for detection of leading and trailing whitespace
-    - makezero         # Finds slice declarations with non-zero initial length
-    - nestif           # Reports deeply nested if statements
-    - prealloc         # Finds slice declarations that could potentially be preallocated
-    - tagliatelle      # Checks the struct tags.
-    - testpackage      # linter that makes you use a separate _test package
   disable:
-    - structcheck      # Finds unused struct fields
     - containedctx     # containedctx is a linter that detects struct contained context.Context field
+    - contextcheck     # check the function whether use a non-inherited context
     - cyclop           # checks function and package cyclomatic complexity
+    - depguard         # Go linter that checks if package imports are in a list of acceptable packages
+    - exhaustive       # Check exhaustiveness of enum switch statements
     - exhaustivestruct # Checks if all struct's fields are initialized
+    - exhaustruct      # Checks if all structure fields are initialized.
+    - forbidigo        # Forbids identifiers
     - funlen           # Tool for detection of long functions
+    - gochecknoglobals # Checks that no globals are present in Go code
+    - gochecknoinits   # Checks that no init functions are present in Go code
     - godot            # Check if comments end in a period
     - gomnd            # An analyzer to detect magic numbers.
+    - ifshort          # Checks that your code uses short syntax for if-statements whenever possible
+    - inamedparam      # Reports interfaces with unnamed method parameters.
+    - interfacebloat   # A linter that checks the number of methods inside an interface
     - ireturn          # Accept Interfaces, Return Concrete Types
     - lll              # Reports long lines
     - maintidx         # maintidx measures the maintainability index of each function.
     - maligned         # Tool to detect Go structs that would take less memory if their fields were sorted
     - nlreturn         # nlreturn checks for a new line before return and branch statements to increase code clarity
+    - nonamedreturns   # Reports all named returns
+    - paralleltest     # paralleltest detects missing usage of t.Parallel() method in your Go test
     - promlinter       # Check Prometheus metrics naming via promlint
     - rowserrcheck     # checks whether Err of rows is checked successfully
     - sqlclosecheck    # Checks that sql.Rows and sql.Stmt are closed.
+    - tagalign         # Check that struct tags are well aligned.
+    - testpackage      # linter that makes you use a separate _test package
     - thelper          # thelper detects golang test helpers without t.Helper() call and checks the consistency of test helpers
     - varnamelen       # checks that the length of a variable's name matches its scope
     - wrapcheck        # Checks that errors returned from external packages are wrapped
@@ -110,11 +135,16 @@ linters:
 
 issues:
   exclude-use-default: false
+  exclude-dirs:
+    - dependency
   exclude-rules:
     # Allow complex tests, better to be self contained
     - path: _test\.go
       linters:
         - goconst
+    - text: "var-naming:|exported:|package-comments:"
+      linters:
+        - revive
 
 run:
-  skip-dirs-use-default: false
+  go: "1.20"

pb/get_configuration.go

@@ -35,7 +35,7 @@ func (c *UserAgent) Clone() *UserAgent {
 		return nil
 	}
 	return &UserAgent{
-		CsrChallengeStateExpiration: c.CsrChallengeStateExpiration,
+		CsrChallengeStateExpiration: c.GetCsrChallengeStateExpiration(),
 	}
 }
 
@@ -102,7 +102,7 @@ func (r *GetConfigurationResponse) Clone() *GetConfigurationResponse {
 		CommitHash:         r.GetBuildInfo().GetCommitHash(),
 		CommitDate:         r.GetBuildInfo().GetCommitDate(),
 		ReleaseUrl:         r.GetBuildInfo().GetReleaseUrl(),
-		RemoteProvisioning: r.RemoteProvisioning.Clone(),
+		RemoteProvisioning: r.GetRemoteProvisioning().Clone(),
 		BuildInfo:          r.GetBuildInfo().Clone(),
 		Ui:                 r.GetUi().Clone(),
 	}

service/config/config.go

@@ -17,6 +17,7 @@
 package config
 
 import (
+	"errors"
 	"fmt"
 
 	"github.com/plgd-dev/client-application/service/config/device"
@@ -38,7 +39,7 @@ type Config struct {
 
 func New(configPath string) (Config, error) {
 	if configPath == "" {
-		return Config{}, fmt.Errorf("path to config is empty")
+		return Config{}, errors.New("path to config is empty")
 	}
 	var cfg Config
 	if err := config.LoadAndValidateConfig(&cfg); err != nil {
@@ -85,7 +86,7 @@ type APIsConfig struct {
 
 func (c *APIsConfig) Validate() error {
 	if !c.HTTP.Enabled && !c.GRPC.Enabled {
-		return fmt.Errorf("http or grpc must be enabled")
+		return errors.New("http or grpc must be enabled")
 	}
 	if c.HTTP.Enabled {
 		if err := c.HTTP.Validate(); err != nil {

service/device/authenticationPreSharedKey.go

@@ -68,7 +68,7 @@ func (s *authenticationPreSharedKey) DialDTLS(ctx context.Context, addr string,
 	idBin, _ := subjectUUID.MarshalBinary()
 	dtlsCfg := &dtls.Config{
 		PSKIdentityHint: idBin,
-		PSK: func(b []byte) ([]byte, error) {
+		PSK: func([]byte) ([]byte, error) {
 			// iotivity-lite supports only 16-byte PSK
 			return toKeyBin(key), nil
 		},
@@ -77,7 +77,7 @@ func (s *authenticationPreSharedKey) DialDTLS(ctx context.Context, addr string,
 	return coap.DialUDPSecure(ctx, addr, dtlsCfg, opts...)
 }
 
-func (s *authenticationPreSharedKey) DialTLS(ctx context.Context, addr string, tlsCfg *tls.Config, opts ...tcp.Option) (*coap.ClientCloseHandler, error) {
+func (s *authenticationPreSharedKey) DialTLS(_ context.Context, _ string, _ *tls.Config, _ ...tcp.Option) (*coap.ClientCloseHandler, error) {
 	return nil, errPreSharedKeyAuthentication
 }
 
@@ -94,11 +94,11 @@ func (s *authenticationPreSharedKey) GetOwnOptions() ([]core.OwnOption, error) {
 	return []core.OwnOption{core.WithPresharedKey(toKeyBin(key))}, nil
 }
 
-func (s *authenticationPreSharedKey) GetIdentityCSR(id string) ([]byte, error) {
+func (s *authenticationPreSharedKey) GetIdentityCSR(_ string) ([]byte, error) {
 	return nil, errPreSharedKeyAuthentication
 }
 
-func (s *authenticationPreSharedKey) SetIdentityCertificate(owner string, chainPem []byte) error {
+func (s *authenticationPreSharedKey) SetIdentityCertificate(_ string, _ []byte) error {
 	return errPreSharedKeyAuthentication
 }
 

service/device/authenticationX509.go

@@ -24,6 +24,7 @@ import (
 	"crypto/tls"
 	"crypto/x509"
 	"encoding/pem"
+	"errors"
 	"fmt"
 	"time"
 
@@ -53,7 +54,7 @@ func newAuthenticationX509(config configDevice.Config) *authenticationX509 {
 func (s *authenticationX509) getTLSCertificate() (*tls.Certificate, error) {
 	crt := s.certificate.Load()
 	if crt == nil || crt.Leaf == nil {
-		return nil, fmt.Errorf("certificate hasn't been set")
+		return nil, errors.New("certificate hasn't been set")
 	}
 	if crt.Leaf.NotAfter.Before(time.Now()) {
 		return nil, fmt.Errorf("certificate is not valid after %v", crt.Leaf.NotAfter)
@@ -70,7 +71,7 @@ func getRootCAFromChain(chain [][]byte) (*x509.Certificate, error) {
 		return nil, err
 	}
 	if !rootCA.IsCA || rootCA.Issuer.CommonName != rootCA.Subject.CommonName {
-		return nil, fmt.Errorf("invalid root certificate")
+		return nil, errors.New("invalid root certificate")
 	}
 	return rootCA, nil
 }
@@ -187,7 +188,7 @@ func (s *authenticationX509) updateCertificate(crt tls.Certificate) error {
 func (s *authenticationX509) SetIdentityCertificate(owner string, chainPem []byte) error {
 	privateKey := s.privateKey.Load()
 	if privateKey == nil {
-		return fmt.Errorf("private key is not set")
+		return errors.New("private key is not set")
 	}
 	keyPem, err := encodePrivateKeyToPem(privateKey)
 	if err != nil {

service/device/service.go

@@ -20,6 +20,7 @@ import (
 	"context"
 	"crypto/tls"
 	"crypto/x509"
+	"errors"
 	"fmt"
 	"net"
 	"sync"
@@ -86,7 +87,7 @@ func New(ctx context.Context, getConfig func() configDevice.Config, logger log.L
 	case configDevice.AuthenticationX509:
 		authenticationClient = newAuthenticationX509(config)
 	case configDevice.AuthenticationUninitialized:
-		return nil, fmt.Errorf("device is not initialized")
+		return nil, errors.New("device is not initialized")
 	}
 
 	opts := []udpServer.Option{
@@ -182,7 +183,7 @@ func (c *UDPClientConn) Context() context.Context {
 	return cc.Context()
 }
 
-func (s *Service) DialUDP(ctx context.Context, addr string, opts ...udp.Option) (*coap.ClientCloseHandler, error) {
+func (s *Service) DialUDP(_ context.Context, addr string, _ ...udp.Option) (*coap.ClientCloseHandler, error) {
 	udpAddr, err := net.ResolveUDPAddr("udp", addr)
 	if err != nil {
 		return nil, err
@@ -199,12 +200,12 @@ func (s *Service) DialUDP(ctx context.Context, addr string, opts ...udp.Option)
 	closeHandler := cc.Context().Value(&closeHandlerKey)
 	if closeHandler == nil {
 		_ = cc.Close()
-		return nil, fmt.Errorf("failed to create client connection: close handler is nil")
+		return nil, errors.New("failed to create client connection: close handler is nil")
 	}
 	h, ok := closeHandler.(*coap.OnCloseHandler)
 	if !ok {
 		_ = cc.Close()
-		return nil, fmt.Errorf("failed to create client connection: close handler is not *coap.OnCloseHandler")
+		return nil, errors.New("failed to create client connection: close handler is not *coap.OnCloseHandler")
 	}
 	return coap.NewClientCloseHandler(&UDPClientConn{Conn: cc}, h), nil
 }

service/grpc/clearCache.go

@@ -53,7 +53,7 @@ func closeDevices(devices map[uuid.UUID]*device) error {
 	}
 }
 
-func (s *ClientApplicationServer) ClearCache(ctx context.Context, _ *pb.ClearCacheRequest) (*pb.ClearCacheResponse, error) {
+func (s *ClientApplicationServer) ClearCache(_ context.Context, _ *pb.ClearCacheRequest) (*pb.ClearCacheResponse, error) {
 	devices := s.devices.LoadAndDeleteAll()
 	go func(devices map[uuid.UUID]*device) {
 		err := closeDevices(devices)

service/grpc/clearCache_test.go

@@ -49,21 +49,21 @@ func TestClientApplicationServerClearCache(t *testing.T) {
 
 	// get device
 	d1, err := s.GetDevice(ctx, &pb.GetDeviceRequest{
-		DeviceId: dev.Id,
+		DeviceId: dev.GetId(),
 	})
 	require.NoError(t, err)
 	require.Equal(t, dev, d1)
 
 	// own device
 	_, err = s.OwnDevice(ctx, &pb.OwnDeviceRequest{
-		DeviceId: dev.Id,
+		DeviceId: dev.GetId(),
 	})
 	require.NoError(t, err)
 
 	// update resource - dtls connection will be created
 	newName := test.DevsimName + "_new"
 	_, err = s.UpdateResource(ctx, &pb.UpdateResourceRequest{
-		ResourceId: commands.NewResourceID(dev.Id, configuration.ResourceURI),
+		ResourceId: commands.NewResourceID(dev.GetId(), configuration.ResourceURI),
 		Content: &grpcgwPb.Content{
 			ContentType: serviceHttp.ApplicationJsonContentType,
 			Data:        []byte(`{"n":"` + newName + `"}`),
@@ -73,7 +73,7 @@ func TestClientApplicationServerClearCache(t *testing.T) {
 
 	// get device - udp connection will be created
 	d1, err = s.GetDevice(ctx, &pb.GetDeviceRequest{
-		DeviceId: dev.Id,
+		DeviceId: dev.GetId(),
 	})
 	require.NoError(t, err)
 	var v plgdDevice.Device
@@ -87,7 +87,7 @@ func TestClientApplicationServerClearCache(t *testing.T) {
 
 	// get device - cache is empty so expected error
 	_, err = s.GetDevice(ctx, &pb.GetDeviceRequest{
-		DeviceId: dev.Id,
+		DeviceId: dev.GetId(),
 	})
 	require.Error(t, err)
 
@@ -99,7 +99,7 @@ func TestClientApplicationServerClearCache(t *testing.T) {
 
 	// revert resource update
 	_, err = s.UpdateResource(ctx, &pb.UpdateResourceRequest{
-		ResourceId: commands.NewResourceID(dev.Id, configuration.ResourceURI),
+		ResourceId: commands.NewResourceID(dev.GetId(), configuration.ResourceURI),
 		Content: &grpcgwPb.Content{
 			ContentType: serviceHttp.ApplicationJsonContentType,
 			Data:        []byte(`{"n":"` + test.DevsimName + `"}`),
@@ -109,7 +109,7 @@ func TestClientApplicationServerClearCache(t *testing.T) {
 
 	// disown device
 	_, err = s.DisownDevice(ctx, &pb.DisownDeviceRequest{
-		DeviceId: dev.Id,
+		DeviceId: dev.GetId(),
 	})
 	require.NoError(t, err)
 }