Skip to content

fix(blockwise): return 4.08 on incomplete Block1 and make receive cache limit configurable #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jkralik wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(blockwise): return 4.08 on incomplete Block1 and make receive cache limit configurable #677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion dtls/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,14 +97,16 @@ func Client(conn *dtls.Conn, opts ...udp.Option) *udpClient.Conn {
if cfg.BlockwiseEnable {
createBlockWise = func(cc *udpClient.Conn) *blockwise.BlockWise[*udpClient.Conn] {
v := cc
return blockwise.New(
bw := blockwise.New(
v,
cfg.BlockwiseTransferTimeout,
cfg.Errors,
func(token message.Token) (*pool.Message, bool) {
return v.GetObservationRequest(token)
},
)
bw.SetReceivingMessagesCacheMaxEntries(cfg.BlockwiseReceivingMessagesCacheMaxEntries)
return bw
}
}

Expand Down
4 changes: 3 additions & 1 deletion dtls/server/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,14 +218,16 @@ func (s *Server) createConn(connection *coapNet.Conn, inactivityMonitor udpClien
if s.cfg.BlockwiseEnable {
createBlockWise = func(cc *udpClient.Conn) *blockwise.BlockWise[*udpClient.Conn] {
v := cc
return blockwise.New(
bw := blockwise.New(
v,
s.cfg.BlockwiseTransferTimeout,
s.cfg.Errors,
func(token message.Token) (*pool.Message, bool) {
return v.GetObservationRequest(token)
},
)
bw.SetReceivingMessagesCacheMaxEntries(s.cfg.BlockwiseReceivingMessagesCacheMaxEntries)
return bw
}
}
session := NewSession(
Expand Down
Loading
Loading