fix tests

Author: petschki

src/pat/modal/modal.js

@@ -702,7 +702,7 @@ export default Base.extend({
         self.$wrapper.addClass("image-modal");
         var src = self.$el.attr("href");
         var srcset = self.$el.attr("data-modal-srcset") || "";
-        var title = $.trim(self.$el.context.innerText) || "Image";
+        var title = (self.$el[0]?.innerText || "").trim() || "Image";
         // XXX aria?
         self.$raw = $(
             "<div><h1>" +

src/pat/querystring/querystring.test.js

@@ -2,12 +2,7 @@ import "./querystring";
 import registry from "@patternslib/patternslib/src/core/registry";
 import utils from "@patternslib/patternslib/src/core/utils";
 
-const mockFetch =
-    (json = {}) =>
-    () =>
-        Promise.resolve({
-            json: () => Promise.resolve(json),
-        });
+const mockFetch = global.mockFetch;
 
 describe("Querystring", function () {
     beforeEach(() => {

src/pat/relateditems/relateditems.js

@@ -7,8 +7,8 @@ import registry from "@patternslib/patternslib/src/core/registry";
 import Select2 from "../select2/select2";
 
 const KEY = {
-    LEFT: 37,
-    RIGHT: 39,
+    LEFT: "ArrowLeft",
+    RIGHT: "ArrowRight",
 };
 
 export default Base.extend({
@@ -702,11 +702,11 @@ export default Base.extend({
                 return;
             }
 
-            if (event.which === KEY.LEFT || event.which === KEY.RIGHT) {
+            if (event.key === KEY.LEFT || event.key === KEY.RIGHT) {
                 event.stopPropagation();
 
                 const selectorContext =
-                    event.which === KEY.LEFT
+                    event.key === KEY.LEFT
                         ? ".pat-relateditems-result.one-level-up"
                         : ".select2-highlighted";
 

src/pat/select2/select2.test.js

@@ -226,8 +226,8 @@ describe("Select2", function () {
 
         var $results = $("li.select2-search-choice");
         expect($results.length).toEqual(2);
-        expect($.trim($results.eq(0).text())).toEqual("Yellow");
-        expect($.trim($results.eq(1).text())).toEqual("Red");
+        expect($results.eq(0).text().trim()).toEqual("Yellow");
+        expect($results.eq(1).text().trim()).toEqual("Red");
 
         var firstElem = $results.eq(0);
         // css class is set and proxy is created when starting to drag
@@ -330,7 +330,7 @@ describe("Select2", function () {
         expect($("#test-select2").val()).toEqual("1;3");
         var $results = $("li.select2-search-choice");
         expect($results.length).toEqual(2);
-        expect($.trim($results.eq(0).text())).toEqual("One");
-        expect($.trim($results.eq(1).text())).toEqual("Three");
+        expect($results.eq(0).text().trim()).toEqual("One");
+        expect($results.eq(1).text().trim()).toEqual("Three");
     });
 });

src/pat/structure/structure.test.js

@@ -42,12 +42,7 @@ function getQueryVariable(url, variable) {
 
 var extraDataJsonItem = null;
 
-const mockFetch =
-    (json = {}) =>
-    () =>
-        Promise.resolve({
-            json: () => Promise.resolve(json),
-        });
+const mockFetch = global.mockFetch;
 
 /* ==========================
     TEST: AppView constructor internal attribute/object correctness

src/setup-tests.js

@@ -1,5 +1,37 @@
 // Extra test setup.
 
+// Mock fetch for jsdom environment which doesn't support it natively.
+// Default implementation returns an empty 200 response.
+if (!global.fetch) {
+    global.fetch = () =>
+        Promise.resolve({
+            status: 200,
+            statusText: "OK",
+            headers: {
+                get: () => null,
+                forEach: () => {},
+            },
+            json: () => Promise.resolve({}),
+            text: () => Promise.resolve(""),
+        });
+}
+
+// Factory for creating fetch mocks that return a specific JSON payload.
+// Usage in tests: global.fetch = jest.fn().mockImplementation(mockFetch({ ... }))
+global.mockFetch =
+    (json = {}) =>
+    () =>
+        Promise.resolve({
+            status: 200,
+            statusText: "OK",
+            headers: {
+                get: () => null,
+                forEach: () => {},
+            },
+            json: () => Promise.resolve(json),
+            text: () => Promise.resolve(JSON.stringify(json)),
+        });
+
 // provide jquery
 import jquery from "jquery";
 global.$ = global.jQuery = jquery;