Skip to content

pat-filemanager: use current page language to render the datetime #1607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MrTango merged 3 commits into from
Jun 23, 2026
Merged

pat-filemanager: use current page language to render the datetime #1607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc08a48
fix(pat-filemanager): Use site language in formatDate
erral Jun 17, 2026
a84f920
maint(pat-filemanager): Use distinct locales (en/es) for formatDate t…
erral Jun 17, 2026
66218b0
Merge branch 'master' into fix-filemanager-date-locale
MrTango Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/pat/filemanager/src/utils/format.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,24 @@ describe("formatDate", () => {
it("formats a real date string", () => {
expect(formatDate(PAST)).not.toBe("");
});

it("respects the document language (es)", () => {
const originalLang = document.documentElement.lang;
document.documentElement.lang = "es";
const formatted = formatDate(PAST);
// "ene" is the short month in Spanish for January (January 1st, 2020)
expect(formatted).toContain("ene");
document.documentElement.lang = originalLang;
});

it("respects the document language (en)", () => {
const originalLang = document.documentElement.lang;
document.documentElement.lang = "en";
const formatted = formatDate(PAST);
// "Jan" is the short month in English for January
expect(formatted).toContain("Jan");
document.documentElement.lang = originalLang;
});
});

describe("formatSize", () => {
Expand Down
8 changes: 7 additions & 1 deletion src/pat/filemanager/src/utils/format.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,16 @@ function parseDate(value: unknown): Date | null {
return Number.isNaN(date.getTime()) ? null : date;
}

/** Detect the current UI language from the <html> tag, normalized for Intl. */
function getLang(): string {
if (typeof document === "undefined") return "en";
return (document.documentElement.lang || "en").replace("_", "-");
}

export function formatDate(value: unknown): string {
const date = parseDate(value);
if (!date) return "";
return new Intl.DateTimeFormat(undefined, {
return new Intl.DateTimeFormat(getLang(), {
year: "numeric",
month: "short",
day: "numeric",
Expand Down
Loading